Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
From: "Dmitry V. Levin" <ldv@altlinux.org>
To: Ma Jun <majun258@linux.alibaba.com>
Cc: ren_guo@c-sky.com, linux-csky@vger.kernel.org,
	strace-devel@lists.strace.io
Subject: Re: [RESEND PATCH] arch/csky: Fix the compile error when use abiv1
Date: Tue, 11 Feb 2020 11:37:02 +0300
Message-ID: <20200211083702.GA4026@altlinux.org> (raw)
In-Reply-To: <1581317988-3826-1-git-send-email-majun258@linux.alibaba.com>

On Mon, Feb 10, 2020 at 02:59:48PM +0800, Ma Jun wrote:
> From: MaJun <majun258@linux.alibaba.com>
> 
> Fix the bug caused by csky_regs. Because this struct
> has no member r1, only a1.
> 
> Signed-off-by: Ma Jun <majun258@linux.alibaba.com>
> ---
>  linux/csky/get_scno.c | 2 +-
>  linux/csky/set_scno.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux/csky/get_scno.c b/linux/csky/get_scno.c
> index 9efb202..9d4397a 100644
> --- a/linux/csky/get_scno.c
> +++ b/linux/csky/get_scno.c
> @@ -12,7 +12,7 @@ arch_get_scno(struct tcb *tcp)
>  #if defined(__CSKYABIV2__)
>  	tcp->scno = csky_regs.regs[3];
>  #else
> -	tcp->scno = csky_regs.r1;
> +	tcp->scno = csky_regs.a1;
>  #endif
>  	return 1;
>  }
> diff --git a/linux/csky/set_scno.c b/linux/csky/set_scno.c
> index 655d108..c1e1c18 100644
> --- a/linux/csky/set_scno.c
> +++ b/linux/csky/set_scno.c
> @@ -13,7 +13,7 @@ arch_set_scno(struct tcb *tcp, kernel_ulong_t scno)
>  #if defined(__CSKYABIV2__)
>  	csky_regs.regs[3] = scno;
>  #else
> -	csky_regs.r1 = scno;
> +	csky_regs.a1 = scno;
>  #endif
>  	return set_regs(tcp->pid);
>  }

Applied, thanks.


-- 
ldv

      reply index

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10  6:59 Ma Jun
2020-02-11  8:37 ` Dmitry V. Levin [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200211083702.GA4026@altlinux.org \
    --to=ldv@altlinux.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=majun258@linux.alibaba.com \
    --cc=ren_guo@c-sky.com \
    --cc=strace-devel@lists.strace.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git