From: Tobias Klauser <tklauser@distanz.ch>
To: Guo Ren <guoren@kernel.org>
Cc: Mao Han <han_mao@c-sky.com>,
linux-csky@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] csky: remove unusued thread_saved_pc and *_segments functions/macros
Date: Mon, 15 Jun 2020 10:43:15 +0200 [thread overview]
Message-ID: <20200615084314.rwabrkyy7wwgwdxc@distanz.ch> (raw)
In-Reply-To: <CAJF2gTRGVQcn5Hu+kaHfzhEpyXuMkQQYyfHkuxREYci4QJ0SoQ@mail.gmail.com>
On 2020-06-13 at 10:42:07 +0200, Guo Ren <guoren@kernel.org> wrote:
> Acked-by: Guo Ren <guoren@kernel.org>
Thanks for the Ack. Are you taking this patch through your own tree or
should I directly submit to someone else?
> On Wed, Jun 10, 2020 at 11:45 PM Tobias Klauser <tklauser@distanz.ch> wrote:
> >
> > These are used nowhere in the tree (except for some architectures which
> > define them for their own use) and were already removed for other
> > architectures in:
> >
> > commit 6474924e2b5d ("arch: remove unused macro/function thread_saved_pc()")
> > commit c17c02040bf0 ("arch: remove unused *_segments() macros/functions")
> >
> > Remove them from arch/csky as well.
> >
> > Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> > ---
> > arch/csky/include/asm/processor.h | 6 ------
> > arch/csky/kernel/process.c | 10 ----------
> > 2 files changed, 16 deletions(-)
> >
> > diff --git a/arch/csky/include/asm/processor.h b/arch/csky/include/asm/processor.h
> > index 24442d8e86f9..4800f6563abb 100644
> > --- a/arch/csky/include/asm/processor.h
> > +++ b/arch/csky/include/asm/processor.h
> > @@ -82,12 +82,6 @@ static inline void release_thread(struct task_struct *dead_task)
> >
> > extern int kernel_thread(int (*fn)(void *), void *arg, unsigned long flags);
> >
> > -#define copy_segments(tsk, mm) do { } while (0)
> > -#define release_segments(mm) do { } while (0)
> > -#define forget_segments() do { } while (0)
> > -
> > -extern unsigned long thread_saved_pc(struct task_struct *tsk);
> > -
> > unsigned long get_wchan(struct task_struct *p);
> >
> > #define KSTK_EIP(tsk) (task_pt_regs(tsk)->pc)
> > diff --git a/arch/csky/kernel/process.c b/arch/csky/kernel/process.c
> > index 8b3fad062ab2..3da63cf0bfde 100644
> > --- a/arch/csky/kernel/process.c
> > +++ b/arch/csky/kernel/process.c
> > @@ -30,16 +30,6 @@ asmlinkage void ret_from_kernel_thread(void);
> > */
> > void flush_thread(void){}
> >
> > -/*
> > - * Return saved PC from a blocked thread
> > - */
> > -unsigned long thread_saved_pc(struct task_struct *tsk)
> > -{
> > - struct switch_stack *sw = (struct switch_stack *)tsk->thread.sp;
> > -
> > - return sw->r15;
> > -}
> > -
> > int copy_thread_tls(unsigned long clone_flags,
> > unsigned long usp,
> > unsigned long kthread_arg,
> > --
> > 2.27.0
> >
>
>
> --
> Best Regards
> Guo Ren
>
> ML: https://lore.kernel.org/linux-csky/
>
next prev parent reply other threads:[~2020-06-15 8:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 15:39 [PATCH] csky: remove unusued thread_saved_pc and *_segments functions/macros Tobias Klauser
2020-06-13 8:42 ` Guo Ren
2020-06-15 8:43 ` Tobias Klauser [this message]
2020-06-17 6:54 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200615084314.rwabrkyy7wwgwdxc@distanz.ch \
--to=tklauser@distanz.ch \
--cc=guoren@kernel.org \
--cc=han_mao@c-sky.com \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).