From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C126C433E0 for ; Tue, 23 Jun 2020 08:42:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4666C20720 for ; Tue, 23 Jun 2020 08:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731722AbgFWImd (ORCPT ); Tue, 23 Jun 2020 04:42:33 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:41706 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731691AbgFWImc (ORCPT ); Tue, 23 Jun 2020 04:42:32 -0400 Received: from ip5f5af08c.dynamic.kabel-deutschland.de ([95.90.240.140] helo=wittgenstein) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jneVh-0003DY-GX; Tue, 23 Jun 2020 08:42:29 +0000 Date: Tue, 23 Jun 2020 10:42:28 +0200 From: Christian Brauner To: David Miller Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, arnd@arndb.de, guoren@kernel.org, linux-csky@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: [PATCH 02/17] sparc64: enable HAVE_COPY_THREAD_TLS Message-ID: <20200623084228.jpufvn5mn3lhjc36@wittgenstein> References: <20200622234326.906346-1-christian.brauner@ubuntu.com> <20200622234326.906346-3-christian.brauner@ubuntu.com> <20200622.203516.1857672250009821997.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200622.203516.1857672250009821997.davem@davemloft.net> Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Mon, Jun 22, 2020 at 08:35:16PM -0700, David Miller wrote: > From: Christian Brauner > Date: Tue, 23 Jun 2020 01:43:11 +0200 > > > diff --git a/arch/sparc/kernel/syscalls.S b/arch/sparc/kernel/syscalls.S > > index db42b4fb3708..192f3a28a2b7 100644 > > --- a/arch/sparc/kernel/syscalls.S > > +++ b/arch/sparc/kernel/syscalls.S > > @@ -86,19 +86,22 @@ sys32_rt_sigreturn: > > * during system calls... > > */ > > .align 32 > > -sys_vfork: /* Under Linux, vfork and fork are just special cases of clone. */ > > - sethi %hi(0x4000 | 0x0100 | SIGCHLD), %o0 > > - or %o0, %lo(0x4000 | 0x0100 | SIGCHLD), %o0 > > - ba,pt %xcc, sys_clone > > +sys_vfork: > > + flushw > > + ba,pt %xcc, sparc_vfork > > + add %sp, PTREGS_OFF, %o0 > > Please indent branch delay slot instructions with one extra space, as > was done in the code you are changing. > > > + ba,pt %xcc, sparc_fork > > + add %sp, PTREGS_OFF, %o0 > > Likewise. > > > + ba,pt %xcc, sparc_clone > > + add %sp, PTREGS_OFF, %o0 > > Likewise. Fixed, thanks for taking a look again! This somehow slipped past me when applying. Christian