From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Guo Ren <guoren@kernel.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-csky@vger.kernel.org
Subject: Re: [RFC PATCH 2/2] Revert "csky: Add support for restartable sequence"
Date: Mon, 26 Jul 2021 12:28:20 -0400 (EDT) [thread overview]
Message-ID: <2070284546.6496.1627316900287.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <CAJF2gTR9_SzAm2kPXyP+xJDVmdvM=XSm7kJn_eNq-wQmhLqTeg@mail.gmail.com>
----- On Jul 26, 2021, at 12:10 PM, Guo Ren guoren@kernel.org wrote:
> Hi Mathieu,
>
> Sorry for forgetting to CC you in the last patch, and that patch has
> been merged into master which has the problem of syscall restart.
>
> I still want to keep rseq feature for csky, and implement the
> RSEQ_SKIP_FASTPATH for self-test, it that okay?
No, the RSEQ_SKIP_FASTPATH is the one special-case of test build which
skips building rseq critical sections entirely. This leaves out any
relevant testing of rseq per-se. With what we have in the upstream
selftests, I expect this test configuration to abort at runtime because
no slow-path fallbacks are available when the fastpath is disabled.
The asm glue to test rseq user-space really needs to be implemented
for any useful testing to be done here.
Unless that asm glue is contributed, none of the rseq logic is actually
tested on that architecture.
Considering the extremely-hard-to-debug nature of races with a broken
rseq kernel implementation, proper testing coverage is paramount, so I
still recommend the revert unless the selftests user-space asm glue is
contributed for C-Sky.
Thanks,
Mathieu
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
next prev parent reply other threads:[~2021-07-26 16:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 16:15 [RFC PATCH 1/2] Revert "csky: Fixup CONFIG_DEBUG_RSEQ" Mathieu Desnoyers
2021-07-23 16:16 ` [RFC PATCH 2/2] Revert "csky: Add support for restartable sequence" Mathieu Desnoyers
2021-07-26 16:10 ` Guo Ren
2021-07-26 16:28 ` Mathieu Desnoyers [this message]
2022-09-09 20:02 ` Mathieu Desnoyers
2022-09-10 2:35 ` Guo Ren
2022-09-10 13:35 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2070284546.6496.1627316900287.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).