Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
* Re: [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks
       [not found] ` <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>
@ 2020-07-06  6:14   ` Markus Elfring
  0 siblings, 0 replies; only message in thread
From: Markus Elfring @ 2020-07-06  6:14 UTC (permalink / raw)
  To: Tiezhu Yang, Thomas Gleixner, Jason Cooper, Marc Zyngier,
	Guo Ren, linux-csky
  Cc: linux-kernel, kernel-janitors, Denis Efremov, Gustavo A. R. Silva

> … Thus add jump targets for the completion of the desired
> exception handling. By the way, do some coding-style cleanups
> suggested by Markus.

I propose to split these changes.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=dcb7fd82c75ee2d6e6f9d8cc71c52519ed52e258#n138

Would you like to support easier back-porting of a fix
besides another bit of possible source code beautification?


…
+++ b/drivers/irqchip/irq-csky-mpintc.c
@@ -241,14 +241,16 @@ csky_mpintc_init(struct device_node *node, struct device_node *parent)
…
 		INTCG_base = ioremap(mfcr("cr<31, 14>"),
-				     INTCL_SIZE*nr_cpu_ids + INTCG_SIZE);
…
+				     INTCL_SIZE * nr_cpu_ids + INTCG_SIZE);

Can any macro (or function) be helpful for such a size computation?

Regards,
Markus

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1593998365-25910-1-git-send-email-yangtiezhu@loongson.cn>
     [not found] ` <1593998365-25910-4-git-send-email-yangtiezhu@loongson.cn>
2020-07-06  6:14   ` [PATCH v5 03/14] irqchip/csky-mpintc: Fix potential resource leaks Markus Elfring

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git