From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 121DEC3F2D7 for ; Thu, 5 Mar 2020 07:34:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E89B42073D for ; Thu, 5 Mar 2020 07:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725900AbgCEHef (ORCPT ); Thu, 5 Mar 2020 02:34:35 -0500 Received: from foss.arm.com ([217.140.110.172]:44192 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725866AbgCEHef (ORCPT ); Thu, 5 Mar 2020 02:34:35 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D7F0E1FB; Wed, 4 Mar 2020 23:34:33 -0800 (PST) Received: from [10.163.1.88] (unknown [10.163.1.88]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B93CE3F534; Wed, 4 Mar 2020 23:38:16 -0800 (PST) From: Anshuman Khandual Subject: Re: [PATCH] mm/special: Create generic fallbacks for pte_special() and pte_mkspecial() To: linux-mm@kvack.org, Ralf Baechle , Paul Burton Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Russell King , Guo Ren , Brian Cain , Tony Luck , Fenghua Yu , Geert Uytterhoeven , Sam Creasey , Michal Simek , Nick Hu , Greentime Hu , Vincent Chen , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , "David S. Miller" , Jeff Dike , Richard Weinberger , Anton Ivanov , Guan Xuetao , Chris Zankel , Max Filippov , Andrew Morton , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, linux-parisc@vger.kernel.org, sparclinux@vger.kernel.org, linux-um@lists.infradead.org, linux-xtensa@linux-xtensa.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org References: <1583114190-7678-1-git-send-email-anshuman.khandual@arm.com> Message-ID: <58aecdcf-ea16-c958-0deb-97541792e081@arm.com> Date: Thu, 5 Mar 2020 13:04:19 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <1583114190-7678-1-git-send-email-anshuman.khandual@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On 03/02/2020 07:26 AM, Anshuman Khandual wrote: > diff --git a/arch/mips/include/asm/pgtable.h b/arch/mips/include/asm/pgtable.h > index aef5378f909c..8e4e4be1ca00 100644 > --- a/arch/mips/include/asm/pgtable.h > +++ b/arch/mips/include/asm/pgtable.h > @@ -269,6 +269,36 @@ static inline void set_pte_at(struct mm_struct *mm, unsigned long addr, > */ > extern pgd_t swapper_pg_dir[]; > > +/* > + * Platform specific pte_special() and pte_mkspecial() definitions > + * are required only when ARCH_HAS_PTE_SPECIAL is enabled. > + */ > +#if !defined(CONFIG_32BIT) && !defined(CONFIG_CPU_HAS_RIXI) > +#if defined(CONFIG_PHYS_ADDR_T_64BIT) && defined(CONFIG_CPU_MIPS32) > +static inline int pte_special(pte_t pte) > +{ > + return pte.pte_low & _PAGE_SPECIAL; > +} > + > +static inline pte_t pte_mkspecial(pte_t pte) > +{ > + pte.pte_low |= _PAGE_SPECIAL; > + return pte; > +} > +#else > +static inline int pte_special(pte_t pte) > +{ > + return pte_val(pte) & _PAGE_SPECIAL; > +} > + > +static inline pte_t pte_mkspecial(pte_t pte) > +{ > + pte_val(pte) |= _PAGE_SPECIAL; > + return pte; > +} > +#endif > +#endif > + Hello Ralf/Paul, This change now restricts mips definitions for pte_special() and pte_mkspecial() and makes them visible only for configs where ARCH_HAS_PTE_SPECIAL is enabled. Does this look okay ? In almost all other platforms we drop the stub definitions for pte_special() and pte_mkspecial(). - Anshuman