From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CBA5C00A89 for ; Thu, 5 Nov 2020 11:36:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8C272206FB for ; Thu, 5 Nov 2020 11:36:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ellerman.id.au header.i=@ellerman.id.au header.b="EuqJG+oW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730146AbgKEL0v (ORCPT ); Thu, 5 Nov 2020 06:26:51 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:40529 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbgKEL0v (ORCPT ); Thu, 5 Nov 2020 06:26:51 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4CRh7927Qnz9sVS; Thu, 5 Nov 2020 22:26:45 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ellerman.id.au; s=201909; t=1604575608; bh=N3LQMBxz53FTAnoaW8tqbR9RuS1nFNL/IBcDzTEmo04=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=EuqJG+oW9YMlU/9C7w+LY7w/BEHnurdsiXw5EYLeUouxUmPtg9DLXMDz6koBzkxFP /0Tdhcy4LzU97SCf0ag1B9XfPPfCzdauwZdXGomHJaB/s4VOtaFYmryYlWheiAwxAJ p8ydnxllcULes9/vYcWWndvJDvPUHHyKjqOJu4D4txoq8JMyMyAYRkm2ASAbiHYP/r GEtXi5DM2CcI3+gnulMIrGgHvItowZwos2kYpEtDoZEq4gCyyvNWlgTXF8G8V9vkaZ hRWv8Cs33o7XpzNAIdrgVm40jwWUQSU2QFGO1+x3JhRd8lyIbpOhMPgjlpYFqdu77L khu7frJN8nxJg== From: Michael Ellerman To: YiFei Zhu Cc: Linux Containers , linux-sh@vger.kernel.org, Tobin Feldman-Fitzthum , Hubertus Franke , Jack Chen , linux-riscv@lists.infradead.org, Andrea Arcangeli , linux-s390@vger.kernel.org, YiFei Zhu , linux-csky@vger.kernel.org, Tianyin Xu , linux-xtensa@linux-xtensa.org, Kees Cook , Jann Horn , Valentin Rothberg , Aleksa Sarai , Josep Torrellas , Will Drewry , linux-parisc@vger.kernel.org, kernel list , Andy Lutomirski , Dimitrios Skarlatos , David Laight , Giuseppe Scrivano , linuxppc-dev@lists.ozlabs.org, Tycho Andersen Subject: Re: [PATCH seccomp 3/8] powerpc: Enable seccomp architecture tracking In-Reply-To: References: <4ec2970fcc819eb4d5dac2bd35233ccdadfda845.1604410035.git.yifeifz2@illinois.edu> <87wnz1to9n.fsf@mpe.ellerman.id.au> Date: Thu, 05 Nov 2020 22:26:44 +1100 Message-ID: <87ft5ot56z.fsf@mpe.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org YiFei Zhu writes: > On Wed, Nov 4, 2020 at 4:22 AM Michael Ellerman wrote: >> > +#ifdef __LITTLE_ENDIAN__ >> >> As Kees mentioned this should (must?!) match the configured endian. >> >> But I think it would still be better to use the CONFIG symbol, which is >> CONFIG_CPU_LITTLE_ENDIAN. > > My attempt here is to be consistent with asm/syscall.h > syscall_get_arch [1]. Would it make sense to change that to > CONFIG_CPU_LITTLE_ENDIAN then? > > [1] https://elixir.bootlin.com/linux/latest/source/arch/powerpc/include/asm/syscall.h#L116 Looking across the tree with have thousands of usages of __LITTLE_ENDIAN__, so it's probably not worth converting to CONFIG_CPU_LITTLE_ENDIAN. >> > +# define SECCOMP_ARCH_NATIVE (AUDIT_ARCH_PPC64 | __SECCOMP_ARCH_LE) >> >> You use __SECCOMP_ARCH_LE there, but previously you only defined >> __SECCOMP_ARCH_LE_BIT. >> >> Is there some magic somewhere that defines __SECCOMP_ARCH_LE based on >> __SECCOMP_ARCH_LE_BIT ? > > Oops, my bad here. OK :) >> > +# define SECCOMP_ARCH_NATIVE_NR NR_syscalls >> > +# define SECCOMP_ARCH_NATIVE_NAME "ppc64" >> >> What's the name used for? > > This is used in the last patch in this series to report in procfs the > name of each architecture tracked by the bitmap cache. OK, yeah I think it would be better if the matched the uname -m values. >> Usually we use "ppc64" for 64-bit big endian and "ppc64le" for 64-bit >> little endian. >> >> And usually we use "ppc" for 32-bit. > > Ok. cheers