Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
From: Thomas De Schampheleire <patrickdepinguin@gmail.com>
To: Mao Han <han_mao@c-sky.com>
Cc: buildroot <buildroot@buildroot.org>,
	Qu Xianmiao <xianmiao_qu@c-sky.com>, Guo Ren <ren_guo@c-sky.com>,
	Mark Corbin <mark.corbin@embecosm.com>,
	linux-csky@vger.kernel.org,
	Chen Hongdeng <hongdeng_chen@c-sky.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist
Date: Fri, 10 Jan 2020 11:57:00 +0100
Message-ID: <CAAXf6LUVA4QkSmz8OaSOyqzKaw--eD5r0zAD+zONfyGROv1MZw@mail.gmail.com> (raw)
In-Reply-To: <1577937441-18703-1-git-send-email-han_mao@c-sky.com>

Hello,

El jue., 2 ene. 2020 a las 5:15, Mao Han (<han_mao@c-sky.com>) escribió:
>
> Different architecture may have different arch library folder structure
> for their multilib toolchain. RISC-V toolchain has folder structure
> like:
> /sysroot/lib64/
> /sysroot/lib64/lp64
> /sysroot/lib64/lp64d
> The first level is for ISA and the second level is for ABI.
> Current buildroot only creat lib and lib64, some error is reported
> while installing the external toolchain:
> >>> toolchain-external-custom  Installing to staging directory
> /usr/bin/install -D -m 0755 /.../build/toolchain-external-custom/toolchain-wrapper /.../host/bin/toolchain-wrapper
> ln: failed to create symbolic link '/.../host/riscv64-buildroot-linux-gnu/sysroot/lib64/lp64': No such file or directory
> ln: failed to create symbolic link '/.../host/riscv64-buildroot-linux-gnu/sysroot/usr/lib64/lp64': No such file or directory
>
> Signed-off-by: Qu Xianmiao <xianmiao_qu@c-sky.com>
> Signed-off-by: Chen Hongdeng <hongdeng_chen@c-sky.com>
> Signed-off-by: Guo Ren<ren_guo@c-sky.com>
> Signed-off-by: Mao Han <han_mao@c-sky.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Mark Corbin <mark.corbin@embecosm.com>
> ---
>  toolchain/toolchain-external/pkg-toolchain-external.mk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/toolchain/toolchain-external/pkg-toolchain-external.mk b/toolchain/toolchain-external/pkg-toolchain-external.mk
> index baf719a..13b2468 100644
> --- a/toolchain/toolchain-external/pkg-toolchain-external.mk
> +++ b/toolchain/toolchain-external/pkg-toolchain-external.mk
> @@ -454,6 +454,8 @@ create_lib_symlinks = \
>         ARCH_LIB_DIR="$(call toolchain_find_libdir,$(TOOLCHAIN_EXTERNAL_CC) $(TOOLCHAIN_EXTERNAL_CFLAGS))" ; \
>         if [ ! -e "$${DESTDIR}/$${ARCH_LIB_DIR}" -a ! -e "$${DESTDIR}/usr/$${ARCH_LIB_DIR}" ]; then \
>                 relpath="$(call relpath_prefix,$${ARCH_LIB_DIR})" ; \
> +               mkdir -p "$${DESTDIR}/$${ARCH_LIB_DIR}" ; \
> +               mkdir -p "$${DESTDIR}/usr/$${ARCH_LIB_DIR}" ; \
>                 ln -snf $${relpath}lib "$${DESTDIR}/$${ARCH_LIB_DIR}" ; \
>                 ln -snf $${relpath}lib "$${DESTDIR}/usr/$${ARCH_LIB_DIR}" ; \

This is not correct.

The purpose of this code is to create a symbolic link named according
to 'ARCH_LIB_DIR' inside DESTDIR and DESTDIR/usr.
It is not the purpose to create a symbolic link called 'lib' inside a
directory DESTDIR/ARCH_LIB_DIR.
The change you made is creating a _directory_ ARCH_LIB_DIR while it
should be a _symbolic link_.

Could you please clarify what is the value of ARCH_LIB_DIR in your case?

And could you clarify which part of the path is missing?
'/.../host/riscv64-buildroot-linux-gnu/sysroot/lib64/lp64' ?
I assume that the 'lib64' part is missing?

Finally, please provide a defconfig that allows to reproduce and test
this problem.

Thanks,
Thomas

  parent reply index

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  3:57 Mao Han
2020-01-02  3:57 ` [PATCH 2/2] toolchain: Get ld.so name if available Mao Han
2020-01-26 15:31   ` [Buildroot] " Yann E. MORIN
2020-01-10 10:57 ` Thomas De Schampheleire [this message]
2020-01-10 11:15   ` [Buildroot] [PATCH 1/2] package/toolchain-external: ensure ARCH_LIB_DIR exist Thomas Petazzoni
2020-01-13  3:34   ` Mao Han
2020-01-16  9:36     ` Thomas De Schampheleire
2020-01-17  2:35       ` Mao Han
2020-01-24 15:00         ` Thomas De Schampheleire
2020-01-26 15:34           ` Yann E. MORIN

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAXf6LUVA4QkSmz8OaSOyqzKaw--eD5r0zAD+zONfyGROv1MZw@mail.gmail.com \
    --to=patrickdepinguin@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=han_mao@c-sky.com \
    --cc=hongdeng_chen@c-sky.com \
    --cc=linux-csky@vger.kernel.org \
    --cc=mark.corbin@embecosm.com \
    --cc=ren_guo@c-sky.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=xianmiao_qu@c-sky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git