From: Guo Ren <guoren@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Arnd Bergmann <arnd@arndb.de>,
balbi@kernel.org, bhelgaas@google.com, dave@stgolabs.net,
David Miller <davem@davemloft.net>,
gregkh@linuxfoundation.org, joel@joelfernandes.org,
kurt.schwemmer@microsemi.com, kvalo@codeaurora.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@vger.kernel.org, linux-usb@vger.kernel.org,
linux-wireless@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
logang@deltatee.com, mingo@kernel.org,
Michael Ellerman <mpe@ellerman.id.au>,
netdev@vger.kernel.org, oleg@redhat.com, paulmck@kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Randy Dunlap <rdunlap@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
torvalds@linux-foundation.org, Will Deacon <will@kernel.org>,
linux-csky@vger.kernel.org, kbuild test robot <lkp@intel.com>
Subject: Re: [PATCH 2/5] csky: Remove mm.h from asm/uaccess.h
Date: Sat, 21 Mar 2020 19:24:34 +0800 [thread overview]
Message-ID: <CAJF2gTQDvmSdJB3R0By0Q6d9ganVBV1FBm3urL8Jf1fyiEi+1A@mail.gmail.com> (raw)
In-Reply-To: <20200320094856.3453859-3-bigeasy@linutronix.de>
Tested and Acked by me.
Queued for next pull request, thx
On Fri, Mar 20, 2020 at 5:49 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> The defconfig compiles without linux/mm.h. With mm.h included the
> include chain leands to:
> | CC kernel/locking/percpu-rwsem.o
> | In file included from include/linux/huge_mm.h:8,
> | from include/linux/mm.h:567,
> | from arch/csky/include/asm/uaccess.h:,
> | from include/linux/uaccess.h:11,
> | from include/linux/sched/task.h:11,
> | from include/linux/sched/signal.h:9,
> | from include/linux/rcuwait.h:6,
> | from include/linux/percpu-rwsem.h:8,
> | from kernel/locking/percpu-rwsem.c:6:
> | include/linux/fs.h:1422:29: error: array type has incomplete element type 'struct percpu_rw_semaphore'
> | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
>
> once rcuwait.h includes linux/sched/signal.h.
>
> Remove the linux/mm.h include.
>
> Cc: Guo Ren <guoren@kernel.org>
> Cc: linux-csky@vger.kernel.org
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
> arch/csky/include/asm/uaccess.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h
> index eaa1c3403a424..abefa125b93cf 100644
> --- a/arch/csky/include/asm/uaccess.h
> +++ b/arch/csky/include/asm/uaccess.h
> @@ -11,7 +11,6 @@
> #include <linux/errno.h>
> #include <linux/types.h>
> #include <linux/sched.h>
> -#include <linux/mm.h>
> #include <linux/string.h>
> #include <linux/version.h>
> #include <asm/segment.h>
> --
> 2.26.0.rc2
>
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
next prev parent reply other threads:[~2020-03-21 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200318204408.010461877@linutronix.de>
[not found] ` <20200320094856.3453859-1-bigeasy@linutronix.de>
2020-03-20 9:48 ` [PATCH 2/5] csky: Remove mm.h from asm/uaccess.h Sebastian Andrzej Siewior
2020-03-21 11:24 ` Guo Ren [this message]
2020-03-21 12:08 ` Thomas Gleixner
2020-03-21 14:11 ` Guo Ren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJF2gTQDvmSdJB3R0By0Q6d9ganVBV1FBm3urL8Jf1fyiEi+1A@mail.gmail.com \
--to=guoren@kernel.org \
--cc=arnd@arndb.de \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=bigeasy@linutronix.de \
--cc=dave@stgolabs.net \
--cc=davem@davemloft.net \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kurt.schwemmer@microsemi.com \
--cc=kvalo@codeaurora.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkp@intel.com \
--cc=logang@deltatee.com \
--cc=mingo@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).