From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F216C3A589 for ; Tue, 20 Aug 2019 08:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 02FD8235EE for ; Tue, 20 Aug 2019 08:26:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566289607; bh=hdmanysHDb8PuQuXvQtksI870aVXPSFmN+iWwoWkq+c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=FcjSNShgiB/FREQMIvgzalLS06zyEWg7YAi1xkJKlnb0HhvBHNJbVdRny2+lM/GNY 6hvgKfYfPKTHs4cLBF0/MImi8wOwdH6ntghmuMXrDuVkMR7k1iu3JvCCcZ4Yw16kRe ZpW9tYG+plhcNa0Bc8M3v/9eno0qexeo7VAfYe/w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729378AbfHTI0n (ORCPT ); Tue, 20 Aug 2019 04:26:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:50390 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726049AbfHTI0n (ORCPT ); Tue, 20 Aug 2019 04:26:43 -0400 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6387823A84; Tue, 20 Aug 2019 08:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1566289602; bh=hdmanysHDb8PuQuXvQtksI870aVXPSFmN+iWwoWkq+c=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DbMWsHnjPgOtGnoxKP4XdMnWoq3Z5bxRHRAVGMbkRxd6lVkhU92hGvtxZ0uMgaeUY HWW2nArujbR6SYFcu2y9nEzMTIup5daZJcu6WMQhkoqlJRG76XmtqJ2V1r8c1oVrBM qlT6hGr/0tYzbqAq1PmlGUXOaZW6AOXh1NyB0oxk= Received: by mail-wr1-f46.google.com with SMTP id s18so11439933wrn.1; Tue, 20 Aug 2019 01:26:42 -0700 (PDT) X-Gm-Message-State: APjAAAWcmPVqAyDXWL+k/s+lP6Ey9XfY7cY7zzvR4DdYG5uYSfmqSPoN KpRtW8LGjT5lUSibxajLORrFjzuTPem5X9I1jYc= X-Google-Smtp-Source: APXvYqxJDOU2yCLgISh7MDluIUhar/3J/7PrIJCYuvKYjNhX/ZO57FI5BdiPFThETR6zIPsJ1GragQc3ypBJbA0H0S8= X-Received: by 2002:adf:f3d1:: with SMTP id g17mr32042773wrp.38.1566289599845; Tue, 20 Aug 2019 01:26:39 -0700 (PDT) MIME-Version: 1.0 References: <1565868537-17753-1-git-send-email-guoren@kernel.org> <20190816070348.GA13766@infradead.org> <20190818182118.GA30141@infradead.org> In-Reply-To: <20190818182118.GA30141@infradead.org> From: Guo Ren Date: Tue, 20 Aug 2019 16:26:28 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] csky: Fixup ioremap function losing To: Christoph Hellwig Cc: Arnd Bergmann , Linux Kernel Mailing List , linux-arch , linux-csky@vger.kernel.org, zhang_jian5@dahuatech.com, Guo Ren Content-Type: text/plain; charset="UTF-8" Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Mon, Aug 19, 2019 at 2:21 AM Christoph Hellwig wrote: > > On Sun, Aug 18, 2019 at 10:20:18AM +0800, Guo Ren wrote: > > > > Also change flag VM_ALLOC to VM_IOREMAP in get_vm_area_caller. > > > > > > Looks generally fine, but two comments: > > > > > > - do you have a need for ioremap_cache? We are generally try to > > > phase it out in favour of memremap, and it is generally only used > > > by arch specific code. > > Yes, some drivers of our customers use ioremap_cache to map phy_addr > > which isn't belong to system memory. > > Which driver? We should move it over to memremap instead of adding > a new ioremap_cache. The driver hasn't been upstreamed. OK, just remove ioremap_cache and seems it's not a big problem. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/