Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
From: Guo Ren <guoren@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Joerg Roedel <joro@8bytes.org>,
	linux-csky@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Joerg Roedel <jroedel@suse.de>
Subject: Re: [PATCH] csky: Fix build with upstream gcc
Date: Wed, 22 Jul 2020 00:05:41 +0800
Message-ID: <CAJF2gTR34maSk_Up2CUKyxaHJ=wKLUx+LfhKsv6=Ci25dWbqJg@mail.gmail.com> (raw)
In-Reply-To: <20200721132155.GA27649@roeck-us.net>

Thx Joerg & Guenter,

Cool work!

Acked-by: Guo Ren <guoren@kernel.org>

Approve to next branch.

On Tue, Jul 21, 2020 at 9:21 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Tue, Jul 21, 2020 at 01:23:14PM +0200, Joerg Roedel wrote:
> > From: Joerg Roedel <jroedel@suse.de>
> >
> > Building a kernel for the CSKY architecture with CONFIG_FRAME_POINTER
> > set requires a gcc supporting the non-upstream '-mbacktrace' option.
> > Check for the '-mbacktrace' option before enabling CONFIG_FRAMEPOINTER
> > and fix building CSKY with an upstream gcc compiler.
> >
> > Signed-off-by: Joerg Roedel <jroedel@suse.de>
>
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
>
> > ---
> >  arch/csky/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> > index bd31ab12f77d..1622e1c56026 100644
> > --- a/arch/csky/Kconfig
> > +++ b/arch/csky/Kconfig
> > @@ -8,7 +8,7 @@ config CSKY
> >       select ARCH_HAS_SYNC_DMA_FOR_DEVICE
> >       select ARCH_USE_BUILTIN_BSWAP
> >       select ARCH_USE_QUEUED_RWLOCKS if NR_CPUS>2
> > -     select ARCH_WANT_FRAME_POINTERS if !CPU_CK610
> > +     select ARCH_WANT_FRAME_POINTERS if (!CPU_CK610 && STACKTRACE_SUPPORT)
> >       select COMMON_CLK
> >       select CLKSRC_MMIO
> >       select CSKY_MPINTC if CPU_CK860
> > @@ -125,7 +125,7 @@ config MMU
> >       def_bool y
> >
> >  config STACKTRACE_SUPPORT
> > -     def_bool y
> > +     def_bool $(success,echo 'int foo(void) { return 0; }' | $(CC) -mbacktrace -x c - -c -o /dev/null)
> >
> >  config TIME_LOW_RES
> >       def_bool y
> > --
> > 2.27.0
> >



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/

  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 13:21 Guenter Roeck
2020-07-21 16:05 ` Guo Ren [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-07-21 11:23 Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJF2gTR34maSk_Up2CUKyxaHJ=wKLUx+LfhKsv6=Ci25dWbqJg@mail.gmail.com' \
    --to=guoren@kernel.org \
    --cc=joro@8bytes.org \
    --cc=jroedel@suse.de \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git