Linux-csky Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] csky: Fix the compile error when enable ck860
@ 2020-01-21 10:50 MaJun
  2020-01-21 15:05 ` Guo Ren
  0 siblings, 1 reply; 2+ messages in thread
From: MaJun @ 2020-01-21 10:50 UTC (permalink / raw)
  To: guoren; +Cc: mj145409, linux-kernel, linux-arch, arnd, linux-csky, MaJun

There is a compile error when ck860 processor is choosed.
To fix this compile error, the FPU config should be disabled.

Signed-off-by: MaJun <majun258@linux.alibaba.com>
---
 arch/csky/Kconfig           | 2 +-
 arch/csky/configs/defconfig | 7 -------
 2 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
index 3973847..f6ad4c6 100644
--- a/arch/csky/Kconfig
+++ b/arch/csky/Kconfig
@@ -154,7 +154,7 @@ config CPU_CK860
 	select CPU_HAS_TLBI
 	select CPU_HAS_CACHEV2
 	select CPU_HAS_LDSTEX
-	select CPU_HAS_FPUV2
+	select CPU_HAS_FPUV2 if CPU_HAS_FPU
 endchoice
 
 choice
diff --git a/arch/csky/configs/defconfig b/arch/csky/configs/defconfig
index 7ef4289..ad9591c 100644
--- a/arch/csky/configs/defconfig
+++ b/arch/csky/configs/defconfig
@@ -10,9 +10,6 @@ CONFIG_BSD_PROCESS_ACCT=y
 CONFIG_BSD_PROCESS_ACCT_V3=y
 CONFIG_MODULES=y
 CONFIG_MODULE_UNLOAD=y
-CONFIG_DEFAULT_DEADLINE=y
-CONFIG_CPU_CK807=y
-CONFIG_CPU_HAS_FPU=y
 CONFIG_NET=y
 CONFIG_PACKET=y
 CONFIG_UNIX=y
@@ -27,10 +24,7 @@ CONFIG_SERIAL_NONSTANDARD=y
 CONFIG_SERIAL_8250=y
 CONFIG_SERIAL_8250_CONSOLE=y
 CONFIG_SERIAL_OF_PLATFORM=y
-CONFIG_TTY_PRINTK=y
 # CONFIG_VGA_CONSOLE is not set
-CONFIG_CSKY_MPTIMER=y
-CONFIG_GX6605S_TIMER=y
 CONFIG_PM_DEVFREQ=y
 CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
 CONFIG_DEVFREQ_GOV_PERFORMANCE=y
@@ -56,6 +50,5 @@ CONFIG_CRAMFS=y
 CONFIG_ROMFS_FS=y
 CONFIG_NFS_FS=y
 CONFIG_PRINTK_TIME=y
-CONFIG_DEBUG_INFO=y
 CONFIG_DEBUG_FS=y
 CONFIG_MAGIC_SYSRQ=y
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] csky: Fix the compile error when enable ck860
  2020-01-21 10:50 [PATCH] csky: Fix the compile error when enable ck860 MaJun
@ 2020-01-21 15:05 ` Guo Ren
  0 siblings, 0 replies; 2+ messages in thread
From: Guo Ren @ 2020-01-21 15:05 UTC (permalink / raw)
  To: MaJun
  Cc: mj145409, Linux Kernel Mailing List, linux-arch, Arnd Bergmann,
	linux-csky

Hi MaJun,

On Tue, Jan 21, 2020 at 8:25 PM MaJun <majun258@linux.alibaba.com> wrote:
>
> There is a compile error when ck860 processor is choosed.
> To fix this compile error, the FPU config should be disabled.
>
> Signed-off-by: MaJun <majun258@linux.alibaba.com>
> ---
>  arch/csky/Kconfig           | 2 +-
>  arch/csky/configs/defconfig | 7 -------
Kconfig and defconfig should be separate patches.

>  2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/arch/csky/Kconfig b/arch/csky/Kconfig
> index 3973847..f6ad4c6 100644
> --- a/arch/csky/Kconfig
> +++ b/arch/csky/Kconfig
> @@ -154,7 +154,7 @@ config CPU_CK860
>         select CPU_HAS_TLBI
>         select CPU_HAS_CACHEV2
>         select CPU_HAS_LDSTEX
> -       select CPU_HAS_FPUV2
> +       select CPU_HAS_FPUV2 if CPU_HAS_FPU
Not right.

config CPU_HAS_FPUV2
         depends on CPU_HAS_FPU
         bool
How ?

>  endchoice
>
>  choice
> diff --git a/arch/csky/configs/defconfig b/arch/csky/configs/defconfig
> index 7ef4289..ad9591c 100644
> --- a/arch/csky/configs/defconfig
> +++ b/arch/csky/configs/defconfig
> @@ -10,9 +10,6 @@ CONFIG_BSD_PROCESS_ACCT=y
>  CONFIG_BSD_PROCESS_ACCT_V3=y
>  CONFIG_MODULES=y
>  CONFIG_MODULE_UNLOAD=y
> -CONFIG_DEFAULT_DEADLINE=y
> -CONFIG_CPU_CK807=y
> -CONFIG_CPU_HAS_FPU=y
>  CONFIG_NET=y
>  CONFIG_PACKET=y
>  CONFIG_UNIX=y
> @@ -27,10 +24,7 @@ CONFIG_SERIAL_NONSTANDARD=y
>  CONFIG_SERIAL_8250=y
>  CONFIG_SERIAL_8250_CONSOLE=y
>  CONFIG_SERIAL_OF_PLATFORM=y
> -CONFIG_TTY_PRINTK=y
>  # CONFIG_VGA_CONSOLE is not set
> -CONFIG_CSKY_MPTIMER=y
> -CONFIG_GX6605S_TIMER=y
>  CONFIG_PM_DEVFREQ=y
>  CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=y
>  CONFIG_DEVFREQ_GOV_PERFORMANCE=y
> @@ -56,6 +50,5 @@ CONFIG_CRAMFS=y
>  CONFIG_ROMFS_FS=y
>  CONFIG_NFS_FS=y
>  CONFIG_PRINTK_TIME=y
> -CONFIG_DEBUG_INFO=y
>  CONFIG_DEBUG_FS=y
>  CONFIG_MAGIC_SYSRQ=y
> --
> 1.8.3.1
>
Agree about defconfig

-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-21 10:50 [PATCH] csky: Fix the compile error when enable ck860 MaJun
2020-01-21 15:05 ` Guo Ren

Linux-csky Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-csky/0 linux-csky/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-csky linux-csky/ https://lore.kernel.org/linux-csky \
		linux-csky@vger.kernel.org
	public-inbox-index linux-csky

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-csky


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git