From: Guo Ren <guoren@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Zhenzhong Duan <zhenzhong.duan@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-csky@vger.kernel.org, Oleg Nesterov <oleg@redhat.com>
Subject: Re: [PATCH] csky: Fix a size determination in gpr_get()
Date: Wed, 23 Sep 2020 08:03:20 +0800 [thread overview]
Message-ID: <CAJF2gTSMWc_=j1NKCTXqhLj7cmSB_A3dYB7nL4F7H3jqT+u38A@mail.gmail.com> (raw)
In-Reply-To: <20200922162901.GA3421308@ZenIV.linux.org.uk>
Thx Duan,
Acked-by: Guo Ren <guoren@kernel.org>
Hi AI,
I found the broken commit still has a question:
> commit dcad7854fcce6a2d49b6a3ead5bbefeff047e559
> Author: Al Viro <viro@zeniv.linux.org.uk>
> Date: Tue Jun 16 15:28:29 2020 -0400
> csky: switch to ->regset_get()
> NB: WTF "- what the fuck :(" is fpregs_get() playing at???
The fpregs_get() is for REGSET_FPR regset used by ptrace (gdb) and all
fp regs are stored in threads' context.
So, WTF question for?
Best Regards
Guo Ren
On Wed, Sep 23, 2020 at 12:29 AM Al Viro <viro@zeniv.linux.org.uk> wrote:
>
> On Tue, Sep 22, 2020 at 05:15:05PM +0800, Zhenzhong Duan wrote:
> > "*" is missed in size determination as we are passing register set
> > rather than a pointer.
>
> Ack. I can push it to Linus today, unless you want it to go through
> csky tree. Preferences?
>
> > Fixes: dcad7854fcce ("sky: switch to ->regset_get()")
> > Signed-off-by: Zhenzhong Duan <zhenzhong.duan@gmail.com>
> > ---
> > arch/csky/kernel/ptrace.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/csky/kernel/ptrace.c b/arch/csky/kernel/ptrace.c
> > index d822144906ac..a4cf2e2ac15a 100644
> > --- a/arch/csky/kernel/ptrace.c
> > +++ b/arch/csky/kernel/ptrace.c
> > @@ -83,7 +83,7 @@ static int gpr_get(struct task_struct *target,
> > /* Abiv1 regs->tls is fake and we need sync here. */
> > regs->tls = task_thread_info(target)->tp_value;
> >
> > - return membuf_write(&to, regs, sizeof(regs));
> > + return membuf_write(&to, regs, sizeof(*regs));
> > }
> >
> > static int gpr_set(struct task_struct *target,
> > --
> > 2.25.1
> >
--
Best Regards
Guo Ren
ML: https://lore.kernel.org/linux-csky/
next prev parent reply other threads:[~2020-09-23 0:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-22 9:15 [PATCH] csky: Fix a size determination in gpr_get() Zhenzhong Duan
2020-09-22 16:29 ` Al Viro
2020-09-23 0:03 ` Guo Ren [this message]
2020-09-23 0:23 ` Al Viro
2020-09-23 2:37 ` Guo Ren
2020-09-23 4:52 ` Al Viro
2020-09-25 6:33 ` Guo Ren
2020-12-23 2:31 ` Zhenzhong Duan
2020-12-23 14:57 ` Guo Ren
2020-12-24 2:21 ` Zhenzhong Duan
2020-09-23 2:23 ` Zhenzhong Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJF2gTSMWc_=j1NKCTXqhLj7cmSB_A3dYB7nL4F7H3jqT+u38A@mail.gmail.com' \
--to=guoren@kernel.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zhenzhong.duan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).