From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F527C433DB for ; Sun, 28 Mar 2021 01:51:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 252CA619A1 for ; Sun, 28 Mar 2021 01:51:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230318AbhC1BvT (ORCPT ); Sat, 27 Mar 2021 21:51:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:53830 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbhC1BvD (ORCPT ); Sat, 27 Mar 2021 21:51:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 69E726199F; Sun, 28 Mar 2021 01:51:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616896262; bh=BUNgSqvKCD1KhF3NeU2ADrUH6ViHHRa1+b6YkOC3oZE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mXgn7fkgHaKx1wyAyVt+m5lJNJR0MzrE5OrAMbPfJPMq5Pg60W+BTvSMElW0NSsuT KUK5vc0PysUqrztNBlXk6YoPv2cxfSDSDF5Ufxb6AVbMaWxS17bHEvmkWBoHyK1kac gS2SHu2OPT8GqCphEMfoQ7tJOmDkwoXtyK69fIphdEPGJUbJs6dVRo/7S3vdRta+8A xh0qvvCfqrw/lkax7EDQVn9h8cfDK5xudZJNNpjdPAkleyXyFbkvo9W2zeAMEWVJI8 6LsAs+m19cTaes6i1gyj8TAPGFYeO9YA3y/xrFdG11F9Vn0cakibZaJAN79m+0UPQB obgkouu9nS3Kg== Received: by mail-lj1-f169.google.com with SMTP id 184so11821979ljf.9; Sat, 27 Mar 2021 18:51:02 -0700 (PDT) X-Gm-Message-State: AOAM532uYaG+Abh2Aj5/tC51vyEKY8CfS5JY/IAGDQFsPvzKM75CQKca Tm0Y5VUdKLCG0wCn7TR++77/tdRZeb6RCZ1Ijyk= X-Google-Smtp-Source: ABdhPJwOo1LYn6W8dv8w9E8xhDuwCGJKtTINJ/V9CDbT+ATTN6EFhh/n5CyatHU/ICm8j1lw1imnRI+VEW+DCIiuk8o= X-Received: by 2002:a2e:2c0d:: with SMTP id s13mr13299541ljs.105.1616896260724; Sat, 27 Mar 2021 18:51:00 -0700 (PDT) MIME-Version: 1.0 References: <1616868399-82848-1-git-send-email-guoren@kernel.org> <1616868399-82848-3-git-send-email-guoren@kernel.org> In-Reply-To: From: Guo Ren Date: Sun, 28 Mar 2021 09:50:49 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 2/4] riscv: cmpxchg.h: Merge macros To: Arnd Bergmann Cc: linux-riscv , Linux Kernel Mailing List , linux-csky@vger.kernel.org, linux-arch , Guo Ren , Peter Zijlstra , Michael Clark , Anup Patel , Palmer Dabbelt Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Thx Arnd, On Sun, Mar 28, 2021 at 5:25 AM Arnd Bergmann wrote: > > On Sat, Mar 27, 2021 at 7:06 PM wrote: > > > > From: Guo Ren > > > > To reduce assembly codes, let's merge duplicate codes into one > > (xchg_acquire, xchg_release, cmpxchg_release). > > > > Signed-off-by: Guo Ren > > This is a nice cleanup, but I wonder if you can go even further by using > the definitions from atomic-arch-fallback.h like arm64 and x86 do. Ok, I'll separate it from the qspinlock patchset and try atomic-arch-fallback.h. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/