From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FAC4C433E1 for ; Wed, 24 Jun 2020 09:15:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2016720738 for ; Wed, 24 Jun 2020 09:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592990140; bh=14K+VhMvuge//+mHFVRO68jMad3Xx5brMH+O3+ggBOk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=EaTcJLrPtLyuNGGEbx7iOY5qeq2oMGv4oP5s/LVsVVkvqFO/nNxnKySwVm631trdf donqmZqzpxcmrvUOmFDaiAoO0QJsiDn4Ae2TvEDrEcU5iduA2smtDwuoAX/33SsEKG e3dPJ2D+zaWo2B46FEszKQ921dXoeMGc/1Tg0vWM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389211AbgFXJPf (ORCPT ); Wed, 24 Jun 2020 05:15:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:33682 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387970AbgFXJPe (ORCPT ); Wed, 24 Jun 2020 05:15:34 -0400 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1CF882082F; Wed, 24 Jun 2020 09:15:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592990133; bh=14K+VhMvuge//+mHFVRO68jMad3Xx5brMH+O3+ggBOk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=IFQxL2bunzkopmfTsIvl2UbpyJSVNCbVz1tMkicOQpIhZE+i7/lWCftYg10E3XPAI LleqWHI0jaKN4UcquF75OjUnAAl7OdeSI1CZUwvRqOC11GAXNdmVhHLdaOFnoVbq1E XfG8K/JctUacbaPa4zvCuXENEZxWe4yQDQX+rA74= Received: by mail-lj1-f182.google.com with SMTP id 9so1752239ljc.8; Wed, 24 Jun 2020 02:15:33 -0700 (PDT) X-Gm-Message-State: AOAM533UbckesswlTmbt/oQeNGmzfV1ZPmHY9ngNSAuY/zZug+mGZ68u ONx4rT1rT0ygL8cH+U/nlA58qlLJp/ozW7Bl0iQ= X-Google-Smtp-Source: ABdhPJxbxsux7XuzN8uOjxja4hquHGy/NKFHEFBm47OMUifwg0Hc5X+Fhkw49rQCA/MTWVvIK0zPn0Jq/i3BDFjZoEY= X-Received: by 2002:a2e:954c:: with SMTP id t12mr13005177ljh.287.1592990131408; Wed, 24 Jun 2020 02:15:31 -0700 (PDT) MIME-Version: 1.0 References: <1592902276-3969-1-git-send-email-yangtiezhu@loongson.cn> <1592902276-3969-2-git-send-email-yangtiezhu@loongson.cn> In-Reply-To: <1592902276-3969-2-git-send-email-yangtiezhu@loongson.cn> From: Krzysztof Kozlowski Date: Wed, 24 Jun 2020 11:15:20 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/7] irqchip: Fix potential resource leaks To: Tiezhu Yang Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Rob Herring , Guo Ren , Baruch Siach , Huacai Chen , Jiaxun Yang , Tony Lindgren , Paul Walmsley , Palmer Dabbelt , Albert Ou , Kukjin Kim , Michal Simek , "linux-kernel@vger.kernel.org" , devicetree@vger.kernel.org, linux-csky@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org, "linux-samsung-soc@vger.kernel.org" , Xuefeng Li Content-Type: text/plain; charset="UTF-8" Sender: linux-csky-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Tue, 23 Jun 2020 at 10:51, Tiezhu Yang wrote: > > There exists some potential resource leaks in the error path, fix them. This should be split per driver and per bug (although mostly in driver it's just one bug). Otherwise it is difficult to review, backport and revert. Best regards, Krzysztof > Signed-off-by: Tiezhu Yang > --- > drivers/irqchip/irq-ath79-misc.c | 3 +++ > drivers/irqchip/irq-csky-apb-intc.c | 3 +++ > drivers/irqchip/irq-csky-mpintc.c | 26 ++++++++++++++++++++------ > drivers/irqchip/irq-davinci-aintc.c | 17 +++++++++++++---- > drivers/irqchip/irq-davinci-cp-intc.c | 17 ++++++++++++++--- > drivers/irqchip/irq-digicolor.c | 4 ++++ > drivers/irqchip/irq-dw-apb-ictl.c | 11 ++++++++--- > drivers/irqchip/irq-loongson-htvec.c | 5 ++++- > drivers/irqchip/irq-ls1x.c | 4 +++- > drivers/irqchip/irq-mscc-ocelot.c | 6 ++++-- > drivers/irqchip/irq-nvic.c | 2 ++ > drivers/irqchip/irq-omap-intc.c | 4 +++- > drivers/irqchip/irq-riscv-intc.c | 1 + > drivers/irqchip/irq-s3c24xx.c | 20 +++++++++++++++----- > drivers/irqchip/irq-xilinx-intc.c | 1 + > 15 files changed, 98 insertions(+), 26 deletions(-)