From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BD72C433E6 for ; Tue, 22 Dec 2020 18:56:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C850922AAE for ; Tue, 22 Dec 2020 18:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726667AbgLVSzk (ORCPT ); Tue, 22 Dec 2020 13:55:40 -0500 Received: from mail-oi1-f169.google.com ([209.85.167.169]:42686 "EHLO mail-oi1-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726161AbgLVSzk (ORCPT ); Tue, 22 Dec 2020 13:55:40 -0500 Received: by mail-oi1-f169.google.com with SMTP id l200so15746325oig.9; Tue, 22 Dec 2020 10:55:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=la43jOzGT8cpDZH0lHbZ8yczIDIlNNAQ1oOndJF72r4=; b=AtCcSb0o7lY006L2GZrR5UPwPilzq/kC67NLyMjTZtASTReROhfjHPSy0RutWkOlKG RqbP27tGmReskQxNo0K1qfHhQcg6BAW8uhUbqOHdmm5hEmtBJFuenLd5NptgWQUOCKDz kjBCjoZCLZnH3k1wGg9YY432uIFwhpY+r6MsQXLuVC5Lukiq3687e0tzgaR02AiCPgSA hUQ6TnjAbNzY2zv/Q8ZK4fhOAFRbv50TPGQ5gIf6Z0+69bzjLuL3yZL4SdU0w7FOj1Nr 53m1eQRxRsaWSphjOgaFwTgtkYz5JW6aTdzGIVgfIfPX0m1eiIDBLzh63umJaoDlvgAe kNQA== X-Gm-Message-State: AOAM533zU2Uk2Mcr8ixJ0xDbGVLBXHLupoRPMNp6erY+S1JCHptXTjXn D0tMUPgu9lUdRtq9T2gSPgh66ssty+unEomxCjk= X-Google-Smtp-Source: ABdhPJy5EVY7T6HE7RxxJ9AoKr5usE9gCbUG5HZ1gWiHgPXdK9RZjFwARYSd7qSwoUdfSw0ANGyqV1mRCh80XLruDv8= X-Received: by 2002:aca:3cc5:: with SMTP id j188mr14009921oia.54.1608663299046; Tue, 22 Dec 2020 10:54:59 -0800 (PST) MIME-Version: 1.0 References: <20201222184510.19415-1-info@metux.net> In-Reply-To: <20201222184510.19415-1-info@metux.net> From: Geert Uytterhoeven Date: Tue, 22 Dec 2020 19:54:48 +0100 Message-ID: Subject: Re: [PATCH] arch: consolidate pm_power_off callback To: "Enrico Weigelt, metux IT consult" Cc: Linux Kernel Mailing List , Catalin Marinas , Will Deacon , Mark Salter , Aurelien Jacquiot , Yoshinori Sato , Thomas Bogendoerfer , Ley Foon Tan , Jonas Bonn , Stefan Kristiansson , Stafford Horne , James Bottomley , Helge Deller , Benjamin Herrenschmidt , Paul Mackerras , Rich Felker , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "the arch/x86 maintainers" , "H. Peter Anvin" , Stefano Stabellini , Chris Zankel , Max Filippov , Christian Brauner , alpha , arcml , linux-c6x-dev@linux-c6x.org, linux-csky@vger.kernel.org, "open list:QUALCOMM HEXAGON..." , "linux-ia64@vger.kernel.org" , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Openrisc , Parisc List , linuxppc-dev , linux-riscv , linux-s390 , Linux-sh list , "open list:TENSILICA XTENSA PORT (xtensa)" , Linux PM list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org Hi Enrico, On Tue, Dec 22, 2020 at 7:46 PM Enrico Weigelt, metux IT consult wrote: > Move the pm_power_off callback into one global place and also add an > function for conditionally calling it (when not NULL), in order to remove > code duplication in all individual archs. > > Signed-off-by: Enrico Weigelt, metux IT consult Thanks for your patch! > --- a/arch/alpha/kernel/process.c > +++ b/arch/alpha/kernel/process.c > @@ -43,12 +43,6 @@ > #include "proto.h" > #include "pci_impl.h" > > -/* > - * Power off function, if any > - */ > -void (*pm_power_off)(void) = machine_power_off; Assignments like these are lost in the conversion. > -EXPORT_SYMBOL(pm_power_off); Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds