From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA6D3C433DF for ; Mon, 19 Oct 2020 18:54:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 44A0A223C7 for ; Mon, 19 Oct 2020 18:54:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=atishpatra.org header.i=@atishpatra.org header.b="JlQ9cG/y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730871AbgJSSyg (ORCPT ); Mon, 19 Oct 2020 14:54:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55130 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727681AbgJSSyf (ORCPT ); Mon, 19 Oct 2020 14:54:35 -0400 Received: from mail-il1-x144.google.com (mail-il1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A36ACC0613CE for ; Mon, 19 Oct 2020 11:54:35 -0700 (PDT) Received: by mail-il1-x144.google.com with SMTP id j8so1368354ilk.0 for ; Mon, 19 Oct 2020 11:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=atishpatra.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g2jWFfexdEDtBs2gfOXBbLGLdiOa+LTYwZ8t0Hf50aI=; b=JlQ9cG/yAPjE1oRino9Ot4VwHkBF+HDA8uJqkjp+tCCfIbq1LZBxFO3nmlTgDGiRgc O6lMduG3Rjn04ohMMV4Iaycqd4TlujJhVdHrZZYwQLkvi+lZzqsXGmty+VqzwaLg9n4J lYUwJZjZE4DAT71qHcQ85586gf8egO1rwVWCg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g2jWFfexdEDtBs2gfOXBbLGLdiOa+LTYwZ8t0Hf50aI=; b=XW4FgIv1h5t91Rbt8P+pxqfwLNEQysJlcnl3+2YkF/mPS+lwIf/SfRQiH2h1RrlQz+ fQ424U4itu/9n4lSlUtpcUJFiCFqSa1D4zPikUCAox7ISTOSn7508bnu0mm2ZIuG+fDh wJk/9fop4qjx7EpH3f0xtzmVJEzODPy+JXQMHYBRs99w3d8e8vxzslbuQ7O7mwayc4iJ /4gZX2/J1bp4tWsMZ9scMzJJ/OMPg+a4oGtUC0mqBMYjAniBaUvhrHTOyKLGqocxxsGN ogrKmhmHHQnA6YpTFWKksWXH4Q6oK32713bY+YVmS771tJ4QZZMRcPZJme9ryhityUjq bOQA== X-Gm-Message-State: AOAM532OO1lzl6pp4AJ8YPXb5eABXClKYpFQG1Sm2AnKY5JVKEebOKFp zYIka54Ifiqx+9zTwF2HkDS+BFDovbU3NXCfvRLv X-Google-Smtp-Source: ABdhPJyb4PiVcwv1NkNj9aDJ/FpCHM6dnsTKUq/tHGd1tg2kp/35Pn9JvsV5zP5l+EX8LkrfBx7zhVJp6sbJMpGmIv8= X-Received: by 2002:a92:1801:: with SMTP id 1mr793536ily.219.1603133674949; Mon, 19 Oct 2020 11:54:34 -0700 (PDT) MIME-Version: 1.0 References: <1602918377-23573-1-git-send-email-guoren@kernel.org> <1602918377-23573-10-git-send-email-guoren@kernel.org> In-Reply-To: <1602918377-23573-10-git-send-email-guoren@kernel.org> From: Atish Patra Date: Mon, 19 Oct 2020 11:54:24 -0700 Message-ID: Subject: Re: [PATCH v4 9/9] riscv: Fixup lockdep_assert_held(&text_mutex) in patch_insn_write To: Guo Ren , Zong Li Cc: Palmer Dabbelt , Paul Walmsley , mhiramat@kernel.org, Alan Kao , rostedt@goodmis.org, me@packi.ch, Guo Ren , Anup Patel , "linux-kernel@vger.kernel.org List" , linux-csky@vger.kernel.org, Greentime Hu , linux-riscv Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-csky@vger.kernel.org On Sat, Oct 17, 2020 at 12:07 AM wrote: > > From: Guo Ren > > It will cause warning messages: > echo function_graph > /sys/kernel/debug/tracing/current_tracer > [ 47.691397] ------------[ cut here ]------------ > [ 47.692899] WARNING: CPU: 0 PID: 11 at arch/riscv/kernel/patch.c:63 patch_insn_write+0x182/0x19a > [ 47.694483] Modules linked in: > [ 47.695754] CPU: 0 PID: 11 Comm: migration/0 Not tainted 5.9.0-11367-g1054335 #132 > [ 47.698228] epc: ffffffe000204530 ra : ffffffe00020452c sp : ffffffe0023ffc20 gp : ffffffe0013e1fe0 tp : ffffffe0023e4e00 t0 : 0000000000000000 > [ 47.701872] t1 : 000000000000000e t2 : 000000000000001b s0 : ffffffe0023ffc70 s1 : ffffffe000206850 a0 : 0000000000000000 a1 : ffffffffffffffff > [ 47.705550] a2 : 0000000000000000 a3 : ffffffe03af7c5e8 a4 : 0000000000000000 a5 : 0000000000000000 a6 : 0000000000000000 a7 : 00000000150b02d8 > [ 47.709159] s2 : 0000000000000008 s3 : 0000000000000858 s4 : ffffffe0023ffc98 s5 : 0000000000000850 s6 : 0000000000000003 s7 : 0000000000000002 > [ 47.714135] s8 : 0000000000000004 s9 : 0000000000000001 s10: 0000000000000001 s11: 0000000000000003 t3 : ffffffffffffe000 t4 : 0000000000d86254 > [ 47.716574] t5 : 0000000000000005 t6 : 0000000000040000status: 0000000000000100 badaddr: 0000000000000000 cause: 0000000000000003 > [ 47.720019] CPU: 0 PID: 11 Comm: migration/0 Not tainted 5.9.0-11367-g1054335 #132 > [ 47.722074] Call Trace: > [ 47.722561] [] walk_stackframe+0x0/0xc2 > [ 47.724608] [] show_stack+0x46/0x52 > [ 47.726246] [] dump_stack+0x90/0xb6 > [ 47.727672] [] __warn+0x98/0xfa > [ 47.729131] [] report_bug+0xaa/0x11e > [ 47.730624] [] do_trap_break+0x96/0xfe > [ 47.732448] [] ret_from_exception+0x0/0x14 > [ 47.734341] [] patch_insn_write+0x17e/0x19a > [ 47.737235] irq event stamp: 39 > [ 47.738521] hardirqs last enabled at (39): [] _save_context+0xa2/0xe6 > [ 47.741055] hardirqs last disabled at (38): [] multi_cpu_stop+0x130/0x166 > [ 47.743551] softirqs last enabled at (0): [] copy_process+0x430/0x1316 > [ 47.746031] softirqs last disabled at (0): [<0000000000000000>] 0x0 > [ 47.748617] ---[ end trace 88a1054faa6524ef ]--- > > Because the path of stop_machine(__ftrace_modify_code)-> > ftrace_modify_all_code->...->patch_insn_write has no pair of > lock&unlock text_mutex, so we shouldn't put assert here. > What platform are you testing ? We are seeing a crash while enabling any of the tracers multiple times on Qemu/HiFive Unleashed. http://lists.infradead.org/pipermail/linux-riscv/2020-October/002354.html As per the thread, Zong agreed to take a look into that. @Zong Li : Do you have any update regarding the ftrace issue. > Signed-off-by: Guo Ren > --- > arch/riscv/kernel/patch.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/arch/riscv/kernel/patch.c b/arch/riscv/kernel/patch.c > index 0b55287..2ee5063 100644 > --- a/arch/riscv/kernel/patch.c > +++ b/arch/riscv/kernel/patch.c > @@ -55,13 +55,6 @@ static int patch_insn_write(void *addr, const void *insn, size_t len) > bool across_pages = (((uintptr_t) addr & ~PAGE_MASK) + len) > PAGE_SIZE; > int ret; > > - /* > - * Before reaching here, it was expected to lock the text_mutex > - * already, so we don't need to give another lock here and could > - * ensure that it was safe between each cores. > - */ > - lockdep_assert_held(&text_mutex); > - > if (across_pages) > patch_map(addr + len, FIX_TEXT_POKE1); > > -- > 2.7.4 > > > _______________________________________________ > linux-riscv mailing list > linux-riscv@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv -- Regards, Atish