linux-csky.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guo Ren <guoren@linux.alibaba.com>
To: Will Deacon <will@kernel.org>, guoren@kernel.org
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org
Subject: Re: [PATCH] arm64: Make TSK_STACK_CANARY more accurate defined
Date: Tue, 14 Jul 2020 17:32:39 +0800	[thread overview]
Message-ID: <d69bbfdb-64a2-aa14-a422-770af9bc68f3@linux.alibaba.com> (raw)
In-Reply-To: <20200714083715.GE4516@willie-the-truck>



On 2020/7/14 下午4:37, Will Deacon wrote:
> On Mon, Jul 13, 2020 at 04:03:33AM +0000, guoren@kernel.org wrote:
>> From: Guo Ren <guoren@linux.alibaba.com>
>>
>> TSK_STACK_CANARY only used in arm64/Makefile with
>> CONFIG_STACKPROTECTOR_PER_TASK wrap. So use the same policy in
>> asm-offset.c.
>>
>> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
>> Co-developed-by: Kees Cook <keescook@chromium.org>
>> Cc: Catalin Marinas <catalin.marinas@arm.com>
>> Cc: Will Deacon <will@kernel.org>
>> ---
>>   arch/arm64/kernel/asm-offsets.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/asm-offsets.c b/arch/arm64/kernel/asm-offsets.c
>> index 0577e21..37d5d3d 100644
>> --- a/arch/arm64/kernel/asm-offsets.c
>> +++ b/arch/arm64/kernel/asm-offsets.c
>> @@ -39,7 +39,7 @@ int main(void)
>>     DEFINE(TSK_TI_SCS_SP,		offsetof(struct task_struct, thread_info.scs_sp));
>>   #endif
>>     DEFINE(TSK_STACK,		offsetof(struct task_struct, stack));
>> -#ifdef CONFIG_STACKPROTECTOR
>> +#ifdef CONFIG_STACKPROTECTOR_PER_TASK
>>     DEFINE(TSK_STACK_CANARY,	offsetof(struct task_struct, stack_canary));
>>   #endif
> I don't think this really makese much sense. The 'stack_canary' field in
> 'struct task_struct' is defined as:
>
> #ifdef CONFIG_STACKPROTECTOR
>          /* Canary value for the -fstack-protector GCC feature: */
>          unsigned long                   stack_canary;
> #endif
>
> so I think it makes sense to follow that in asm-offsets.c
>
> Does the current code actually cause a problem?
No, I just want to know how arm64 reply, ref:
https://lore.kernel.org/linux-riscv/1594397998-10221-1-git-send-email-guoren@kernel.org/T/#t

Best Regards
  Guo Ren


  reply	other threads:[~2020-07-14  9:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13  4:03 [PATCH] arm64: Make TSK_STACK_CANARY more accurate defined guoren
2020-07-14  8:37 ` Will Deacon
2020-07-14  9:32   ` Guo Ren [this message]
2020-07-17  0:56   ` Guo Ren
2020-07-17 10:19     ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d69bbfdb-64a2-aa14-a422-770af9bc68f3@linux.alibaba.com \
    --to=guoren@linux.alibaba.com \
    --cc=catalin.marinas@arm.com \
    --cc=guoren@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-csky@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).