* [PATCH] riscv: Fixup CONFIG_GENERIC_TIME_VSYSCALL
@ 2021-01-02 13:24 guoren
2021-01-03 10:11 ` Pekka Enberg
0 siblings, 1 reply; 3+ messages in thread
From: guoren @ 2021-01-02 13:24 UTC (permalink / raw)
To: palmerdabbelt, paul.walmsley, anup, atish.patra
Cc: linux-riscv, linux-kernel, linux-csky, guoren, Guo Ren, Vincent Chen
From: Guo Ren <guoren@linux.alibaba.com>
The patch fix commit: ad5d112 ("riscv: use vDSO common flow to
reduce the latency of the time-related functions").
The GENERIC_TIME_VSYSCALL should be CONFIG_GENERIC_TIME_VSYSCALL
or vgettimeofday won't work.
Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
Cc: Atish Patra <atish.patra@wdc.com>
Cc: Palmer Dabbelt <palmerdabbelt@google.com>
Cc: Vincent Chen <vincent.chen@sifive.com>
---
arch/riscv/include/asm/vdso.h | 2 +-
arch/riscv/kernel/vdso.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/riscv/include/asm/vdso.h b/arch/riscv/include/asm/vdso.h
index 8454f74..1453a2f 100644
--- a/arch/riscv/include/asm/vdso.h
+++ b/arch/riscv/include/asm/vdso.h
@@ -10,7 +10,7 @@
#include <linux/types.h>
-#ifndef GENERIC_TIME_VSYSCALL
+#ifndef CONFIG_GENERIC_TIME_VSYSCALL
struct vdso_data {
};
#endif
diff --git a/arch/riscv/kernel/vdso.c b/arch/riscv/kernel/vdso.c
index 6782042..3f1d35e 100644
--- a/arch/riscv/kernel/vdso.c
+++ b/arch/riscv/kernel/vdso.c
@@ -12,7 +12,7 @@
#include <linux/binfmts.h>
#include <linux/err.h>
#include <asm/page.h>
-#ifdef GENERIC_TIME_VSYSCALL
+#ifdef CONFIG_GENERIC_TIME_VSYSCALL
#include <vdso/datapage.h>
#else
#include <asm/vdso.h>
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Fixup CONFIG_GENERIC_TIME_VSYSCALL
2021-01-02 13:24 [PATCH] riscv: Fixup CONFIG_GENERIC_TIME_VSYSCALL guoren
@ 2021-01-03 10:11 ` Pekka Enberg
2021-01-13 4:36 ` Palmer Dabbelt
0 siblings, 1 reply; 3+ messages in thread
From: Pekka Enberg @ 2021-01-03 10:11 UTC (permalink / raw)
To: Guo Ren
Cc: Palmer Dabbelt, Paul Walmsley, Anup Patel, Atish Patra, Guo Ren,
LKML, linux-csky, Vincent Chen, linux-riscv
On Sat, Jan 2, 2021 at 3:26 PM <guoren@kernel.org> wrote:
>
> From: Guo Ren <guoren@linux.alibaba.com>
>
> The patch fix commit: ad5d112 ("riscv: use vDSO common flow to
> reduce the latency of the time-related functions").
>
> The GENERIC_TIME_VSYSCALL should be CONFIG_GENERIC_TIME_VSYSCALL
> or vgettimeofday won't work.
>
> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
> Cc: Atish Patra <atish.patra@wdc.com>
> Cc: Palmer Dabbelt <palmerdabbelt@google.com>
> Cc: Vincent Chen <vincent.chen@sifive.com>
Reviewed-by: Pekka Enberg <penberg@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] riscv: Fixup CONFIG_GENERIC_TIME_VSYSCALL
2021-01-03 10:11 ` Pekka Enberg
@ 2021-01-13 4:36 ` Palmer Dabbelt
0 siblings, 0 replies; 3+ messages in thread
From: Palmer Dabbelt @ 2021-01-13 4:36 UTC (permalink / raw)
To: penberg
Cc: guoren, Paul Walmsley, anup, Atish Patra, guoren, linux-kernel,
linux-csky, vincent.chen, linux-riscv
On Sun, 03 Jan 2021 02:11:35 PST (-0800), penberg@gmail.com wrote:
> On Sat, Jan 2, 2021 at 3:26 PM <guoren@kernel.org> wrote:
>>
>> From: Guo Ren <guoren@linux.alibaba.com>
>>
>> The patch fix commit: ad5d112 ("riscv: use vDSO common flow to
>> reduce the latency of the time-related functions").
>>
>> The GENERIC_TIME_VSYSCALL should be CONFIG_GENERIC_TIME_VSYSCALL
>> or vgettimeofday won't work.
>>
>> Signed-off-by: Guo Ren <guoren@linux.alibaba.com>
>> Cc: Atish Patra <atish.patra@wdc.com>
>> Cc: Palmer Dabbelt <palmerdabbelt@google.com>
>> Cc: Vincent Chen <vincent.chen@sifive.com>
>
> Reviewed-by: Pekka Enberg <penberg@kernel.org>
Thanks, this is on fixes.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-13 4:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-02 13:24 [PATCH] riscv: Fixup CONFIG_GENERIC_TIME_VSYSCALL guoren
2021-01-03 10:11 ` Pekka Enberg
2021-01-13 4:36 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).