From: Dave Jiang <dave.jiang@intel.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: dan.j.williams@intel.com, jonathan.cameron@huawei.com,
ira.weiny@intel.com, fan.ni@samsung.com,
a.manzanares@samsung.com, linux-cxl@vger.kernel.org
Subject: Re: [PATCH 1/7] cxl/mbox: Add background cmd handling machinery
Date: Tue, 28 Feb 2023 16:35:34 -0700 [thread overview]
Message-ID: <19e29949-6003-3d90-75d7-735c35b0e279@intel.com> (raw)
In-Reply-To: <20230228201848.b73ralnihs6rbceg@offworld>
On 2/28/23 1:18 PM, Davidlohr Bueso wrote:
> On Tue, 28 Feb 2023, Dave Jiang wrote:
>>> +
>>> + dev_dbg(dev, "Mailbox background operation completed\n");
>>
>> May be helpful to also emit the return_code in case of errors.
>
> Agreed, but that's given next:
>
>>
>>> + }
>>> +
>>> if (mbox_cmd->return_code != CXL_MBOX_CMD_RC_SUCCESS) {
>>> dev_dbg(dev, "Mailbox operation had an error: %s\n",
>>> cxl_mbox_cmd_rc2str(mbox_cmd));
>
> here.
Ah ok.
>
> Thanks,
> Davidlohr
next prev parent reply other threads:[~2023-02-28 23:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 19:46 [PATCH v3 0/7] cxl: Background cmds and device sanitation Davidlohr Bueso
2023-02-24 19:25 ` Davidlohr Bueso
2023-02-24 19:46 ` [PATCH 1/7] cxl/mbox: Add background cmd handling machinery Davidlohr Bueso
2023-02-28 16:27 ` Dave Jiang
2023-02-28 20:18 ` Davidlohr Bueso
2023-02-28 23:35 ` Dave Jiang [this message]
2023-03-27 21:57 ` Dan Williams
2023-02-24 19:46 ` [PATCH 2/7] cxl/security: Add security state sysfs ABI Davidlohr Bueso
2023-02-28 16:47 ` Dave Jiang
2023-03-28 1:11 ` Dan Williams
2023-02-24 19:46 ` [PATCH 3/7] cxl/region: Add cxl_memdev_active_region() Davidlohr Bueso
2023-02-27 3:46 ` Alison Schofield
2023-02-28 20:26 ` Davidlohr Bueso
2023-02-28 23:20 ` Fan Ni
2023-03-28 1:15 ` Dan Williams
2023-02-24 19:46 ` [PATCH 4/7] cxl/mem: Support Sanitation Davidlohr Bueso
2023-02-28 17:28 ` Dave Jiang
2023-02-28 20:22 ` Davidlohr Bueso
2023-03-28 6:26 ` Dan Williams
2023-04-05 21:06 ` Davidlohr Bueso
2023-04-05 22:24 ` Dan Williams
2023-02-24 19:46 ` [PATCH 5/7] cxl/test: Add "Sanitize" opcode support Davidlohr Bueso
2023-02-28 18:03 ` Dave Jiang
2023-02-24 19:46 ` [PATCH 6/7] cxl/mem: Support Secure Erase Davidlohr Bueso
2023-02-28 18:31 ` Dave Jiang
2023-02-24 19:46 ` [PATCH 7/7] cxl/test: Add "Secure Erase" opcode support Davidlohr Bueso
2023-02-28 18:36 ` Dave Jiang
2023-03-22 0:05 ` [PATCH v3 0/7] cxl: Background cmds and device sanitation Davidlohr Bueso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19e29949-6003-3d90-75d7-735c35b0e279@intel.com \
--to=dave.jiang@intel.com \
--cc=a.manzanares@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dave@stgolabs.net \
--cc=fan.ni@samsung.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).