From: Jason Gunthorpe <jgg@nvidia.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
vishal.l.verma@intel.com, ira.weiny@intel.com,
alison.schofield@intel.com
Subject: Re: [PATCH v3 3/4] cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures
Date: Wed, 31 Mar 2021 10:09:53 -0300 [thread overview]
Message-ID: <20210331130953.GG1463678@nvidia.com> (raw)
In-Reply-To: <161714740233.2168142.11116065966198937093.stgit@dwillia2-desk3.amr.corp.intel.com>
On Tue, Mar 30, 2021 at 04:36:42PM -0700, Dan Williams wrote:
> +static int cxl_mem_add_memdev(struct cxl_mem *cxlm)
> +{
> + struct cxl_memdev *cxlmd;
> + struct device *dev;
> + struct cdev *cdev;
> + int rc;
> +
> + cxlmd = cxl_memdev_alloc(cxlm);
> + if (IS_ERR(cxlmd))
> + return PTR_ERR(cxlmd);
> +
> + dev = &cxlmd->dev;
> + rc = dev_set_name(dev, "mem%d", cxlmd->id);
> + if (rc)
> + goto err;
>
> + cdev = &cxlmd->cdev;
> cxl_memdev_activate(cxlmd, cxlm);
> rc = cdev_device_add(cdev, dev);
> if (rc)
> - goto err_add;
> + goto err;
It might read nicer to have the error unwind here just call cxl_memdev_unregister()
> - return devm_add_action_or_reset(&pdev->dev, cxl_memdev_unregister,
> + return devm_add_action_or_reset(dev->parent, cxl_memdev_unregister,
> cxlmd);
Since that is what the error unwind does at this point.
>
> -err_add:
> +err:
> /*
> * The cdev was briefly live, shutdown any ioctl operations that
> * saw that state.
> */
> cxl_memdev_shutdown(cxlmd);
Then this doesn't need to be a function
But it is OK as is
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
next prev parent reply other threads:[~2021-03-31 13:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:36 [PATCH v3 0/4] cxl/mem: Fix memdev device setup Dan Williams
2021-03-30 23:36 ` [PATCH v3 1/4] cxl/mem: Use sysfs_emit() for attribute show routines Dan Williams
2021-03-30 23:36 ` [PATCH v3 2/4] cxl/mem: Fix synchronization mechanism for device removal vs ioctl operations Dan Williams
2021-03-31 13:07 ` Jason Gunthorpe
2021-03-31 15:45 ` Dan Williams
2021-03-30 23:36 ` [PATCH v3 3/4] cxl/mem: Do not rely on device_add() side effects for dev_set_name() failures Dan Williams
2021-03-31 13:09 ` Jason Gunthorpe [this message]
2021-03-31 16:04 ` Dan Williams
2021-03-31 16:17 ` Jason Gunthorpe
2021-03-31 16:32 ` Dan Williams
2021-03-30 23:36 ` [PATCH v3 4/4] cxl/mem: Disable cxl device power management Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331130953.GG1463678@nvidia.com \
--to=jgg@nvidia.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).