From: Ben Widawsky <ben.widawsky@intel.com>
To: Alison Schofield <alison.schofield@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH v3 0/2] CXL ACPI tables for object creation
Date: Thu, 17 Jun 2021 08:41:33 -0700 [thread overview]
Message-ID: <20210617154133.zb54zf46foxcss3c@intel.com> (raw)
In-Reply-To: <cover.1623890468.git.alison.schofield@intel.com>
On 21-06-16 18:11:06, Alison Schofield wrote:
> Jonathan - I updated Patch 2 so I didn't keep your Reviewed-by tag.
>
> Changes since v2 [1]:
> - Warn and continue, rather than error out, on these acpi table parsing issues:
> table length mismatch for either CHBS or CFMWS; duplicate uid's for CHBS.
> (Ben, Jonathan)
> - Update flow in cxl_acpi_match_chbs() (Ben, Jonathan)
> - Improve naming cedt_table->acpi_cedt, cedt_base->cedt_subtable (Ben)
> - Emit debug message only if CFMWS is greater than its expected length (Ben)
> - Update the dev_err messages wrt the CFMWS expected length failure.
> - Remove blank line before error handling block (Jonathan)
> - Rebase to the CXL pending branch [2]
>
> [1]: https://lore.kernel.org/linux-cxl/cover.1623800340.git.alison.schofield@intel.com/
> [2]: https://git.kernel.org/pub/scm/linux/kernel/git/cxl/cxl.git/log/?h=pending
>
> --
> Parse the ACPI CXL Early Discovery Table (CEDT) and use the CHBS & CFMWS
> when creating port and decoder objects.
>
> CHBS: CXL Host Bridge Structure - Patch 1
> CFMWS: CXL Fixed Memory Window Structure - Patch 2
>
> Alison Schofield (2):
> cxl/acpi: Add the Host Bridge base address to CXL port objects
> cxl/acpi: Use the ACPI CFMWS to create static decoder objects
>
> drivers/cxl/acpi.c | 217 +++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 212 insertions(+), 5 deletions(-)
>
>
> base-commit: 21083f51521fb0f60dbac591f175c3ed48435af4
It might be nice to add a header kdoc for acpi.c now that it's become sufficiently
complex. Can be follow-on patch.
Both are:
Reviewed-by: Ben Widawsky <ben.widawsky@intel.com>
prev parent reply other threads:[~2021-06-17 15:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 1:11 [PATCH v3 0/2] CXL ACPI tables for object creation Alison Schofield
2021-06-17 1:11 ` [PATCH v3 1/2] cxl/acpi: Add the Host Bridge base address to CXL port objects Alison Schofield
2021-06-17 8:57 ` Jonathan Cameron
2021-06-17 1:11 ` [PATCH v3 2/2] cxl/acpi: Use the ACPI CFMWS to create static decoder objects Alison Schofield
2021-06-17 9:00 ` Jonathan Cameron
2021-06-17 15:43 ` Ben Widawsky
2021-06-17 15:41 ` Ben Widawsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617154133.zb54zf46foxcss3c@intel.com \
--to=ben.widawsky@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).