From: ira.weiny@intel.com
To: Dan Williams <dan.j.williams@intel.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Ben Widawsky <ben@bwidawsk.net>,
linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: [PATCH V9 8/9] cxl/port: Retry reading CDAT on failure
Date: Tue, 31 May 2022 08:26:31 -0700 [thread overview]
Message-ID: <20220531152632.1397976-9-ira.weiny@intel.com> (raw)
In-Reply-To: <20220531152632.1397976-1-ira.weiny@intel.com>
From: Ira Weiny <ira.weiny@intel.com>
The CDAT read may fail for a number of reasons but mainly it is possible
to get different parts of a valid state. The checksum in the CDAT table
protects against this.
Now that the cdat data is validated issue a retries if the CDAT read
fails. For now 5 retries are implemented.
Signed-off-by: Ira Weiny <ira.weiny@intel.com>
---
Changes from V8
Move code to cxl/core/pci.c
Changes from V6
Move to pci.c
Fix retries count
Change to 5 retries
Changes from V5:
New patch -- easy to push off or drop.
---
drivers/cxl/core/pci.c | 32 +++++++++++++++++++++-----------
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c
index bb370df1cb6c..7f7dac9030a6 100644
--- a/drivers/cxl/core/pci.c
+++ b/drivers/cxl/core/pci.c
@@ -620,20 +620,18 @@ static int cxl_cdat_read_table(struct cxl_port *port,
return rc;
}
-void read_cdat_data(struct cxl_port *port)
+static int __read_cdat_data(struct cxl_port *port)
{
struct device *dev = &port->dev;
size_t cdat_length;
int ret;
if (cxl_cdat_get_length(port, &cdat_length))
- return;
+ return 0;
port->cdat.table = devm_kzalloc(dev, cdat_length, GFP_KERNEL);
- if (!port->cdat.table) {
- ret = -ENOMEM;
- goto error;
- }
+ if (!port->cdat.table)
+ return -ENOMEM;
port->cdat.length = cdat_length;
ret = cxl_cdat_read_table(port, &port->cdat);
@@ -641,12 +639,24 @@ void read_cdat_data(struct cxl_port *port)
devm_kfree(dev, port->cdat.table);
port->cdat.table = NULL;
port->cdat.length = 0;
- ret = -EIO;
- goto error;
+ return -EIO;
}
- return;
-error:
- dev_err(dev, "CDAT data read error (%d)\n", ret);
+ return 0;
+}
+
+void read_cdat_data(struct cxl_port *port)
+{
+ int retries = 5;
+ int rc;
+
+ while (retries--) {
+ rc = __read_cdat_data(port);
+ if (!rc)
+ break;
+ dev_err(&port->dev,
+ "CDAT data read error rc=%d (retries %d)\n",
+ rc, retries);
+ }
}
EXPORT_SYMBOL_NS_GPL(read_cdat_data, CXL);
--
2.35.1
next prev parent reply other threads:[~2022-05-31 15:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 15:26 [PATCH V9 0/9] CXL: Read CDAT and DSMAS data ira.weiny
2022-05-31 15:26 ` [PATCH V9 1/9] PCI: Add vendor ID for the PCI SIG ira.weiny
2022-05-31 17:00 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 2/9] PCI: Replace magic constant for PCI Sig Vendor ID ira.weiny
2022-05-31 17:00 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 3/9] PCI: Create PCI library functions in support of DOE mailboxes ira.weiny
2022-05-31 17:25 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 17:56 ` Davidlohr Bueso
2022-06-01 4:53 ` Ira Weiny
2022-06-01 13:59 ` Davidlohr Bueso
2022-06-01 16:55 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 4/9] cxl/pci: Create PCI DOE mailbox's for memory devices ira.weiny
2022-05-31 17:50 ` Ben Widawsky
2022-06-01 14:35 ` Jonathan Cameron
2022-06-01 23:01 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 5/9] cxl/port: Find a DOE mailbox which supports CDAT ira.weiny
2022-05-31 17:57 ` Ben Widawsky
2022-06-01 22:03 ` Ira Weiny
2022-05-31 15:26 ` [PATCH V9 6/9] cxl/port: Read CDAT table ira.weiny
2022-06-01 15:35 ` Jonathan Cameron
2022-06-01 16:31 ` Jonathan Cameron
2022-06-02 18:31 ` Ira Weiny
2022-06-02 22:47 ` Ira Weiny
2022-06-06 14:49 ` Jonathan Cameron
2022-05-31 15:26 ` [PATCH V9 7/9] cxl/port: Introduce cxl_cdat_valid() ira.weiny
2022-05-31 17:21 ` Alison Schofield
2022-06-01 22:10 ` Ira Weiny
2022-05-31 15:26 ` ira.weiny [this message]
2022-05-31 17:07 ` [PATCH V9 8/9] cxl/port: Retry reading CDAT on failure Alison Schofield
2022-06-01 4:54 ` Ira Weiny
2022-05-31 19:30 ` [PATCH v9 " Davidlohr Bueso
2022-05-31 15:26 ` [PATCH V9 9/9] cxl/port: Parse out DSMAS data from CDAT table ira.weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220531152632.1397976-9-ira.weiny@intel.com \
--to=ira.weiny@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alison.schofield@intel.com \
--cc=ben@bwidawsk.net \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).