From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EDF6C54EE9 for ; Tue, 20 Sep 2022 16:20:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231486AbiITQUi (ORCPT ); Tue, 20 Sep 2022 12:20:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230182AbiITQUT (ORCPT ); Tue, 20 Sep 2022 12:20:19 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 804316D9DE; Tue, 20 Sep 2022 09:17:52 -0700 (PDT) Received: from fraeml740-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4MX6B70Dssz67hlj; Wed, 21 Sep 2022 00:16:47 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (7.191.163.240) by fraeml740-chm.china.huawei.com (10.206.15.221) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 18:17:49 +0200 Received: from localhost (10.202.226.42) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Tue, 20 Sep 2022 17:17:49 +0100 Date: Tue, 20 Sep 2022 17:17:48 +0100 From: Jonathan Cameron To: Ira Weiny CC: Dan Williams , Alison Schofield , Vishal Verma , "Ben Widawsky" , Steven Rostedt , Davidlohr Bueso , , Subject: Re: [RFC PATCH 7/9] cxl/test: Add generic mock events Message-ID: <20220920171748.00001260@huawei.com> In-Reply-To: References: <20220813053243.757363-1-ira.weiny@intel.com> <20220813053243.757363-8-ira.weiny@intel.com> <20220825123119.00000705@huawei.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.29; i686-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.42] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Thu, 15 Sep 2022 11:53:29 -0700 Ira Weiny wrote: > On Thu, Aug 25, 2022 at 12:31:19PM +0100, Jonathan Cameron wrote: > > On Fri, 12 Aug 2022 22:32:41 -0700 > > ira.weiny@intel.com wrote: > > > > > From: Ira Weiny > > > > > > Facilitate testing basic Get/Clear Event functionality by creating > > > multiple logs and generic events with made up UUID's. > > > > > > Data is completely made up with data patterns which should be easy to > > > spot in trace output. > > Hi Ira, > > > > I'm tempted to hack the QEMU emulation for this in with appropriately > > complex interface to inject all the record types... > > Every time I look at the QEMU code it makes my head spin. :-( You get used to it ;)` > > I really thought about adding some support there. And I think for irq's it may > work better? But after your talk today I did a quick search to see what it > would take to do irqs in QEMU and got even more confused. :-( Copy an example - though we haven't upstreamed any yet... Either... https://gitlab.com/jic23/qemu/-/commit/958fec58582b5cc910d2da4e2b855e134bb2c0c3#3dfd54f69a5f2382ddf5a6c00a52546d8b57316e_0_169 Or the CPMU one. https://lore.kernel.org/all/20220831153336.16165-2-Jonathan.Cameron@huawei.com/ to setup then look for msix_notify in https://lore.kernel.org/all/20220831153336.16165-4-Jonathan.Cameron@huawei.com/ > > > Lots to do there though, so not sure where this fits in my priority list! > > I bet it is higher on mine! ;-) :) > > > > > > > > > Test traces are easy to obtain with a small script such as this: > > > > > > #!/bin/bash -x > > > > > > devices=`find /sys/devices/platform -name cxl_mem*` > > > > > > # Generate fake events if reset is passed in > > > > reset is rather unintuitive naming. > > > > fill_event_queue maybe or something more in that direction? > > Fair enough... Naming is hard and I'm one of the worst. > > I've changed to > > /.../event_fill_queue > /.../event_trigger > > Thoughts? Works for me. .. J