From: Lukas Wunner <lukas@wunner.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-cxl@vger.kernel.org, ira.weiny@intel.com
Subject: Re: [PATCH] cxl/port: Fix port to pci device assumptions in read_cdat_data()
Date: Sun, 23 Apr 2023 00:30:05 +0200 [thread overview]
Message-ID: <20230422223005.GA12308@wunner.de> (raw)
In-Reply-To: <644449689728c_1b66294e1@dwillia2-xfh.jf.intel.com.notmuch>
On Sat, Apr 22, 2023 at 01:54:00PM -0700, Dan Williams wrote:
> Lukas Wunner wrote:
> > On Sat, Apr 22, 2023 at 10:35:02AM +0200, Lukas Wunner wrote:
> > > I note however that before af0a6c3587dc, xa_for_each() was run on an
> > > xarray which was not initialized with xa_init() on non-pci cxl ports.
> > > (xa_init() was run from cxl_pci_probe() -> devm_cxl_pci_create_doe()
> > > but xa_for_each() was run from read_cdat_data() -> find_cdat_doe()
> > > for non-pci cxl ports as well.)
> > >
> > > Hence can't this crash prior to af0a6c3587dc as well?
> >
> > After taking another look with a fresh pair of eyeballs I think
> > you may see splats with CONFIG_DEBUG_LOCK_ALLOC=y (even prior to
> > af0a6c3587dc on non-pci cxl devices) due to the missing xa_init().
>
> The xa_init() was included before in the removed call to
> devm_cxl_pci_create_doe().
... which was called from cxl_pci_probe(), so only if a pci_dev exists?
I guess I must be missing something...
Thanks,
Lukas
next prev parent reply other threads:[~2023-04-22 22:30 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-11 14:40 [PATCH v4 00/17] Collection of DOE material Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 01/17] cxl/pci: Fix CDAT retrieval on big endian Lukas Wunner
2023-03-15 16:39 ` Jonathan Cameron
2023-03-11 14:40 ` [PATCH v4 02/17] cxl/pci: Handle truncated CDAT header Lukas Wunner
2023-03-13 2:42 ` Sathyanarayanan Kuppuswamy
2023-03-11 14:40 ` [PATCH v4 03/17] cxl/pci: Handle truncated CDAT entries Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 04/17] cxl/pci: Handle excessive CDAT length Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 05/17] PCI/DOE: Silence WARN splat with CONFIG_DEBUG_OBJECTS=y Lukas Wunner
2023-03-21 3:42 ` Alexey Kardashevskiy
2023-03-21 9:05 ` Jonathan Cameron
2023-04-04 9:01 ` Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 06/17] PCI/DOE: Fix memory leak " Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 07/17] PCI/DOE: Provide synchronous API and use it internally Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 08/17] cxl/pci: Use synchronous API for DOE Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 09/17] PCI/DOE: Make asynchronous API private Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 10/17] PCI/DOE: Deduplicate mailbox flushing Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 11/17] PCI/DOE: Allow mailbox creation without devres management Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 12/17] PCI/DOE: Create mailboxes on device enumeration Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 13/17] cxl/pci: Use CDAT DOE mailbox created by PCI core Lukas Wunner
2023-04-22 2:51 ` [PATCH] cxl/port: Fix port to pci device assumptions in read_cdat_data() Dan Williams
2023-04-22 8:35 ` Lukas Wunner
2023-04-22 14:05 ` Lukas Wunner
2023-04-22 20:54 ` Dan Williams
2023-04-22 22:30 ` Lukas Wunner [this message]
2023-04-22 23:22 ` Dan Williams
2023-04-23 8:19 ` Lukas Wunner
2023-04-22 20:56 ` Dan Williams
2023-04-23 14:58 ` Jonathan Cameron
2023-04-23 15:07 ` Jonathan Cameron
2023-04-23 18:32 ` Dan Williams
2023-03-11 14:40 ` [PATCH v4 14/17] PCI/DOE: Make mailbox creation API private Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 15/17] PCI/DOE: Relax restrictions on request and response size Lukas Wunner
2023-03-11 14:40 ` [PATCH v4 16/17] cxl/pci: Simplify CDAT retrieval error path Lukas Wunner
2023-03-15 16:48 ` Jonathan Cameron
2023-03-11 14:40 ` [PATCH v4 17/17] cxl/pci: Rightsize CDAT response allocation Lukas Wunner
2023-03-13 19:55 ` [PATCH v4 00/17] Collection of DOE material Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230422223005.GA12308@wunner.de \
--to=lukas@wunner.de \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).