From: Vaibhav Jain <vaibhav@linux.ibm.com>
To: Dan Williams <dan.j.williams@intel.com>, nvdimm@lists.linux.dev
Cc: linux-cxl@vger.kernel.org
Subject: Re: [ndctl PATCH 0/6] Convert to the Meson build system
Date: Thu, 15 Jul 2021 00:16:27 +0530 [thread overview]
Message-ID: <87mtqo68e4.fsf@vajain21.in.ibm.com> (raw)
In-Reply-To: <162586035908.1431180.14991721381432827647.stgit@dwillia2-desk3.amr.corp.intel.com>
Dan Williams <dan.j.williams@intel.com> writes:
> Autotools is slow. It is so slow that it takes some of the joy out of
> hacking on the ndctl project. A fellow developer points out that QEMU
> has moved to meson, and systemd has moved as well. An initial conversion
> of ndctl to meson shows speed gains as large as an order of magnitude
> improvement, and that result motivates the formal patches below to
> complete the conversion.
>
> Given that this change breaks scripts built for automating the autotools
> style build, the old autotools environment is kept working until all the
> meson conversion bugs have been worked out, and downstream users have
> had a chance to adjust.
>
> Other immediate benefits beside build speed is a unit test execution
> harness with more capability and flexibility. It allows tests to be
> organized by category and has a framework to support timeout as a test
> failure.
>
> ---
>
> Dan Williams (6):
> util: Distribute 'filter' and 'json' helpers to per-tool objects
> Documentation: Drop attrs.adoc include
> build: Drop unnecessary $tool/config.h includes
> build: Explicitly include version.h
> test: Prepare out of line builds
> build: Add meson build infrastructure
>
With the patch-series got working builds for ndctl/daxctl on ppc64le using meson/ninja
Hence,
Tested-by: Vaibhav Jain <vaibhav@linux.ibm.com>
>
> .gitignore | 5
> Documentation/cxl/meson.build | 82 +
> Documentation/daxctl/meson.build | 88 +
> Documentation/ndctl/Makefile.am | 11
> Documentation/ndctl/intel-nvdimm-security.txt | 2
> Documentation/ndctl/meson.build | 124 ++
> Documentation/ndctl/ndctl-load-keys.txt | 2
> Documentation/ndctl/ndctl-monitor.txt | 5
> Documentation/ndctl/ndctl-sanitize-dimm.txt | 2
> Documentation/ndctl/ndctl-setup-passphrase.txt | 2
> Documentation/ndctl/ndctl-update-passphrase.txt | 2
> Makefile.am | 1
> Makefile.am.in | 3
> clean_config.sh | 2
> config.h.meson | 149 +++
> cxl/Makefile.am | 3
> cxl/cxl.c | 1
> cxl/filter.c | 25
> cxl/filter.h | 7
> cxl/json.c | 34 +
> cxl/json.h | 8
> cxl/lib/meson.build | 24
> cxl/list.c | 5
> cxl/memdev.c | 3
> cxl/meson.build | 23
> daxctl/Makefile.am | 5
> daxctl/daxctl.c | 1
> daxctl/device.c | 4
> daxctl/filter.c | 43 +
> daxctl/filter.h | 12
> daxctl/json.c | 251 ++++
> daxctl/json.h | 18
> daxctl/lib/meson.build | 32 +
> daxctl/list.c | 5
> daxctl/meson.build | 25
> daxctl/migrate.c | 1
> meson.build | 237 ++++
> meson_options.txt | 17
> ndctl/Makefile.am | 16
> ndctl/bus.c | 4
> ndctl/dimm.c | 6
> ndctl/filter.c | 60 -
> ndctl/filter.h | 12
> ndctl/inject-error.c | 4
> ndctl/inject-smart.c | 4
> ndctl/json-smart.c | 3
> ndctl/json.c | 1114 +++++++++++++++++++
> ndctl/json.h | 24
> ndctl/keys.c | 4
> ndctl/keys.h | 0
> ndctl/lib/libndctl.c | 2
> ndctl/lib/meson.build | 38 +
> ndctl/lib/papr.c | 4
> ndctl/lib/private.h | 4
> ndctl/list.c | 6
> ndctl/load-keys.c | 5
> ndctl/meson.build | 70 +
> ndctl/monitor.c | 6
> ndctl/namespace.c | 4
> ndctl/ndctl.c | 1
> ndctl/region.c | 3
> test/Makefile.am | 27
> test/ack-shutdown-count-set.c | 2
> test/btt-errors.sh | 4
> test/common | 37 -
> test/dax-pmd.c | 7
> test/dax.sh | 6
> test/daxdev-errors.c | 2
> test/daxdev-errors.sh | 4
> test/device-dax-fio.sh | 2
> test/device-dax.c | 2
> test/dm.sh | 4
> test/dpa-alloc.c | 2
> test/dsm-fail.c | 4
> test/inject-smart.sh | 2
> test/libndctl.c | 2
> test/list-smart-dimm.c | 7
> test/meson.build | 267 +++++
> test/mmap.sh | 6
> test/monitor.sh | 6
> test/multi-pmem.c | 4
> test/pmem-errors.sh | 8
> test/revoke-devmem.c | 2
> test/sub-section.sh | 4
> test/track-uuid.sh | 2
> tools/meson-vcs-tag.sh | 17
> util/help.c | 2
> util/json.c | 1363 -----------------------
> util/json.h | 39 -
> util/meson.build | 15
> version.h.in | 2
> 91 files changed, 2919 insertions(+), 1590 deletions(-)
> create mode 100644 Documentation/cxl/meson.build
> create mode 100644 Documentation/daxctl/meson.build
> create mode 100644 Documentation/ndctl/meson.build
> create mode 100755 clean_config.sh
> create mode 100644 config.h.meson
> create mode 100644 cxl/filter.c
> create mode 100644 cxl/filter.h
> create mode 100644 cxl/json.c
> create mode 100644 cxl/json.h
> create mode 100644 cxl/lib/meson.build
> create mode 100644 cxl/meson.build
> create mode 100644 daxctl/filter.c
> create mode 100644 daxctl/filter.h
> create mode 100644 daxctl/json.c
> create mode 100644 daxctl/json.h
> create mode 100644 daxctl/lib/meson.build
> create mode 100644 daxctl/meson.build
> create mode 100644 meson.build
> create mode 100644 meson_options.txt
> rename util/filter.c => ndctl/filter.c (88%)
> rename util/filter.h => ndctl/filter.h (89%)
> rename ndctl/{util/json-smart.c => json-smart.c} (99%)
> create mode 100644 ndctl/json.c
> create mode 100644 ndctl/json.h
> rename ndctl/{util/keys.c => keys.c} (99%)
> rename ndctl/{util/keys.h => keys.h} (100%)
> create mode 100644 ndctl/lib/meson.build
> create mode 100644 ndctl/meson.build
> create mode 100644 test/meson.build
> create mode 100755 tools/meson-vcs-tag.sh
> create mode 100644 util/meson.build
> create mode 100644 version.h.in
>
> base-commit: 5884f09e488748dad8fea660fd80044b06609f26
>
--
Cheers
~ Vaibhav
next prev parent reply other threads:[~2021-07-14 18:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 19:52 [ndctl PATCH 0/6] Convert to the Meson build system Dan Williams
2021-07-09 19:52 ` [ndctl PATCH 2/6] Documentation: Drop attrs.adoc include Dan Williams
2021-07-09 19:52 ` [ndctl PATCH 3/6] build: Drop unnecessary $tool/config.h includes Dan Williams
2021-07-09 19:53 ` [ndctl PATCH 4/6] build: Explicitly include version.h Dan Williams
2021-07-09 19:53 ` [ndctl PATCH 5/6] test: Prepare out of line builds Dan Williams
2021-07-09 19:53 ` [ndctl PATCH 6/6] build: Add meson build infrastructure Dan Williams
2021-07-14 18:46 ` Vaibhav Jain [this message]
2021-07-14 18:53 ` [ndctl PATCH 0/6] Convert to the Meson build system Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtqo68e4.fsf@vajain21.in.ibm.com \
--to=vaibhav@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).