From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E07BC07E9A for ; Wed, 14 Jul 2021 08:44:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 46CFE613B2 for ; Wed, 14 Jul 2021 08:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238671AbhGNIrN convert rfc822-to-8bit (ORCPT ); Wed, 14 Jul 2021 04:47:13 -0400 Received: from mail-ua1-f46.google.com ([209.85.222.46]:34628 "EHLO mail-ua1-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238628AbhGNIrL (ORCPT ); Wed, 14 Jul 2021 04:47:11 -0400 Received: by mail-ua1-f46.google.com with SMTP id s13so354504uao.1; Wed, 14 Jul 2021 01:44:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=r5k/nzvm++7I0kjlsxJbLPoLxldn2GkCJzAXrc4Q3tE=; b=HYt7OhlyET59fENYKovpSBxCiijoiIfp5U60wYyF5ej4/UeoD4xedkgIaeL3k7LJVH TFze34BROVl/KqQ3w4nOvT/eOaJmDh76UNAOdy0C9f1/iPJ2qoKaiU+FtqK5Qm7bNfFy 5Jk+Y1W+duADFwm4YoWkJOtejE+Vpnti5lX2qEm5lw2Kbs583dGx5CHcs6i13RnIavhI cKdHiytSHoEWOGUdyv5Bz7FQchQx3Hqe0uBmn2LxnTS9mLHIECd0WOotulSh0J5Xv6DC DLtXPtgD396qs2ITEF0XmaeW9vtjmgzRpce2p0L2jWP7PQl6hIoMf5mGaR+nqm4aBa1s z+Hw== X-Gm-Message-State: AOAM530Zu8yDBrP+j3r5+DR4jetcwqgK5OwAdfqEjH0b/Pc9esWnl1vj xEFUtJ5uYfxtLQwC4wcSCbbCm5TzvJ6wFLFuh6k= X-Google-Smtp-Source: ABdhPJw+Y3tnjfY/zI+Y1qOhR0PNRzn2MQD3PHuwf/AzIRJfXjUIjP825Ll9FtnbmVsf04QAqWLG0Tq2dErAW2+m0rM= X-Received: by 2002:a9f:3f0d:: with SMTP id h13mr12412958uaj.100.1626252258156; Wed, 14 Jul 2021 01:44:18 -0700 (PDT) MIME-Version: 1.0 References: <20210713193522.1770306-1-u.kleine-koenig@pengutronix.de> <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> In-Reply-To: <20210713193522.1770306-6-u.kleine-koenig@pengutronix.de> From: Geert Uytterhoeven Date: Wed, 14 Jul 2021 10:44:06 +0200 Message-ID: Subject: Re: [PATCH v4 5/5] bus: Make remove callback return void To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: Greg Kroah-Hartman , Sascha Hauer , Alexander Shishkin , Alexandre Belloni , Alexandre Bounine , Alex Dubov , Alex Elder , Alex Williamson , Alison Schofield , Allen Hubbe , Andreas Noever , Andy Gross , Arnd Bergmann , Benjamin Herrenschmidt , Benjamin Tissoires , Ben Widawsky , Bjorn Andersson , Bjorn Helgaas , Bodo Stroesser , Boris Ostrovsky , Chen-Yu Tsai , Christian Borntraeger , Cornelia Huck , Cristian Marussi , Dan Williams , Dave Jiang , "David S. Miller" , David Woodhouse , Dexuan Cui , Dmitry Torokhov , Dominik Brodowski , Finn Thain , Florian Fainelli , Frank Li , Geoff Levand , Haiyang Zhang , Hannes Reinecke , Hans de Goede , Harald Freudenberger , Heikki Krogerus , Heiko Carstens , Helge Deller , Ira Weiny , Jakub Kicinski , "James E.J. Bottomley" , Jaroslav Kysela , Jason Wang , Jens Taprogge , Jernej Skrabec , Jiri Kosina , Jiri Slaby , Joey Pabalan , Johan Hovold , Johannes Berg , Johannes Thumshirn , Jon Mason , Juergen Gross , Julien Grall , Kai-Heng Feng , Kirti Wankhede , Kishon Vijay Abraham I , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , "K. Y. Srinivasan" , Lee Jones , Len Brown , Lorenzo Pieralisi , Manohar Vanga , Marc Zyngier , Mark Brown , Mark Gross , "Martin K. Petersen" , Martyn Welch , Mathieu Poirier , Matt Porter , Mauro Carvalho Chehab , Maxime Ripard , Maximilian Luz , Maxim Levitsky , Michael Buesch , Michael Ellerman , Michael Jamet , "Michael S. Tsirkin" , Mika Westerberg , Mike Christie , Moritz Fischer , Ohad Ben-Cohen , =?UTF-8?Q?Pali_Roh=C3=A1r?= , Paul Mackerras , Peter Oberparleiter , "Rafael J. Wysocki" , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Rich Felker , Rikard Falkeborn , Rob Herring , Russell King , "Russell King (Oracle)" , Samuel Holland , Samuel Iglesias Gonsalvez , SeongJae Park , Srinivas Kandagatla , Srinivas Pandruvada , Stefano Stabellini , Stefan Richter , Stephen Boyd , Stephen Hemminger , Sudeep Holla , Sven Van Asbroeck , Takashi Iwai , Thomas Bogendoerfer , Thorsten Scherer , Tomas Winkler , Tom Rix , Tyrel Datwyler , Ulf Hansson , Vasily Gorbik , Vineeth Vijayan , Vinod Koul , Vishal Verma , Wei Liu , William Breathitt Gray , Wolfram Sang , Wu Hao , Yehezkel Bernat , Yoshinori Sato , YueHaibing , Yufen Yu , alsa-devel@alsa-project.org, dmaengine@vger.kernel.org, greybus-dev@lists.linaro.org, industrypack-devel@lists.sourceforge.net, kvm@vger.kernel.org, linux1394-devel@lists.sourceforge.net, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-cxl@vger.kernel.org, linux-fpga@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-i2c@vger.kernel.org, linux-i3c@lists.infradead.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-media@vger.kernel.org, linux-mips@vger.kernel.org, linux-mmc@vger.kernel.org, linux-ntb@googlegroups.com, linux-parisc@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-serial@vger.kernel.org, linux-sh@vger.kernel.org, linux-spi@vger.kernel.org, linux-staging@lists.linux.dev, linux-sunxi@lists.linux.dev, linux-usb@vger.kernel.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, nvdimm@lists.linux.dev, platform-driver-x86@vger.kernel.org, sparclinux@vger.kernel.org, target-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, xen-devel@lists.xenproject.org, Johannes Thumshirn , "Rafael J . Wysocki" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org On Tue, Jul 13, 2021 at 9:35 PM Uwe Kleine-König wrote: > The driver core ignores the return value of this callback because there > is only little it can do when a device disappears. > > This is the final bit of a long lasting cleanup quest where several > buses were converted to also return void from their remove callback. > Additionally some resource leaks were fixed that were caused by drivers > returning an error code in the expectation that the driver won't go > away. > > With struct bus_type::remove returning void it's prevented that newly > implemented buses return an ignored error code and so don't anticipate > wrong expectations for driver authors. > drivers/zorro/zorro-driver.c | 3 +-- Acked-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds