From: "Verma, Vishal L" <vishal.l.verma@intel.com>
To: "Williams, Dan J" <dan.j.williams@intel.com>,
"linux-cxl@vger.kernel.org" <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 2/5] cxl/region: Delete 'region' attribute from root decoders
Date: Mon, 1 Aug 2022 19:40:11 +0000 [thread overview]
Message-ID: <d0c2044b096d8a79c98501a5178cc9b7dca422ea.camel@intel.com> (raw)
In-Reply-To: <919eb8198e880205b81da7090d6f0535782f0fad.camel@intel.com>
On Mon, 2022-08-01 at 19:38 +0000, Verma, Vishal L wrote:
> On Fri, 2022-07-22 at 17:56 -0700, Dan Williams wrote:
> > For switch and endpoint decoders the relationship of decoders to
> > regions
> > is 1:1. However, for root decoders the relationship is 1:N. Also,
> > regions are already children of root decoders, so the 1:N
> > relationship
> > is observed by walking the following glob:
> >
> > /sys/bus/cxl/devices/$decoder/region*
> >
> > Hide the vestigial 'region' attribute for root decoders.
> >
> > Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> > ---
> > drivers/cxl/core/port.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c
> > index 3d2d0119cc3d..bffde862de0b 100644
> > --- a/drivers/cxl/core/port.c
> > +++ b/drivers/cxl/core/port.c
> > @@ -290,7 +290,6 @@ static struct attribute *cxl_decoder_base_attrs[]
> > = {
> > &dev_attr_locked.attr,
> > &dev_attr_interleave_granularity.attr,
> > &dev_attr_interleave_ways.attr,
> > - SET_CXL_REGION_ATTR(region)
> > NULL,
> > };
> >
> > @@ -345,6 +344,7 @@ static const struct attribute_group
> > *cxl_decoder_root_attribute_groups[] = {
> > static struct attribute *cxl_decoder_switch_attrs[] = {
> > &dev_attr_target_type.attr,
> > &dev_attr_target_list.attr,
> > + SET_CXL_REGION_ATTR(region)
>
> This patch removes the 'region' attr from switch decoders, but isn't it
> also vestigial under root decoders?
Oh, never mind, I misread the patch - it adds it to switch and endpoint
decoders, removes from root.
Reviewed-by: Vishal Verma <vishal.l.verma@intel.com>
>
> > NULL,
> > };
> >
> > @@ -364,6 +364,7 @@ static struct attribute
> > *cxl_decoder_endpoint_attrs[] = {
> > &dev_attr_mode.attr,
> > &dev_attr_dpa_size.attr,
> > &dev_attr_dpa_resource.attr,
> > + SET_CXL_REGION_ATTR(region)
> > NULL,
> > };
> >
> >
>
next prev parent reply other threads:[~2022-08-01 19:40 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-23 0:55 [PATCH 0/5] CXL Region Provisioning Fixes Dan Williams
2022-07-23 0:55 ` [PATCH 1/5] cxl/acpi: Autoload driver for 'cxl_acpi' test devices Dan Williams
2022-08-01 19:24 ` Verma, Vishal L
2022-07-23 0:56 ` [PATCH 2/5] cxl/region: Delete 'region' attribute from root decoders Dan Williams
2022-08-01 19:32 ` Alison Schofield
2022-08-01 19:38 ` Verma, Vishal L
2022-08-01 19:40 ` Verma, Vishal L [this message]
2022-08-01 21:32 ` Dan Williams
2022-08-01 21:32 ` Dan Williams
2022-07-23 0:56 ` [PATCH 3/5] cxl/acpi: Minimize granularity for x1 interleaves Dan Williams
2022-08-01 19:35 ` Alison Schofield
2022-08-01 19:45 ` Verma, Vishal L
2022-08-01 21:34 ` Dan Williams
2022-08-02 15:56 ` Jonathan Cameron
2022-08-02 16:52 ` Jonathan Cameron
2022-08-02 17:33 ` Dan Williams
2022-08-03 16:00 ` Jonathan Cameron
2022-08-03 17:18 ` Dan Williams
2022-08-04 9:32 ` Jonathan Cameron
2022-07-23 0:56 ` [PATCH 4/5] cxl/region: Stop initializing interleave granularity Dan Williams
2022-08-01 19:41 ` Alison Schofield
2022-08-01 19:47 ` Verma, Vishal L
2022-07-23 0:56 ` [PATCH 5/5] cxl/region: Constrain region granularity scaling factor Dan Williams
2022-08-01 19:43 ` Alison Schofield
2022-08-01 20:55 ` Verma, Vishal L
2022-08-03 16:17 ` Jonathan Cameron
2022-08-04 16:33 ` Dan Williams
2022-08-04 17:57 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0c2044b096d8a79c98501a5178cc9b7dca422ea.camel@intel.com \
--to=vishal.l.verma@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).