From: Dave Jiang <dave.jiang@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, <nvdimm@lists.linux.dev>
Cc: <linux-cxl@vger.kernel.org>
Subject: Re: [PATCH 2/4] dax: Use device_unregister() in unregister_dax_mapping()
Date: Thu, 15 Jun 2023 10:34:34 -0700 [thread overview]
Message-ID: <d3d55ee0-53b3-3084-cf22-b64a59da65b3@intel.com> (raw)
In-Reply-To: <168577283989.1672036.7777592498865470652.stgit@dwillia2-xfh.jf.intel.com>
On 6/2/23 23:13, Dan Williams wrote:
> Replace an open-coded device_unregister() sequence with the helper.
>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> drivers/dax/bus.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c
> index aee695f86b44..c99ea08aafc3 100644
> --- a/drivers/dax/bus.c
> +++ b/drivers/dax/bus.c
> @@ -657,8 +657,7 @@ static void unregister_dax_mapping(void *data)
> dev_dax->ranges[mapping->range_id].mapping = NULL;
> mapping->range_id = -1;
>
> - device_del(dev);
> - put_device(dev);
> + device_unregister(dev);
> }
>
> static struct dev_dax_range *get_dax_range(struct device *dev)
>
>
next prev parent reply other threads:[~2023-06-15 17:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-03 6:13 [PATCH 0/4] dax: Fix use after free and other cleanups Dan Williams
2023-06-03 6:13 ` [PATCH 1/4] dax: Fix dax_mapping_release() use after free Dan Williams
2023-06-04 2:40 ` Ira Weiny
[not found] ` <CGME20230605204543uscas1p19d1b3a00134805c5c3e738dea4ee4728@uscas1p1.samsung.com>
2023-06-05 20:45 ` Fan Ni
2023-06-15 17:33 ` Dave Jiang
2023-06-03 6:13 ` [PATCH 2/4] dax: Use device_unregister() in unregister_dax_mapping() Dan Williams
2023-06-04 2:41 ` Ira Weiny
[not found] ` <CGME20230605204615uscas1p1931142de4b55be03c99f513b51dcb2fc@uscas1p1.samsung.com>
2023-06-05 20:46 ` Fan Ni
2023-06-15 17:34 ` Dave Jiang [this message]
2023-06-03 6:14 ` [PATCH 3/4] dax: Introduce alloc_dev_dax_id() Dan Williams
2023-06-04 2:57 ` Ira Weiny
2023-06-16 1:22 ` Dan Williams
2023-06-16 22:11 ` Ira Weiny
2023-06-03 6:14 ` [PATCH 4/4] dax: Cleanup extra dax_region references Dan Williams
2023-06-04 2:58 ` Ira Weiny
2023-06-06 17:46 ` Fan Ni
2023-06-06 20:42 ` Ira Weiny
2023-06-15 17:45 ` Dave Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d55ee0-53b3-3084-cf22-b64a59da65b3@intel.com \
--to=dave.jiang@intel.com \
--cc=dan.j.williams@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).