From: Nick Kossifidis <mick@ics.forth.gr>
To: Palmer Dabbelt <palmer@dabbelt.com>
Cc: robh+dt@kernel.org, mick@ics.forth.gr, geert@linux-m68k.org,
Paul Walmsley <paul.walmsley@sifive.com>,
aou@eecs.berkeley.edu, frowand.list@gmail.com,
catalin.marinas@arm.com, will@kernel.org,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling
Date: Fri, 02 Jul 2021 18:56:55 +0300 [thread overview]
Message-ID: <008ddfd79d256dcddd7c802e4eef6b5a@mailhost.ics.forth.gr> (raw)
In-Reply-To: <mhng-6db38728-4f82-45bd-9b17-c41da55c41e9@palmerdabbelt-glaptop>
Στις 2021-07-01 05:52, Palmer Dabbelt έγραψε:
> On Wed, 16 Jun 2021 07:47:46 PDT (-0700), robh+dt@kernel.org wrote:
>> On Wed, Jun 16, 2021 at 4:43 AM Nick Kossifidis <mick@ics.forth.gr>
>> wrote:
>>>
>>> Στις 2021-06-16 10:56, Geert Uytterhoeven έγραψε:
>>> >
>>> > I can't comment on the duplication on arm64, but to me, /chosen
>>> > sounds like the natural place for both "linux,elfcorehdr" and
>>> > "linux,usable-memory-range". First rule of DT is "DT describes
>>> > hardware, not software policy", with /chosen describing some software
>>> > configuration.
>>> >
>>>
>>> We already have "linux,usable-memory" on /memory node:
>>> https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
>>> and it makes perfect sense to be there since it overrides /memory's
>>> reg
>>> property.
>>>
>>> Why define another binding for the same thing on /chosen ?
>>
>> Go look at the thread adding "linux,usable-memory-range". There were
>> only 35 versions of it[1]. I wasn't happy with a 2nd way either, but
>> as I've mentioned before we don't always have /memory node.
>
> I don't really understand what's going on here, but IIUC what I merged
> in 5.13 doesn't match the behavior that other architectures have. In
> that case I'm happy moving RISC-V over to the more standard way of
> doing things and just calling what we have in 5.13 a screwup.
>
> Sorry for the confusion.
Long story short:
a) We use "linux,usable-memory" on /memory node to limit the memory of
the kdump kernel, it's a standard binding defined at:
https://elixir.bootlin.com/linux/v5.13-rc6/source/drivers/of/fdt.c#L1011
b) We used a reserved region (again a standard binding) named
"linux,elfcorehdr" which has the same name as a property on /chosen used
by arm64 for the same thing. With this patch we 'll use arm64's
approach, although it's a bit worse since we'll need to add the same
region twice on the fdt (once in /chosen as a property and another one
in the reservation map so that it gets reserved during early boot).
Fortunately I (still) haven't posted the kexec-tools patches on the
mailing list so we don't break userspace by doing this.
next prev parent reply other threads:[~2021-07-02 15:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 18:17 [PATCH 0/3] Add generic-support for linux,elfcorehdr and fix riscv Geert Uytterhoeven
2021-06-15 18:17 ` [PATCH 1/3] of: fdt: Add generic support for parsing elf core header properties Geert Uytterhoeven
2021-06-15 19:54 ` Rob Herring
2021-06-15 23:28 ` Nick Kossifidis
2021-06-16 7:58 ` Geert Uytterhoeven
2021-06-15 18:17 ` [PATCH 2/3] riscv: Remove non-standard linux,elfcorehdr handling Geert Uytterhoeven
2021-06-15 18:40 ` Nick Kossifidis
2021-06-15 19:54 ` Rob Herring
2021-06-15 23:19 ` Nick Kossifidis
2021-06-16 7:56 ` Geert Uytterhoeven
2021-06-16 10:43 ` Nick Kossifidis
2021-06-16 14:47 ` Rob Herring
2021-07-01 2:52 ` Palmer Dabbelt
2021-07-02 15:56 ` Nick Kossifidis [this message]
2021-06-15 18:17 ` [PATCH 3/3] arm64: kdump: Remove custom linux,elfcorehdr parsing Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=008ddfd79d256dcddd7c802e4eef6b5a@mailhost.ics.forth.gr \
--to=mick@ics.forth.gr \
--cc=aou@eecs.berkeley.edu \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert@linux-m68k.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).