From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B85C43141 for ; Wed, 20 Nov 2019 15:41:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 680F520709 for ; Wed, 20 Nov 2019 15:41:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="W8kQw5Ti"; dkim=pass (1024-bit key) header.d=akkea.ca header.i=@akkea.ca header.b="mwzIUaLo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732066AbfKTPlP (ORCPT ); Wed, 20 Nov 2019 10:41:15 -0500 Received: from node.akkea.ca ([192.155.83.177]:56262 "EHLO node.akkea.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731906AbfKTPlI (ORCPT ); Wed, 20 Nov 2019 10:41:08 -0500 Received: from localhost (localhost [127.0.0.1]) by node.akkea.ca (Postfix) with ESMTP id A14614E200E; Wed, 20 Nov 2019 15:41:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1574264467; bh=c1bwvGZ3DtvSeRPrVEI/eLrZgFbhGdVgFlrw3H+Ljmg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=W8kQw5TiUDaohToYRNY47L6bmIwZ1V9gB2GsTL8ZcnBCvzYIuFzBsu+ZWC1RTl495 tg8GMEM99IGqVzCmA4BeIqefw7g9e3VbBVJXEmkeJ/3TNBQcU7FPDLD6pd6c8ywVaH KwtpqvqJvQZgB3SVwvpxgvnc2Nl3VhGbNm6NOG3g= X-Virus-Scanned: Debian amavisd-new at mail.akkea.ca Received: from node.akkea.ca ([127.0.0.1]) by localhost (mail.akkea.ca [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bzL7GrYHn4P7; Wed, 20 Nov 2019 15:41:06 +0000 (UTC) Received: from www.akkea.ca (node.akkea.ca [192.155.83.177]) by node.akkea.ca (Postfix) with ESMTPSA id 7E7C64E2003; Wed, 20 Nov 2019 15:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akkea.ca; s=mail; t=1574264466; bh=c1bwvGZ3DtvSeRPrVEI/eLrZgFbhGdVgFlrw3H+Ljmg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=mwzIUaLoFOmzPRRwdy6cZm1S1cVC3dxyuglKyfH2imk2OPl2aFZgClNXZ2MoQsSd5 5zvMyZw2rWcC0Beme8vIYyQW/vw+JDYhY4bDgw/OMjbULDuW7HH1JjI/W6X0x/Rryn S3ySlOmYGvbtcHZ+5OWyQotpdiB131AG7YWtTqDw= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Nov 2019 07:41:06 -0800 From: Angus Ainslie To: Leonard Crestez Cc: Jacky Bai , Georgi Djakov , Rob Herring , Chanwoo Choi , =?UTF-8?Q?Artur_=C5=9Awigo=C5=84?= , Alexandre Bailon , "Rafael J. Wysocki" , Anson Huang , Abel Vesa , Krzysztof Kozlowski , MyungJoo Ham , Kyungmin Park , Saravana Kannan , Mark Rutland , Viresh Kumar , Shawn Guo , Aisheng Dong , Fabio Estevam , Stephen Boyd , Michael Turquette , Matthias Kaehlcke , Martin Kepplinger , Silvano Di Ninno , linux-pm@vger.kernel.org, kernel@pengutronix.de, dl-linux-imx , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm-owner@vger.kernel.org Subject: Re: [PATCH RFC v6 2/9] PM / devfreq: Add generic imx bus scaling driver In-Reply-To: References: Message-ID: <008f2fa973b23fc716d678c5bd35af54@akkea.ca> X-Sender: angus@akkea.ca User-Agent: Roundcube Webmail/1.3.6 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Leonard, On 2019-11-20 07:04, Leonard Crestez wrote: > On 20.11.2019 16:08, Angus Ainslie wrote: >> Hi Leonard, >> >> On 2019-11-14 12:09, Leonard Crestez wrote: >>> Add initial support for dynamic frequency switching on pieces of the >>> imx >>> interconnect fabric. >>> >>> All this driver does is set a clk rate based on an opp table, it does >>> not map register areas. >>> >> >> Is this working with mainline ATF or does it still need to be used >> with >> your modified ATF code ? > > This series doesn't perform SMC calls, that's done by the imx8m-ddrc > driver: https://patchwork.kernel.org/cover/11244283/ > > This particular patch allows switching NOC frequency but that's just > clk_set_rate. > > DDRC frequency switching requires the imx branch of ATF (v2.0 + ~200 > patches) otherwise you will get probe failures. Source for imx atf is > published here: https://source.codeaurora.org/external/imx/imx-atf/ Ok I was under the impression that the imx_2.0.y_busfreq branch below was based on this. Shouldn't those patches be added to the imx ATF ? > > For your particular 8mq B0 case slightly different setpoints are used > and the fix is not in any public release yet so you need this: > > https://github.com/cdleonard/arm-trusted-firmware/commits/imx_2.0.y_busfreq > We also have 2n14w ( is that B1 ? ) imx8mq's that we are working with. > Is "mainline ATF" an important criteria for Purism? > Yes we intend to bring all of our patches to mainline and were hoping that NXP would be doing the same. Shouldn't a mainline kernel run on a mainline ATF ? Thanks Angus > -- > Regards, > Leonard