From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7355FC43215 for ; Tue, 19 Nov 2019 12:28:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4AE0F21850 for ; Tue, 19 Nov 2019 12:28:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="XlWppwGS"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="bUGAhwd9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727511AbfKSM2a (ORCPT ); Tue, 19 Nov 2019 07:28:30 -0500 Received: from a27-21.smtp-out.us-west-2.amazonses.com ([54.240.27.21]:51942 "EHLO a27-21.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726351AbfKSM2a (ORCPT ); Tue, 19 Nov 2019 07:28:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574166509; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID; bh=xoQLRZCLDsBMqnDsNRCUgvBqNo28d18ZvpB3a0moVPk=; b=XlWppwGSlVgsDXhMLFWelSGcZZqwH1eZVvLmNjOYn8GSRXHgssMMZqqBKjkf/m2V aRHkpoK9a7cgvptGG9xGSSpqPiyraQClf2/wTjk9zksR7iKIo45c2SCxIjXjQqg96KS wZ0/DcH1fS/np7x9GAmCRRvsw0MjZftQ9NQuY6Js= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574166509; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:Feedback-ID; bh=xoQLRZCLDsBMqnDsNRCUgvBqNo28d18ZvpB3a0moVPk=; b=bUGAhwd9fxN24fAxEZsp07uihoX6f2nlakFMkFA8ly6AEk717ruvEsOSvbwS0Gsg 5y8bJkfQVORK2YTR//hFvkLl8/r8rPtPUcaYtJuoK68K2Awtm9wNOXL5/Dqk0HyeB7o asdqALf5DQ7brSas5exF1PZvLaY0q789Ga24f17o= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 19 Nov 2019 12:28:29 +0000 From: sibis@codeaurora.org To: Jeffrey Hugo Cc: Bjorn Andersson , Jeffrey Hugo , Rob Herring , Jonathan Marek , Ohad Ben-Cohen , Mark Rutland , p.zabel@pengutronix.de, MSM , linux-remoteproc@vger.kernel.org, DTML , lkml , Andy Gross , linux-remoteproc-owner@vger.kernel.org Subject: Re: [PATCH 13/16] arm64: dts: qcom: msm8998: Update reserved memory map In-Reply-To: References: <20191118214250.14002-1-sibis@codeaurora.org> <0101016e807915dc-5f8701fd-5c4a-45a5-a9ee-9e4d8700a3fa-000000@us-west-2.amazonses.com> Message-ID: <0101016e83a2b64f-7d9f9170-7720-4198-adae-7f39a846c432-000000@us-west-2.amazonses.com> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-SES-Outgoing: 2019.11.19-54.240.27.21 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hey Jeff, Thanks for taking time to review the series. On 2019-11-19 03:34, Jeffrey Hugo wrote: > On Mon, Nov 18, 2019 at 2:45 PM Sibi Sankar > wrote: >> >> Update existing and add missing regions to the reserved memory map, as >> described in version 7.1 >> >> Signed-off-by: Sibi Sankar >> --- >> arch/arm64/boot/dts/qcom/msm8998.dtsi | 62 >> ++++++++++++++++++++++++--- >> 1 file changed, 55 insertions(+), 7 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi >> b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> index fc7838ea9a010..707673e3cf28a 100644 >> --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi >> +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi >> @@ -28,8 +28,13 @@ >> #size-cells = <2>; >> ranges; >> >> - memory@85800000 { >> - reg = <0x0 0x85800000 0x0 0x800000>; >> + hyp_mem: memory@85800000 { >> + reg = <0x0 0x85800000 0x0 0x600000>; >> + no-map; >> + }; >> + >> + xbl_mem: memory@85e00000 { > > Are we ever going to use this label? just leaving it here for info with the added benefit of being deleteable if MSM8998 uses a different boot chain where xbl_mem/tz_mem remains unused as in the case of Cheza > >> + reg = <0x0 0x85e00000 0x0 0x100000>; >> no-map; >> }; >> >> @@ -38,21 +43,64 @@ >> no-map; >> }; >> >> - memory@86200000 { >> + tz_mem: memory@86200000 { > > Again, are we ever going to use this? ditto > >> reg = <0x0 0x86200000 0x0 0x2d00000>; >> no-map; >> }; >> >> - rmtfs { >> + rmtfs_mem: memory@88f00000 { >> compatible = "qcom,rmtfs-mem"; >> - >> - size = <0x0 0x200000>; >> - alloc-ranges = <0x0 0xa0000000 0x0 0x2000000>; >> + reg = <0x0 0x88f00000 0x0 0x200000>; > > This seems to overlap with a defined region in the memory map. > 0x9fa00000 seems to be a better address. just following the what we did for SDM845 SoC 0x88f00000 should be safe to use. > >> no-map; >> >> qcom,client-id = <1>; >> qcom,vmid = <15>; >> }; >> + >> + spss_mem: memory@8ab00000 { >> + reg = <0x0 0x8ab00000 0x0 0x700000>; >> + no-map; >> + }; >> + >> + adsp_mem: memory@8b200000 { >> + reg = <0x0 0x8b200000 0x0 0x1a00000>; >> + no-map; >> + }; >> + >> + mpss_mem: memory@8cc00000 { >> + reg = <0x0 0x8cc00000 0x0 0x7000000>; >> + no-map; >> + }; >> + >> + venus_mem: memory@93c00000 { >> + reg = <0x0 0x93c00000 0x0 0x500000>; >> + no-map; >> + }; >> + >> + mba_mem: memory@94100000 { >> + reg = <0x0 0x94100000 0x0 0x200000>; >> + no-map; >> + }; >> + >> + slpi_mem: memory@94300000 { >> + reg = <0x0 0x94300000 0x0 0xf00000>; >> + no-map; >> + }; >> + >> + ipa_fw_mem: memory@95200000 { >> + reg = <0x0 0x95200000 0x0 0x10000>; >> + no-map; >> + }; >> + >> + ipa_gsi_mem: memory@95210000 { >> + reg = <0x0 0x95210000 0x0 0x5000>; >> + no-map; >> + }; >> + >> + gpu_mem: memory@95215000 { >> + reg = <0x0 0x95215000 0x0 0x1000>; > > This is the wrong size for the zap region. double checked the memory maps, gpu mem size is mentioned as 4kb is that not the case? > >> + no-map; >> + }; >> }; >> >> clocks { >> -- >> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora >> Forum, >> a Linux Foundation Collaborative Project >>