From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2630CC432C0 for ; Wed, 20 Nov 2019 12:15:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF9F4224EB for ; Wed, 20 Nov 2019 12:15:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="WsfGGTl+"; dkim=pass (1024-bit key) header.d=amazonses.com header.i=@amazonses.com header.b="PqFg4S1A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729349AbfKTMP2 (ORCPT ); Wed, 20 Nov 2019 07:15:28 -0500 Received: from a27-10.smtp-out.us-west-2.amazonses.com ([54.240.27.10]:56696 "EHLO a27-10.smtp-out.us-west-2.amazonses.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbfKTMP2 (ORCPT ); Wed, 20 Nov 2019 07:15:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=zsmsymrwgfyinv5wlfyidntwsjeeldzt; d=codeaurora.org; t=1574252127; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID; bh=NDEjL4/TPABq9RymuBjDG4wAM9FaiIayYYuZaqd9RkU=; b=WsfGGTl+lYETGyzXW2+DCnxJ3SqFfA0U8NlSXgpdqo4j/TxdQFzgfQWhSUMhf7t9 S9GIxbObz746F0xND2HOBd4KPH98W/dUNTyKC2x7Tnhsqai6z8J8z1QHlGN5jQXDkYp loTlwEGNJBHSHfb1e6ClKgDfRa8N4pxFNiErpVE0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=gdwg2y3kokkkj5a55z2ilkup5wp5hhxx; d=amazonses.com; t=1574252127; h=MIME-Version:Content-Type:Content-Transfer-Encoding:Date:From:To:Cc:Subject:In-Reply-To:References:Message-ID:Feedback-ID; bh=NDEjL4/TPABq9RymuBjDG4wAM9FaiIayYYuZaqd9RkU=; b=PqFg4S1Aei8A0lH1P4cTn2HowwkuJZSUgJNgaAT6X/Nfq+ykc5Cev/JmsNHuyw0L ukTBkW0ahUrW0FQvjS4N922Wa24+/BEAHJ24/NgRkNdFjTWUVqT/b1HLN2ayUaOJ1Uf I0UjA577d6Yg2adjQJiMqDKtlVrsqpRjEGS0mUg0= MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 20 Nov 2019 12:15:27 +0000 From: Sibi Sankar To: Rajendra Nayak Cc: bjorn.andersson@linaro.org, robh+dt@kernel.org, ulf.hansson@linaro.org, agross@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, mark.rutland@arm.com, swboyd@chromium.org, dianders@chromium.org Subject: Re: [PATCH 2/6] dt-bindings: power: Add rpmh power-domain bindings for SM8150 In-Reply-To: <9eb5e99f-836b-01a6-8b5c-d1fffd1a482b@codeaurora.org> References: <20191118173944.27043-1-sibis@codeaurora.org> <0101016e7f99a91d-6632f420-b2f2-4b71-9c97-a3974fcb8fa9-000000@us-west-2.amazonses.com> <9eb5e99f-836b-01a6-8b5c-d1fffd1a482b@codeaurora.org> Message-ID: <0101016e88bd2571-928d6d73-00f0-433d-8baf-b288f27520a9-000000@us-west-2.amazonses.com> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-SES-Outgoing: 2019.11.20-54.240.27.10 Feedback-ID: 1.us-west-2.CZuq2qbDmUIuT3qdvXlRHZZCpfZqZ4GtG9v3VKgRyF0=:AmazonSES Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2019-11-20 09:27, Rajendra Nayak wrote: > On 11/18/2019 11:10 PM, Sibi Sankar wrote: >> Add RPMH power-domain bindings for the SM8150 family of SoCs. >> >> Signed-off-by: Sibi Sankar >> --- >> .../devicetree/bindings/power/qcom,rpmpd.txt | 1 + >> include/dt-bindings/power/qcom-rpmpd.h | 14 >> ++++++++++++++ >> 2 files changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> index bc75bf49cdaea..f3bbaa4aef297 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.txt >> @@ -10,6 +10,7 @@ Required Properties: >> * qcom,msm8998-rpmpd: RPM Power domain for the msm8998 family of >> SoC >> * qcom,qcs404-rpmpd: RPM Power domain for the qcs404 family of SoC >> * qcom,sdm845-rpmhpd: RPMh Power domain for the sdm845 family of >> SoC >> + * qcom,sm8150-rpmhpd: RPMh Power domain for the sm8150 family of SoC >> - #power-domain-cells: number of cells in Power domain specifier >> must be 1. >> - operating-points-v2: Phandle to the OPP table for the Power >> domain. >> diff --git a/include/dt-bindings/power/qcom-rpmpd.h >> b/include/dt-bindings/power/qcom-rpmpd.h >> index f05f8b1808ec9..7d43bafc0026b 100644 >> --- a/include/dt-bindings/power/qcom-rpmpd.h >> +++ b/include/dt-bindings/power/qcom-rpmpd.h >> @@ -15,12 +15,26 @@ >> #define SDM845_GFX 7 >> #define SDM845_MSS 8 >> +/* SM8150 Power Domain Indexes */ >> +#define SM8150_MSS 0 >> +#define SM8150_EBI 1 >> +#define SM8150_LMX 2 >> +#define SM8150_LCX 3 >> +#define SM8150_GFX 4 >> +#define SM8150_MX 5 >> +#define SM8150_MX_AO 6 >> +#define SM8150_CX 7 >> +#define SM8150_CX_AO 8 >> +#define SM8150_MMCX 9 >> +#define SM8150_MMCX_AO 10 >> + >> /* SDM845 Power Domain performance levels */ > > You could perhaps remove this comment, or remove the > SDM845 from it. yes will remove it > > Reviewed-by: Rajendra Nayak > >> #define RPMH_REGULATOR_LEVEL_RETENTION 16 >> #define RPMH_REGULATOR_LEVEL_MIN_SVS 48 >> #define RPMH_REGULATOR_LEVEL_LOW_SVS 64 >> #define RPMH_REGULATOR_LEVEL_SVS 128 >> #define RPMH_REGULATOR_LEVEL_SVS_L1 192 >> +#define RPMH_REGULATOR_LEVEL_SVS_L2 224 >> #define RPMH_REGULATOR_LEVEL_NOM 256 >> #define RPMH_REGULATOR_LEVEL_NOM_L1 320 >> #define RPMH_REGULATOR_LEVEL_NOM_L2 336 >> -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.