devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <ilialin@codeaurora.org>
To: 'Viresh Kumar' <viresh.kumar@linaro.org>,
	'Amit Kucheria' <amit.kucheria@linaro.org>
Cc: 'Michael Turquette' <mturquette@baylibre.com>,
	sboyd@kernel.org, 'Rob Herring' <robh@kernel.org>,
	'Mark Rutland' <mark.rutland@arm.com>,
	nm@ti.com, lgirdwood@gmail.com, broonie@kernel.org,
	'Andy Gross' <andy.gross@linaro.org>,
	'David Brown' <david.brown@linaro.org>,
	catalin.marinas@arm.com, will.deacon@arm.com,
	"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
	linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	'LKML' <linux-kernel@vger.kernel.org>,
	'Linux PM list' <linux-pm@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
	'lakml' <linux-arm-kernel@lists.infradead.org>,
	'Rajendra Nayak' <rnayak@codeaurora.org>,
	nicolas.dechesne@linaro.org, celster@codeaurora.org,
	tfinkel@codeaurora.org
Subject: RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver
Date: Thu, 17 May 2018 11:20:24 +0300	[thread overview]
Message-ID: <017f01d3edb7$ec160320$c4420960$@codeaurora.org> (raw)
In-Reply-To: 



> -----Original Message-----
> From: ilialin@codeaurora.org <ilialin@codeaurora.org>
> Sent: Thursday, May 17, 2018 10:51
> To: 'Viresh Kumar' <viresh.kumar@linaro.org>; 'Amit Kucheria'
> <amit.kucheria@linaro.org>
> Cc: 'Michael Turquette' <mturquette@baylibre.com>; 'sboyd@kernel.org'
> <sboyd@kernel.org>; 'Rob Herring' <robh@kernel.org>; 'Mark Rutland'
> <mark.rutland@arm.com>; 'nm@ti.com' <nm@ti.com>;
> 'lgirdwood@gmail.com' <lgirdwood@gmail.com>; 'broonie@kernel.org'
> <broonie@kernel.org>; 'Andy Gross' <andy.gross@linaro.org>; 'David Brown'
> <david.brown@linaro.org>; 'catalin.marinas@arm.com'
> <catalin.marinas@arm.com>; 'will.deacon@arm.com'
> <will.deacon@arm.com>; 'Rafael J. Wysocki' <rjw@rjwysocki.net>; 'linux-
> clk@vger.kernel.org' <linux-clk@vger.kernel.org>;
> 'devicetree@vger.kernel.org' <devicetree@vger.kernel.org>; 'LKML' <linux-
> kernel@vger.kernel.org>; 'Linux PM list' <linux-pm@vger.kernel.org>;
'linux-
> arm-msm@vger.kernel.org' <linux-arm-msm@vger.kernel.org>; 'linux-
> soc@vger.kernel.org' <linux-soc@vger.kernel.org>; 'lakml' <linux-arm-
> kernel@lists.infradead.org>; 'Rajendra Nayak' <rnayak@codeaurora.org>;
> 'nicolas.dechesne@linaro.org' <nicolas.dechesne@linaro.org>;
> 'celster@codeaurora.org' <celster@codeaurora.org>;
> 'tfinkel@codeaurora.org' <tfinkel@codeaurora.org>
> Subject: RE: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver
> 
> 
> 
> > -----Original Message-----
> > From: Viresh Kumar <viresh.kumar@linaro.org>
> > Sent: Wednesday, May 16, 2018 17:12
> > To: Amit Kucheria <amit.kucheria@linaro.org>
> > Cc: Ilia Lin <ilialin@codeaurora.org>; Michael Turquette
> > <mturquette@baylibre.com>; sboyd@kernel.org; Rob Herring
> > <robh@kernel.org>; Mark Rutland <mark.rutland@arm.com>; nm@ti.com;
> > lgirdwood@gmail.com; broonie@kernel.org; Andy Gross
> > <andy.gross@linaro.org>; David Brown <david.brown@linaro.org>;
> > catalin.marinas@arm.com; will.deacon@arm.com; Rafael J. Wysocki
> > <rjw@rjwysocki.net>; linux-clk@vger.kernel.org;
> > devicetree@vger.kernel.org; LKML <linux-kernel@vger.kernel.org>; Linux
> > PM list <linux-pm@vger.kernel.org>; linux-arm-msm@vger.kernel.org;
> > linux- soc@vger.kernel.org; lakml
> > <linux-arm-kernel@lists.infradead.org>;
> > Rajendra Nayak <rnayak@codeaurora.org>; nicolas.dechesne@linaro.org;
> > celster@codeaurora.org; tfinkel@codeaurora.org
> > Subject: Re: [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver
> >
> > On 16-05-18, 16:12, Amit Kucheria wrote:
> > > > +       ret = PTR_ERR_OR_ZERO(opp_temp =
> > > > +
> > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));
> > > > +       if (0 > ret)
> > >
> > > Any particular reason to prefer this over (ret < 0) that is
> > > generally used? I've seen it used to avoid the == vs. = typos, but
> > > not for other comparisons.
> > >
> > > Suggest sticking to what is commonly used i.e. ret < 0.
> > >
> > > > +               goto free_opp;
> > > > +
> > > > +       cpu_dev = get_cpu_device(GOLD_LEAD);
> > >
> > > Error check cpu_dev here?
> > >
> > > > +       ret = PTR_ERR_OR_ZERO(opp_temp =
> > > > +
> > dev_pm_opp_set_supported_hw(cpu_dev,&versions,1));
> > > > +       if (0 > ret)
> > > > +               goto free_opp;
> >
> > The goto here is wrong
> 
> If we are here, then the first dev_pm_opp_set_supported_hw() succeeded.
> And should be deallocated before exit with error.

My bad. Got you.

> 
> >
> > > > +
> > > > +
> > > > +       ret =
> > PTR_ERR_OR_ZERO(platform_device_register_simple("cpufreq-dt",
> > > > +                                                             -1,
> > > > + NULL, 0));
> > > > +
> > > > +       if (0 == ret)
> > > > +               return 0;
> > > > +
> > > > +free_opp:
> > > > +       dev_pm_opp_put_supported_hw(opp_temp);
> > >
> > > This is not needed because dev_pm_opp_set_supported_hw will free
> > > memory in case of failure. This call in only needed in case of a
> > > successful get.
> >
> > But this is still required for the case where platform device
registration fails.
> >
> > --
> > viresh

  parent reply	other threads:[~2018-05-17  8:20 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-15  9:13 [PATCH v7 00/14] CPU scaling support for msm8996 Ilia Lin
2018-05-15  9:13 ` [PATCH v7 01/14] soc: qcom: Separate kryo l2 accessors from PMU driver Ilia Lin
2018-05-16 13:12   ` Amit Kucheria
2018-05-15  9:13 ` [PATCH v7 02/14] clk: qcom: Make clk_alpha_pll_configure available to modules Ilia Lin
2018-05-15  9:13 ` [PATCH v7 03/14] clk: qcom: Add CPU clock driver for msm8996 Ilia Lin
2018-05-16 13:12   ` Amit Kucheria
2018-05-17 16:31   ` kbuild test robot
2018-05-17 16:51   ` kbuild test robot
2018-05-15  9:13 ` [PATCH v7 04/14] clk: qcom: Add DT bindings for " Ilia Lin
2018-05-15  9:13 ` [PATCH v7 05/14] clk: qcom: cpu-8996: Add support to switch to alternate PLL Ilia Lin
2018-05-15  9:13 ` [PATCH v7 06/14] clk: qcom: cpu-8996: Add support to switch below 600Mhz Ilia Lin
2018-05-15  9:13 ` [PATCH v7 07/14] clk: qcom: Add ACD path to CPU clock driver for msm8996 Ilia Lin
2018-05-15  9:13 ` [PATCH v7 08/14] dt: qcom: Add opp and thermal to the msm8996 Ilia Lin
2018-05-15  9:13 ` [PATCH v7 09/14] regulator: qcom_spmi: Add support for SAW Ilia Lin
2018-05-15  9:13 ` [PATCH v7 10/14] dt-bindings: qcom_spmi: Add support for SAW documentation Ilia Lin
2018-05-16 13:12   ` Amit Kucheria
2018-05-17  7:24     ` ilialin
2018-05-15  9:13 ` [PATCH v7 11/14] dt: qcom: Add SAW regulator for 8x96 CPUs Ilia Lin
2018-05-15  9:13 ` [PATCH v7 12/14] cpufreq: Add Kryo CPU scaling driver Ilia Lin
2018-05-15  9:19   ` Viresh Kumar
2018-05-15  9:28     ` Rafael J. Wysocki
2018-05-16  4:13   ` kbuild test robot
2018-05-16 13:12   ` Amit Kucheria
2018-05-16 14:11     ` Viresh Kumar
2018-05-16 14:13       ` Amit Kucheria
2018-05-17  7:50       ` ilialin
2018-05-17  8:20       ` ilialin [this message]
2018-05-16 15:45     ` Ilia Lin
2018-05-17  7:19     ` ilialin
2018-05-15  9:13 ` [PATCH v7 13/14] dt-bindings: cpufreq: Document operating-points-v2-kryo-cpu Ilia Lin
2018-05-16 13:12   ` Amit Kucheria
2018-05-15  9:13 ` [PATCH v7 14/14] dt: qcom: Add qcom-cpufreq-kryo driver configuration Ilia Lin
2018-05-15  9:19   ` Viresh Kumar
2018-05-16 13:12   ` Amit Kucheria
2018-05-16 13:11 ` [PATCH v7 00/14] CPU scaling support for msm8996 Amit Kucheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='017f01d3edb7$ec160320$c4420960$@codeaurora.org' \
    --to=ilialin@codeaurora.org \
    --cc=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=celster@codeaurora.org \
    --cc=david.brown@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-soc@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=nicolas.dechesne@linaro.org \
    --cc=nm@ti.com \
    --cc=rjw@rjwysocki.net \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tfinkel@codeaurora.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).