From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9349C433B4 for ; Thu, 15 Apr 2021 17:06:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75DAA61184 for ; Thu, 15 Apr 2021 17:06:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233343AbhDORHO (ORCPT ); Thu, 15 Apr 2021 13:07:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231137AbhDORHO (ORCPT ); Thu, 15 Apr 2021 13:07:14 -0400 Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EED4EC061574 for ; Thu, 15 Apr 2021 10:06:50 -0700 (PDT) Received: by mail-ed1-x536.google.com with SMTP id g17so28246756edm.6 for ; Thu, 15 Apr 2021 10:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qiaTdRxVP+PjHJWnCOqI9pORWv0g/7bqvQKS7jz0//U=; b=SeU4I60J41yRkWpulsHcyPQ0lGGZjLMdyTuau+HGDQ2VjSz3SciXMHUC3QvsZbqVcZ voda+hYW9t0JiCwoD+6pWkUmyxu8t2ZvdA/PN+qMiHpbrhnM+z79QAtyGCb9577D4F/5 cb8mDEjiHuRcGGOQl8CsUsHU8dKj4L/bTu8JwtubTZWnlJ10yUV9DMW9zk7oyUTfilo1 PB96VLQ5miWm6uBcSkcY8dsCa9J0GgeCuRyJETl9c6vJAtiTh6alxsYKQ7tEbzHCPbv7 V8YMGaYrHRewcISh9agCA2zc5m6KwvJEMnVq5HSSWud0g0I+Sf58ew0RLoRfmX/dGO6f uHsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qiaTdRxVP+PjHJWnCOqI9pORWv0g/7bqvQKS7jz0//U=; b=BLAOQPKyhDQUv982LsUFzuc/umWh7Y6gjqaKT4RR5bRjyDj4N31SSnqRexQc4WvgN/ baMGjOgEXKgl/PEeMERzmGI7ujbYdJvCvYvjn2DI2XuFk7vwAHMJbk5SGgun1zlQkoIO XWyA9YXvLc16gX1qUl78GCAR9B9O7gJEU3l6OMxNTFJN/AqZ96Tn/4lz0qpJjfyW4xBr tg+BlinmlouiU53oGDegjb3WNBcH276E1nrMDkkBOwAneia95NdJogk5VOABvEJGgcF5 IkevbS3Vi3JOSfFUjDJXckBhEhvdmFuvxYrUO1hoCT/gaeRXr4besek4XfF5Wr+j6PXR AoPA== X-Gm-Message-State: AOAM533cKnFEC6cVzbFnOssBLuO5imy5m6sDBq41q/YotN3huyKscNvV DqpuG4HJtEflDxzOm/X02dlgdbqYRoRlFA== X-Google-Smtp-Source: ABdhPJxnIwBJcv7n1yI2CZjRa7oKLiVaHxuL6ZCvd/+6CoD3FiDgjO1KW9xeG7XlP6U3ppCryqzvfQ== X-Received: by 2002:aa7:c349:: with SMTP id j9mr5643684edr.41.1618506409735; Thu, 15 Apr 2021 10:06:49 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id cq26sm3046543edb.60.2021.04.15.10.06.48 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Apr 2021 10:06:49 -0700 (PDT) Subject: Re: [PATCH v4 1/9] ASoC: dt-bindings: wcd938x: add bindings for wcd938x To: Rob Herring Cc: broonie@kernel.org, devicetree@vger.kernel.org, perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, lgirdwood@gmail.com References: <20210414154845.21964-1-srinivas.kandagatla@linaro.org> <20210414154845.21964-2-srinivas.kandagatla@linaro.org> <20210415162947.GA1511094@robh.at.kernel.org> From: Srinivas Kandagatla Message-ID: <019aa3c0-56ce-de17-4d64-be6dbc0a3a65@linaro.org> Date: Thu, 15 Apr 2021 18:06:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210415162947.GA1511094@robh.at.kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 15/04/2021 17:29, Rob Herring wrote: >> + codec { >> + compatible = "qcom,wcd9380-codec"; >> + reset-gpios = <&tlmm 32 0>; >> + #sound-dai-cells = <1>; >> + qcom,tx-device = <&wcd938x_tx>; >> + qcom,rx-device = <&wcd938x_rx>; >> + qcom,micbias1-microvolt = <1800000>; >> + qcom,micbias2-microvolt = <1800000>; >> + qcom,micbias3-microvolt = <1800000>; >> + qcom,micbias4-microvolt = <1800000>; >> + qcom,mbhc-hphl-switch; >> + qcom,mbhc-ground-switch; >> + qcom,mbhc-button0-vthreshold-microvolt = <75000>; >> + qcom,mbhc-button1-vthreshold-microvolt = <150000>; >> + qcom,mbhc-button2-vthreshold-microvolt = <237000>; >> + qcom,mbhc-button3-vthreshold-microvolt = <500000>; >> + qcom,mbhc-button5-vthreshold-microvolt = <500000>; >> + qcom,mbhc-button6-vthreshold-microvolt = <500000>; >> + qcom,mbhc-button7-vthreshold-microvolt = <500000>; >> + }; >> + >> + /* ... */ >> + >> + soundwire@3230000 { >> + #address-cells = <2>; >> + #size-cells = <0>; >> + reg = <0x03230000 0x2000>; >> + wcd938x_tx: codec@0,3 { >> + compatible = "sdw20217010d00"; >> + reg = <0 3>; >> + qcom,direction = "tx"; >> + qcom,port-mapping = <2 3 4 5>; >> + }; >> + >> + wcd938x_rx: codec@0,4 { >> + compatible = "sdw20217010d00"; >> + reg = <0 4>; >> + qcom,direction = "rx"; >> + qcom,port-mapping = <1 2 3 4 5>; >> + }; > This is a single device, right? We shouldn't need 3 nodes to describe Just realized that the example is bit misleading here. It should look like: codec { compatible = "qcom,wcd9380-codec"; reset-gpios = <&tlmm 32 0>; #sound-dai-cells = <1>; qcom,tx-device = <&wcd938x_tx>; qcom,rx-device = <&wcd938x_rx>; qcom,micbias1-microvolt = <1800000>; qcom,micbias2-microvolt = <1800000>; qcom,micbias3-microvolt = <1800000>; qcom,micbias4-microvolt = <1800000>; qcom,mbhc-hphl-switch; qcom,mbhc-ground-switch; qcom,mbhc-button0-vthreshold-microvolt = <75000>; qcom,mbhc-button1-vthreshold-microvolt = <150000>; qcom,mbhc-button2-vthreshold-microvolt = <237000>; qcom,mbhc-button3-vthreshold-microvolt = <500000>; qcom,mbhc-button5-vthreshold-microvolt = <500000>; qcom,mbhc-button6-vthreshold-microvolt = <500000>; qcom,mbhc-button7-vthreshold-microvolt = <500000>; }; soundwire-controller@3230000 { reg = <0 0x3230000 0 0x2000>; compatible = "qcom,soundwire-v1.5.1"; wcd938x_tx: codec@0,3 { compatible = "sdw20217010d00"; reg = <0 3>; qcom,direction = "tx"; qcom,port-mapping = <2 3 4 5>; }; }; soundwire-controller@3210000 { reg = <0 0x3210000 0 0x2000>; compatible = "qcom,soundwire-v1.5.1"; wcd938x_rx: codec@0,4 { compatible = "sdw20217010d00"; reg = <0 4>; qcom,direction = "rx"; qcom,port-mapping = <1 2 3 4 5>; }; }; --srini