From: <ansuelsmth@gmail.com>
To: "'Vinod Koul'" <vkoul@kernel.org>
Cc: "'Andy Gross'" <agross@codeaurora.org>,
"'Jonathan McDowell'" <noodles@earth.li>,
"'Andy Gross'" <agross@kernel.org>,
"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Rob Herring'" <robh+dt@kernel.org>,
"'Mark Rutland'" <mark.rutland@arm.com>,
<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Subject: R: [RESEND PATCH v7 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver
Date: Mon, 13 Jul 2020 15:11:48 +0200 [thread overview]
Message-ID: <019d01d65917$2bff9ba0$83fed2e0$@gmail.com> (raw)
In-Reply-To: <20200713053255.GY34333@vkoul-mobl>
> -----Messaggio originale-----
> Da: Vinod Koul <vkoul@kernel.org>
> Inviato: lunedì 13 luglio 2020 07:33
> A: Ansuel Smith <ansuelsmth@gmail.com>
> Cc: Andy Gross <agross@codeaurora.org>; Jonathan McDowell
> <noodles@earth.li>; Andy Gross <agross@kernel.org>; Bjorn Andersson
> <bjorn.andersson@linaro.org>; Kishon Vijay Abraham I <kishon@ti.com>;
> Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; linux-arm-msm@vger.kernel.org; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Oggetto: Re: [RESEND PATCH v7 1/2] phy: qualcomm: add qcom ipq806x
> dwc usb phy driver
>
> On 15-06-20, 22:53, Ansuel Smith wrote:
>
> > @@ -0,0 +1,593 @@
> > +// SPDX-License-Identifier: GPL-2.0-only
> > +/* Copyright (c) 2014-2015, Code Aurora Forum. All rights reserved.
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 and
> > + * only version 2 as published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> > + * GNU General Public License for more details.
>
> You have SPDX tag, so we dont need the license text, please remove this.
> Also we are in 2020 now so Copyright looks incorrect
>
> > +static int qcom_ipq806x_usb_ss_phy_init(struct phy *phy)
> > +{
> > + struct usb_phy *phy_dwc3 = phy_get_drvdata(phy);
> > + int ret;
> > + u32 data = 0;
>
> Superfluous init
>
> > +static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
> > +{
> > + struct usb_phy *phy_dwc3;
> > + struct phy_provider *phy_provider;
> > + struct phy *generic_phy;
> > + const struct of_device_id *match;
> > + const struct phy_drvdata *data;
> > + struct resource *res;
> > + resource_size_t size;
>
> Pls pick one, tabs or single spaces, not both. and reverse christmas
> looks better :)
>
> > + struct device_node *np;
> > +
> > + phy_dwc3 = devm_kzalloc(&pdev->dev, sizeof(*phy_dwc3),
> GFP_KERNEL);
> > + if (!phy_dwc3)
> > + return -ENOMEM;
> > +
> > + match = of_match_node(qcom_ipq806x_usb_phy_table, pdev-
> >dev.of_node);
> > + data = match->data;
>
> How about using of_device_get_match_data() instead?
> --
> ~Vinod
match is also used in the function to compare compatible.
prev parent reply other threads:[~2020-07-13 13:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 20:53 [RESEND PATCH v7 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver Ansuel Smith
2020-06-15 20:53 ` [RESEND PATCH v7 2/2] devicetree: bindings: phy: Document ipq806x dwc3 qcom phy Ansuel Smith
2020-07-08 11:21 ` Vinod Koul
2020-07-09 20:25 ` Rob Herring
2020-07-13 5:32 ` [RESEND PATCH v7 1/2] phy: qualcomm: add qcom ipq806x dwc usb phy driver Vinod Koul
2020-07-13 13:11 ` ansuelsmth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019d01d65917$2bff9ba0$83fed2e0$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=agross@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=noodles@earth.li \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).