From: Florian Vaussard <florian.vaussard@heig-vd.ch>
To: Rob Herring <robh@kernel.org>,
Florian Vaussard <florian.vaussard@gmail.com>
Cc: devicetree@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Jacek Anaszewski <j.anaszewski@samsung.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Vaussard Florian <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH 1/2] leds: ncp5623: Add device tree binding documentation
Date: Wed, 22 Jun 2016 08:17:09 +0200 [thread overview]
Message-ID: <029fbebf-1fae-06c1-5cdb-07fe256d5130@heig-vd.ch> (raw)
In-Reply-To: <20160621215218.GA12971@rob-hp-laptop>
Hi Rob,
Le 21. 06. 16 à 23:52, Rob Herring a écrit :
> On Tue, Jun 21, 2016 at 09:29:13AM +0200, Florian Vaussard wrote:
>> Add device tree binding documentation for On Semiconductor NCP5623 I2C
>> LED driver. The driver can independently control the PWM of the 3
>> channels with 32 levels of intensity.
>>
>> The current delivered by the current source can be controlled using the
>> led-max-microamp property. In order to control this value, it is also
>> necessary to know the current on the Iref pin, hence the
>> onnn,led-iref-microamp property. It is usually set using an external
>> bias resistor, following Iref = Vref/Rbias with Vref=0.6V.
>>
>> Signed-off-by: Florian Vaussard <florian.vaussard@heig-vd.ch>
>> ---
>> .../devicetree/bindings/leds/leds-ncp5623.txt | 44 ++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-ncp5623.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-ncp5623.txt b/Documentation/devicetree/bindings/leds/leds-ncp5623.txt
>> new file mode 100644
>> index 0000000..0dc8345
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-ncp5623.txt
>> @@ -0,0 +1,44 @@
>> +* ON Semiconductor - NCP5623 3-Channel LED Driver
>> +
>> +The NCP5623 is a 3-channel I2C LED driver. The brightness of each
>> +channel can be independently set using 32 levels. Each LED is represented
>> +as a sub-node of the device.
>> +
>> +Required properties:
>> + - compatible: Should be "onnn,ncp5623"
>> + - reg: I2C slave address (fixed to 0x38)
>> + - #address-cells: must be 1
>> + - #size-cells: must be 0
>> + - onnn,led-iref-microamp: Current on the Iref pin in microampere
>> + - led-max-microamp: Desired maximum current for each LED in microampere
>> + (maximum 30000uA)
>> +
>> +LED sub-node properties:
>> + - reg : LED channel number (0..2)
>> + - For other LED properties see:
>> + Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +led1: ncp5623@38 {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + compatible = "onnn,ncp5623";
>> + reg = <0x38>;
>> +
>> + led1_r@0 {
>
> Don't use underscores in node names.
>
Sorry for the mistake, I will fix.
Thanks for the review,
Florian
next prev parent reply other threads:[~2016-06-22 6:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 7:29 [PATCH 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
[not found] ` <1466494154-3786-1-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-06-21 7:29 ` [PATCH 1/2] leds: ncp5623: Add device tree binding documentation Florian Vaussard
2016-06-21 15:28 ` Jacek Anaszewski
2016-06-22 6:08 ` Florian Vaussard
2016-06-22 8:51 ` Jacek Anaszewski
[not found] ` <576A5191.4070402-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-22 14:25 ` Florian Vaussard
[not found] ` <c97adf5a-7c5b-8602-83c1-f85854bd64d6-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-06-23 7:23 ` Jacek Anaszewski
2016-06-23 8:32 ` Florian Vaussard
2016-06-23 11:21 ` Jacek Anaszewski
2016-06-23 12:01 ` Florian Vaussard
2016-06-23 13:53 ` Jacek Anaszewski
2016-06-22 8:52 ` Jacek Anaszewski
2016-06-21 21:52 ` Rob Herring
2016-06-22 6:17 ` Florian Vaussard [this message]
2016-06-21 7:29 ` [PATCH 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
2016-06-21 15:29 ` Jacek Anaszewski
2016-06-22 6:08 ` Florian Vaussard
2016-06-22 7:26 ` Jacek Anaszewski
2016-06-26 21:49 ` Pavel Machek
2016-06-27 5:46 ` Florian Vaussard
2016-06-27 7:09 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=029fbebf-1fae-06c1-5cdb-07fe256d5130@heig-vd.ch \
--to=florian.vaussard@heig-vd.ch \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).