From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Leo Li <leoyang.li@nxp.com>, Shawn Guo <shawnguo@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>,
devicetree <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART
Date: Tue, 10 Aug 2021 09:28:05 +0800 [thread overview]
Message-ID: <03d7c7be-2f19-9fdf-2a4e-f49a62bb82f6@huawei.com> (raw)
In-Reply-To: <AS8PR04MB8946D0EB15D631346F4D13198FF69@AS8PR04MB8946.eurprd04.prod.outlook.com>
On 2021/8/10 6:52, Leo Li wrote:
>
>
>> -----Original Message-----
>> From: Zhen Lei <thunder.leizhen@huawei.com>
>> Sent: Tuesday, June 15, 2021 8:16 AM
>> To: Shawn Guo <shawnguo@kernel.org>; Leo Li <leoyang.li@nxp.com>; Rob
>> Herring <robh+dt@kernel.org>; Mark Kettenis <mark.kettenis@xs4all.nl>;
>> devicetree <devicetree@vger.kernel.org>; linux-arm-kernel <linux-arm-
>> kernel@lists.infradead.org>; linux-kernel <linux-kernel@vger.kernel.org>
>> Cc: Zhen Lei <thunder.leizhen@huawei.com>
>> Subject: [PATCH v2 1/1] arm64: dts: lx2160a: Fix the compatible string of
>> LX2160A UART
>>
>> Mark Kettenis told us that:
>> According to the NXP documentation, the LX2160A has a real PL011 UART.
>>
>> Therefore, rewrite it to the compatible string of pl011. The property "current-
>> speed" specific to "arm,sbsa-uart" is also deleted.
>
> Sorry that I missed the discussion on the v1. But looks like this change breaks the LX2160 boot. The AMBA matching doesn't seem to work. And the console is not registered correctly.
https://lore.kernel.org/linux-arm-kernel/cba3a29f-92b5-072a-9a27-60240f072dad@huawei.com/
Maybe we should fall back to v1.
>
> [ 0.639055] OF: amba_device_add() failed (-2) for /soc/serial@21c0000
> [ 0.645612] OF: amba_device_add() failed (-2) for /soc/serial@21d0000
>
>>
>> Suggested-by: Shawn Guo <shawnguo@kernel.org>
>> Suggested-by: Mark Kettenis <mark.kettenis@xs4all.nl>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 12 ++++--------
>> 1 file changed, 4 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> index c4b1a59ba424..d2e6f7285674 100644
>> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
>> @@ -920,34 +920,30 @@ QORIQ_CLK_PLL_DIV(8)>,
>> };
>>
>> uart0: serial@21c0000 {
>> - compatible = "arm,sbsa-uart","arm,pl011";
>> + compatible = "arm,pl011", "arm,primecell";
>> reg = <0x0 0x21c0000 0x0 0x1000>;
>> interrupts = <GIC_SPI 32 IRQ_TYPE_LEVEL_HIGH>;
>> - current-speed = <115200>;
>> status = "disabled";
>> };
>>
>> uart1: serial@21d0000 {
>> - compatible = "arm,sbsa-uart","arm,pl011";
>> + compatible = "arm,pl011", "arm,primecell";
>> reg = <0x0 0x21d0000 0x0 0x1000>;
>> interrupts = <GIC_SPI 33 IRQ_TYPE_LEVEL_HIGH>;
>> - current-speed = <115200>;
>> status = "disabled";
>> };
>>
>> uart2: serial@21e0000 {
>> - compatible = "arm,sbsa-uart","arm,pl011";
>> + compatible = "arm,pl011", "arm,primecell";
>> reg = <0x0 0x21e0000 0x0 0x1000>;
>> interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
>> - current-speed = <115200>;
>> status = "disabled";
>> };
>>
>> uart3: serial@21f0000 {
>> - compatible = "arm,sbsa-uart","arm,pl011";
>> + compatible = "arm,pl011", "arm,primecell";
>> reg = <0x0 0x21f0000 0x0 0x1000>;
>> interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
>> - current-speed = <115200>;
>> status = "disabled";
>> };
>>
>> --
>> 2.25.1
>>
>
> .
>
next prev parent reply other threads:[~2021-08-10 1:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 13:16 [PATCH v2 0/1] arm64: dts: lx2160a: Fix the compatible string of LX2160A UART Zhen Lei
2021-06-15 13:16 ` [PATCH v2 1/1] " Zhen Lei
2021-07-14 7:22 ` Shawn Guo
2021-08-09 22:52 ` Leo Li
2021-08-10 1:28 ` Leizhen (ThunderTown) [this message]
2021-08-10 3:38 ` Leo Li
2021-08-12 23:09 ` Li Yang
2021-08-14 4:47 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d7c7be-2f19-9fdf-2a4e-f49a62bb82f6@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.kettenis@xs4all.nl \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).