From: Neil Armstrong <narmstrong@baylibre.com>
To: Artem Lapkin <email2tema@gmail.com>
Cc: khilman@baylibre.com, robh+dt@kernel.org, jbrunet@baylibre.com,
martin.blumenstingl@googlemail.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
art@khadas.com, nick@khadas.com, gouwa@khadas.com
Subject: Re: [PATCH 3/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L board meson-khadas-vim3
Date: Fri, 25 Sep 2020 09:39:21 +0200 [thread overview]
Message-ID: <0467e912-b19e-5389-388b-99b6316d24d8@baylibre.com> (raw)
In-Reply-To: <20200925033017.1790973-4-art@khadas.com>
Hi,
On 25/09/2020 05:30, Artem Lapkin wrote:
> add aliases names led_white and led_red for white and red leds
Sorry, can you explain why you need these ? They should not be used by the led framework.
>
> Signed-off-by: Artem Lapkin <art@khadas.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> index 73783692e30..7e137399257 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi
> @@ -12,6 +12,8 @@ / {
> aliases {
> serial0 = &uart_AO;
> ethernet0 = ðmac;
> + led_red = &led_red;
> + led_white = &led_white;
These aliases are not standard aliases.
> };
>
> chosen {
> @@ -39,13 +41,13 @@ button-function {
> leds {
> compatible = "gpio-leds";
>
> - led-white {
> + led_white: led-white {
> label = "vim3:white:sys";
> gpios = <&gpio_ao GPIOAO_4 GPIO_ACTIVE_HIGH>;
> linux,default-trigger = "heartbeat";
> };
>
> - led-red {
> + led_red: led-red {
> label = "vim3:red";
> gpios = <&gpio_expander 5 GPIO_ACTIVE_HIGH>;
> };
>
Instead you should convert these to the new function/color attributes are described in:
Documentation/devicetree/bindings/leds/common.yaml
{
function = LED_FUNCTION_STATUS;
color = <LED_COLOR_ID_WHITE>;
}
Neil
next prev parent reply other threads:[~2020-09-25 7:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 3:30 [PATCH 0/8] dts updates and fixes for Khadas VIM1 VIM2 VIM3 VIML boards Artem Lapkin
2020-09-25 3:30 ` [PATCH 1/8] arm64: dts: meson: update spifc node on Khadas VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 7:41 ` Neil Armstrong
2020-09-25 7:51 ` Martin Blumenstingl
2020-09-28 7:54 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 2/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L boards meson-khadas-vim3 Artem Lapkin
2020-09-25 7:36 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 3/8] arm64: dts: meson: update leds node on Khadas VIM3/VIM3L board meson-khadas-vim3 Artem Lapkin
2020-09-25 7:39 ` Neil Armstrong [this message]
2020-09-25 3:30 ` [PATCH 4/8] arm64: dts: meson: remove fixed memory size for Khadas VIM3/VIM3L meson-khadas-vim3 Artem Lapkin
2020-09-25 7:37 ` Martin Blumenstingl
2020-09-25 7:40 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 5/8] arm64: dts: meson: remove reset-gpios from ethernet node for VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 7:41 ` Martin Blumenstingl
[not found] ` <CAKaHn9+CWLJYN1Tt46VxBGNBEbVVJZWeL6ZJSf9w-5DmoxrvgQ@mail.gmail.com>
2020-09-25 8:04 ` Martin Blumenstingl
[not found] ` <CAKaHn9K6O8u6Br84S63V0PDFBhiRbMdd4-bvC5FxFe6izj_Dvg@mail.gmail.com>
2020-09-25 11:26 ` Martin Blumenstingl
[not found] ` <CAKaHn9JxKBKW5AYvUNBAA+sNcHfNQNrx95NtLMnrfd0ypOaAoA@mail.gmail.com>
2020-09-28 20:41 ` Martin Blumenstingl
2020-09-25 3:30 ` [PATCH 6/8] arm64: dts: meson: disable vrtc for VIM3L boards meson-khadas-vim3 Artem Lapkin
2020-09-25 7:44 ` Neil Armstrong
2020-09-25 3:30 ` [PATCH 7/8] arm64: dts: meson: enable RTC for VIM1 meson-gxl-s905x-khadas-vim Artem Lapkin
2020-09-25 7:31 ` Martin Blumenstingl
2020-09-25 3:30 ` [PATCH 8/8] arm64: dts: meson: enable RTC for VIM2 meson-gxm-khadas-vim2 Artem Lapkin
2020-09-25 8:58 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0467e912-b19e-5389-388b-99b6316d24d8@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=art@khadas.com \
--cc=devicetree@vger.kernel.org \
--cc=email2tema@gmail.com \
--cc=gouwa@khadas.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=nick@khadas.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).