From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E28FC4363C for ; Wed, 7 Oct 2020 06:49:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D1A4320872 for ; Wed, 7 Oct 2020 06:49:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726219AbgJGGtQ (ORCPT ); Wed, 7 Oct 2020 02:49:16 -0400 Received: from out-2.mail.amis.net ([212.18.32.14]:37487 "EHLO out-2.mail.amis.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725970AbgJGGtQ (ORCPT ); Wed, 7 Oct 2020 02:49:16 -0400 Received: from in-2.mail.amis.net (in-2.mail.amis.net [212.18.32.19]) by out-2.mail.amis.net (Postfix) with ESMTP id 9568180C8F; Wed, 7 Oct 2020 08:49:12 +0200 (CEST) Received: from in-2.mail.amis.net (localhost [127.0.0.1]) by in-2.mail.amis.net (Postfix) with ESMTP id 90936C9408; Wed, 7 Oct 2020 08:49:12 +0200 (CEST) X-Virus-Scanned: amavisd-new at amis.net Received: from in-2.mail.amis.net ([127.0.0.1]) by in-2.mail.amis.net (in-2.mail.amis.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tUiipAm1VvNZ; Wed, 7 Oct 2020 08:49:12 +0200 (CEST) Received: from smtp2.amis.net (smtp2.amis.net [212.18.32.44]) by in-2.mail.amis.net (Postfix) with ESMTP id 2DF3AC9409; Wed, 7 Oct 2020 08:49:12 +0200 (CEST) Received: from [192.168.69.116] (89-212-21-243.static.t-2.net [89.212.21.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp2.amis.net (Postfix) with ESMTPSA id 3643F7FD42; Wed, 7 Oct 2020 08:49:11 +0200 (CEST) Subject: Re: [PATCH 2/2] ASoC: dt-bindings: fsl: add ac97 fixed mode support To: Rob Herring , Fabio Estevam Cc: Linux-ALSA , Timur Tabi , Nicolin Chen , Xiubo Li , Shengjiu Wang , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20201005111644.3131604-1-primoz.fiser@norik.com> <20201005111644.3131604-2-primoz.fiser@norik.com> <20201006215239.GA2912752@bogus> From: Primoz Fiser Message-ID: <06953039-2064-b3eb-f208-9133158b3ac3@norik.com> Date: Wed, 7 Oct 2020 08:49:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201006215239.GA2912752@bogus> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, > Then perhaps it could be boolean? Indeed, I can make it boolean. In that case I would rename property to "fsl,ac97-fixed-mode". Should I do that for V2? Please advise. BR, Primoz On 6. 10. 20 23:52, Rob Herring wrote: > On Mon, Oct 05, 2020 at 08:35:58AM -0300, Fabio Estevam wrote: >> On Mon, Oct 5, 2020 at 8:16 AM Primoz Fiser wrote: >>> >>> Add devicetree bindings documentation for operating SSI in AC'97 >>> variable/fixed mode of operation. >>> >>> Signed-off-by: Primoz Fiser >>> --- >>> Documentation/devicetree/bindings/sound/fsl,ssi.txt | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/sound/fsl,ssi.txt b/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> index 7e15a85cecd2..abc5abe11fb9 100644 >>> --- a/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> +++ b/Documentation/devicetree/bindings/sound/fsl,ssi.txt >>> @@ -43,6 +43,11 @@ Optional properties: >>> - fsl,mode: The operating mode for the AC97 interface only. >>> "ac97-slave" - AC97 mode, SSI is clock slave >>> "ac97-master" - AC97 mode, SSI is clock master >>> +- fsl,ac97-mode: SSI AC97 mode of operation. >>> + "variable" - AC97 Variable Mode, SLOTREQ bits determine >>> + next receive/transmit frame >>> + "fixed" - AC97 Fixed Mode, SSI transmits in accordance with >>> + AC97 Frame Rate Divider bits >> >> It would be good to mention what is the default mode when such >> property is absent. > > Then perhaps it could be boolean? > > Rob >