From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6F1C3F2CD for ; Wed, 4 Mar 2020 06:18:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B81320870 for ; Wed, 4 Mar 2020 06:18:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725861AbgCDGSO (ORCPT ); Wed, 4 Mar 2020 01:18:14 -0500 Received: from mga05.intel.com ([192.55.52.43]:41059 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725774AbgCDGSN (ORCPT ); Wed, 4 Mar 2020 01:18:13 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Mar 2020 22:18:13 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,513,1574150400"; d="scan'208";a="439017045" Received: from linux.intel.com ([10.54.29.200]) by fmsmga005.fm.intel.com with ESMTP; 03 Mar 2020 22:18:12 -0800 Received: from [10.226.38.56] (unknown [10.226.38.56]) by linux.intel.com (Postfix) with ESMTP id 624FE580372; Tue, 3 Mar 2020 22:18:09 -0800 (PST) Subject: Re: [PATCH v5 2/2] clk: intel: Add CGU clock driver for a new SoC To: Andy Shevchenko Cc: Randy Dunlap , mturquette@baylibre.com, sboyd@kernel.org, robh@kernel.org, mark.rutland@arm.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, qi-ming.wu@intel.com, yixin.zhu@linux.intel.com, cheol.yong.kim@intel.com, rtanwar References: <6148b5b25d4a6833f0a72801d569ed97ac6ca55b.1582096982.git.rahul.tanwar@linux.intel.com> <4fb7a643-cbe1-da82-2629-2dbd0c0d143b@linux.intel.com> <20200227100239.GD1224808@smile.fi.intel.com> <12c16eb0-04aa-79cf-fa76-3f45b8972319@linux.intel.com> <20200303100936.GL1224808@smile.fi.intel.com> From: "Tanwar, Rahul" Message-ID: <08222833-7895-c3e3-5352-3111501965c5@linux.intel.com> Date: Wed, 4 Mar 2020 14:18:08 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.1 MIME-Version: 1.0 In-Reply-To: <20200303100936.GL1224808@smile.fi.intel.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 3/3/2020 6:09 PM, Andy Shevchenko wrote: > On Tue, Mar 03, 2020 at 11:37:23AM +0800, Tanwar, Rahul wrote: >> On 27/2/2020 6:02 PM, Andy Shevchenko wrote: >>> On Thu, Feb 27, 2020 at 03:19:26PM +0800, Tanwar, Rahul wrote: >>>> On 19/2/2020 3:59 PM, Randy Dunlap wrote: >>>>> On 2/18/20 11:40 PM, Rahul Tanwar wrote: >>>>> >>>>>> +config CLK_LGM_CGU >>>>>> + depends on (OF && HAS_IOMEM) || COMPILE_TEST >>>>> This "depends on" looks problematic to me. I guess we shall see when >>>>> all the build bots get to it. >>>> At the moment, i am not able to figure out possible problems in this.. >>> COMPILE_TEST should be accompanied by non-generic dependency. >>> There is none. >>> >>> So, I quite agree with Randy. >> I see COMPILE_TEST is mostly ORed with ARCH_xx. How about below? >> >> depends on OF && HAS_IOMEM && (CONFIG_X86 || COMPILE_TEST) > How about to leave logical parts separately? > How is OF related to architecture? OF is not related to architecture. Driver depends on OF. In the past, many build/linker issues were reported due to OF & HAS_IOMEM dependencies in the code. Please see [1] & [2]. So to be safe this time, i am adding these dependencies here. > On top of that, is this code only for x86 for sure? > Yes, this is a totally new IP for x86 based SoC. No plans of using same IP/driver for any other arch based SoCs. [1] https://lkml.org/lkml/2019/12/3/613 [2] https://lkml.org/lkml/2019/12/11/1733