From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 756BAC433F5 for ; Sun, 29 May 2022 10:13:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbiE2KNJ (ORCPT ); Sun, 29 May 2022 06:13:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229825AbiE2KNI (ORCPT ); Sun, 29 May 2022 06:13:08 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47E5F55378 for ; Sun, 29 May 2022 03:13:06 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id f9so16046381ejc.0 for ; Sun, 29 May 2022 03:13:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=bUy1BLSfINnv6ERfgwnR9eRuDhaZE3UpSRaIiNc0rCk=; b=fOCVaeWekIDBF1ZTj+ZMJy83A6Ex7xJs/MN5E3AF/v8o5zvs2ENqHEpThyFQUumh+d VTifvXiSxPk5W/+dDVbHcSm5nTN5ozMBfO9Xr2FdVvVMuF7/tscs3txTgA6KQDGAvteR R8vvvIKMs07CwMPbo+dU74xrLJqj+jG2KEWkS5XBl5zzOi46h2eqERFGuaD0JLzwjFZq 9pqqEmsGVdEumazbZKkSsonZV/jyU4DZRO5FA7hpOZlKR6ET6NlcMfI/cN3WlBxTIcWW m2dopHfGh1WUkzNIKBbPOgtZwYrEdO/nOHnZUVwUP1vi18jBhR2wgfhCwGWyMO9HSjhj ktSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bUy1BLSfINnv6ERfgwnR9eRuDhaZE3UpSRaIiNc0rCk=; b=7Dhra0UGwt1qzMlIQXjgusl/2mTPmC+LPjoXoquyGoT+7uYgcbwWEGgd/5oyIJl2w6 wGoDk3EK8YKZVZUAPbQvfbxylqmV0+9c/mfuzkOrPDoFT8oQvMpVbrT5SXTGBdW2pYiQ uZmOg0WAyd410kfNZ0NChD5G1xfguW8ZZOlF/uq+XjtXX3wN2J5TVzZPES49tTq+48+p q52JdtnAfHOpvTJzMJfsprRbeT8XUkrgghNAurtJgx9UQRqmRatF+XXbi8c0zrCcWfLP wnmNXiYK66o0TNaUIj1R6J1RQabkL+4Gd23rFo1fJRUTqtaXScwUGyPt1VwOF6QjoifE lwpg== X-Gm-Message-State: AOAM533uIlanpiWqPa43WSpyL9QR32d+uBfrrh3BF3K3FE+WhZB39dct /QR3tjqd9hWcvfx+ePKZgLraJg== X-Google-Smtp-Source: ABdhPJwRnn73I0h92HQD0I7VsbBaBGvIs+5l+glq3XnZt5443BhXX1yMDrfdu0PUF5ljjdSKKrk0/w== X-Received: by 2002:a17:907:7f0f:b0:6fe:b18c:72cf with SMTP id qf15-20020a1709077f0f00b006feb18c72cfmr38239293ejc.203.1653819184771; Sun, 29 May 2022 03:13:04 -0700 (PDT) Received: from [192.168.0.177] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id 12-20020a50874c000000b0042bc5a536edsm4760532edv.28.2022.05.29.03.13.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 May 2022 03:13:04 -0700 (PDT) Message-ID: <09803412-640a-6c9a-fe5a-b0af8cd10f0f@linaro.org> Date: Sun, 29 May 2022 12:13:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v4] ARM: dts: aspeed: Adding Jabil Rubypass BMC Content-Language: en-US To: David Wang , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: edward_chen@jabil.com, ben_pai@jabil.com References: <20220527042708.805444-1-David_Wang6097@jabil.com> From: Krzysztof Kozlowski In-Reply-To: <20220527042708.805444-1-David_Wang6097@jabil.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 27/05/2022 06:27, David Wang wrote: > The initial introduction of the jabil server with AST2600 BMC SoC. > > --- > > v4 > - Add document the new compatible. > - Delete redundant blank lines. > - Add a new line at end of file. Thanks for the changes but several fixes are still needed. If some of my comments are a bit unspecific, you can always ask for clarification. > > v3 > - Adjustment entries are ordered by name. > - Remove the bootargs property and modify the stdout-path property. > - Group multiple LED devices into a group. > - Modify the "gpio3_71" node name format. > - Delete unneeded blank line at the end. > > v2 > - Disable empty i2c bus. > - Remove gfx node because aspeed-g6.dtsi isn't supported. > - Modify the led format and add some properties. > - Fix wrong indentation. > - Add stdout property in chosen node. > - Rename temp to temperature-sensor in i2c bus 0. > > --- > > Signed-off-by: David Wang > --- > .../bindings/arm/jabil/jabil-boards.yaml | 24 + > .../devicetree/bindings/vendor-prefixes.yaml | 2 + > arch/arm/boot/dts/Makefile | 1 + > .../boot/dts/aspeed-bmc-jabil-rubypass.dts | 442 ++++++++++++++++++ > 4 files changed, 469 insertions(+) > create mode 100644 Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > create mode 100644 arch/arm/boot/dts/aspeed-bmc-jabil-rubypass.dts > > diff --git a/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml b/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > new file mode 100644 > index 000000000000..dde7791aa8bc > --- /dev/null > +++ b/Documentation/devicetree/bindings/arm/jabil/jabil-boards.yaml > @@ -0,0 +1,24 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/jabil/jabil-boards.yaml# This should be aspeed. Let me send a send a base patch for all Aspeed boards. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Jabil Bmc and Aspeed SoC based boards > + > +maintainers: > + - David Wang > + > +properties: > + $nodename: > + const: '/' > + compatible: > + oneOf: > + - description: Aspeed ast2600 bmc boards > + items: > + - const: jabil,rbp # eaglestream platform > + > +required: > + - compatible > + > +additionalProperties: true > diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml > index 01430973ecec..69738483c059 100644 > --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml > +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml > @@ -624,6 +624,8 @@ patternProperties: > description: Jiandangjing Technology Co., Ltd. > "^joz,.*": > description: JOZ BV > + "^jabil,.*": > + description: Jabil Design Service Branch (Sanchong) The list is ordered alphabetically, so jabil goes before. This should be also separate patch. > "^kam,.*": > description: Kamstrup A/S > "^karo,.*": Best regards, Krzysztof