From: Michael Walle <michael@walle.cc>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>, Leo Li <leoyang.li@nxp.com>,
"Y.b. Lu" <yangbo.lu@nxp.com>, Xiaowei Bao <xiaowei.bao@nxp.com>,
Ashish Kumar <ashish.kumar@nxp.com>
Subject: Re: [RFC PATCH v3 9/9] arm64: dts: lx2160a: fix FlexSPI clock
Date: Mon, 09 Nov 2020 10:43:03 +0100 [thread overview]
Message-ID: <0e165232e518c0f6c1b894311f00982a@walle.cc> (raw)
In-Reply-To: <20201108212139.ht22zdk27pyxv6wc@skbuf>
Am 2020-11-08 22:21, schrieb Vladimir Oltean:
> On Sun, Nov 08, 2020 at 07:51:13PM +0100, Michael Walle wrote:
>> Now that we have a proper driver for the FlexSPI interface use it.
>> This
>> will fix SCK frequency switching on Layerscape SoCs.
>>
>> Signed-off-by: Michael Walle <michael@walle.cc>
>> ---
>> Thanks to Vladimir Oltean, this was partially tested on a LX2160A RDB.
>> But
>> this patch is marked as RFC nonetheless, because there is too much
>> difference in the clock tree between LS1028A and LX2160A. It would be
>> nice
>> if someone could test it and add a Tested-by.
>
> You want someone to probe the SCK frequency?
No not really, just a thorough test.
> I expect that if frequency
> switching works on LS1028A, and the lx2160a_flexspi_divs table is
> correct (which, based on the documentation for
> FlexSPICR1[FlexSPI_CLK_DIV],
> it is), then it would work on LX2160A too?
The switching should work. Finding out wether it is correct can be
checked
by reading the raw register value, i.e. 01E0_0900h. But the parent clock
is
what is bothering me a little. Getting that wrong would lead to a wrong
SCK
output frequency albeit the divider is set to a correct value.
> Is there a simple test that can be made in order to trivially determine
> whether the frequencies are correct?
We already found out that there seems to be kind of a saturation with
higher frequencies, i.e. octal SPI bus is capable of a much higher
throughput but we only achieve 50MB/s. I'd have expected a much higher
datarate (I mean it is advertised as high performance and it uses a 8
bit
wide databus..). But anyway, it might make sense to go the other way,
i.e.
find out the max datathroughput at lower frequencies and look if it
makes
sense. Assuming no DDR, the throughput should be around your frequency.
For
example, having 4 MHz should result in 4MB/s data throughput.
OTOH we already saw that after linux booted - with the current device
tree
which has a setting of 50MHz max SCK frequency - the programmed divider
by
my driver is the same as the former setting (0x13, div-by-32); so this
series
doesn't change the SCK frequency.
-michael
prev parent reply other threads:[~2020-11-09 9:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-08 18:51 [PATCH v3 0/9] clk: qoriq fixes and new fsl-flexspi driver Michael Walle
2020-11-08 18:51 ` [PATCH v3 1/9] arm64: dts: ls1028a: fix ENETC PTP clock input Michael Walle
2020-11-30 9:20 ` Shawn Guo
2020-11-08 18:51 ` [PATCH v3 2/9] arm64: dts: ls1028a: fix FlexSPI " Michael Walle
2020-11-30 9:21 ` Shawn Guo
2020-11-08 18:51 ` [PATCH v3 3/9] clk: qoriq: provide constants for the type Michael Walle
2020-11-09 22:05 ` Rob Herring
2020-11-09 22:39 ` Michael Walle
2020-11-09 22:55 ` Rob Herring
2020-11-08 18:51 ` [PATCH v3 4/9] arm64: dts: ls1028a: use constants in the clockgen phandle Michael Walle
2020-11-20 9:25 ` [EXT] " Ashish Kumar
2020-11-20 9:38 ` Michael Walle
2020-11-20 9:51 ` [EXT] " Ashish Kumar
2020-11-20 10:05 ` Michael Walle
2020-11-08 18:51 ` [PATCH v3 5/9] clk: divider: add devm_clk_hw_register_divider_table() Michael Walle
2020-11-08 18:51 ` [PATCH v3 6/9] dt-bindings: clock: document the fsl-flexspi-clk driver Michael Walle
2020-11-08 18:51 ` [PATCH v3 7/9] clk: fsl-flexspi: new driver Michael Walle
2020-11-08 18:51 ` [PATCH v3 8/9] arm64: dts: ls1028a: fix FlexSPI clock Michael Walle
2020-11-08 18:51 ` [RFC PATCH v3 9/9] arm64: dts: lx2160a: " Michael Walle
2020-11-08 21:21 ` Vladimir Oltean
2020-11-09 9:43 ` Michael Walle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e165232e518c0f6c1b894311f00982a@walle.cc \
--to=michael@walle.cc \
--cc=ashish.kumar@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=vladimir.oltean@nxp.com \
--cc=xiaowei.bao@nxp.com \
--cc=yangbo.lu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).