From: schowdhu@codeaurora.org
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org,
Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
Sibi Sankar <sibis@codeaurora.org>,
Rajendra Nayak <rnayak@codeaurora.org>,
vkoul@kernel.org
Subject: Re: [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC
Date: Thu, 01 Apr 2021 13:52:07 +0530 [thread overview]
Message-ID: <0e389c1a842e66db58f2d9371b23c4f3@codeaurora.org> (raw)
In-Reply-To: <161704647819.3012082.13027529193947275446@swboyd.mtv.corp.google.com>
On 2021-03-30 01:04, Stephen Boyd wrote:
> Quoting Souradeep Chowdhury (2021-03-25 01:02:32)
>> diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> new file mode 100644
>> index 0000000..c6e0a9c
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/arm/msm/qcom,dcc.yaml
>> @@ -0,0 +1,49 @@
>> +# SPDX-License-Identifier: (GPL-2.0-or-later OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/arm/msm/qcom,dcc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Data Capture and Compare
>> +
>> +maintainers:
>> + - Souradeep Chowdhury <schowdhu@codeaurora.org>
>> +
>> +description: |
>> + DCC (Data Capture and Compare) is a DMA engine which is used to
>> save
>> + configuration data or system memory contents during catastrophic
>> failure
>> + or SW trigger.DCC is used to capture and store data for debugging
>> purpose
>
> Add space between trigger. and DCC?
Ack
>
>> +
>> +
>
> Drop double newline?
Ack
>
>> +properties:
>> + compatible:
>> + items:
>> + - enum:
>> + - qcom,sm8150-dcc
>> + - const: qcom,dcc
>> +
>> + reg:
>> + items:
>> + - description: DCC base register region
>> + - description: DCC RAM base register region
>> +
>> + reg-names:
>> + items:
>> + - const: dcc
>> + - const: dcc-ram
>> +
>> +required:
>> + - compatible
>> + - reg
>> + - reg-names
>
> Do we really need reg names? Seems like we can assume the ordering.
Ack
>
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> + - |
>> + dcc@10a2000{
>
> dma@10a2000? Or debug@10a2000?
Ack
>
>> + compatible = "qcom,sm8150-dcc","qcom,dcc";
>> + reg = <0x010a2000 0x1000>,
>> + <0x010ad000 0x2000>;
>> + reg-names = "dcc", "dcc-ram";
>> + };
next prev parent reply other threads:[~2021-04-01 8:23 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 8:02 [PATCH V2 0/5] Add driver support for Data Capture and Compare Engine(DCC) for SM8150 Souradeep Chowdhury
2021-03-25 8:02 ` [PATCH V2 1/5] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2021-03-27 17:49 ` Rob Herring
2021-03-29 19:34 ` Stephen Boyd
2021-04-01 8:22 ` schowdhu [this message]
2021-03-25 8:02 ` [PATCH V2 2/5] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2021-03-29 20:05 ` Stephen Boyd
2021-04-01 14:04 ` schowdhu
2021-04-02 0:50 ` Stephen Boyd
2021-04-07 15:35 ` schowdhu
2021-03-25 8:02 ` [PATCH V2 3/5] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver Souradeep Chowdhury
2021-03-29 20:09 ` Stephen Boyd
2021-04-01 15:42 ` schowdhu
2021-04-02 1:10 ` Stephen Boyd
2021-03-25 8:02 ` [PATCH V2 4/5] MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
2021-03-25 8:02 ` [PATCH V2 5/5] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
2021-03-26 22:08 ` kernel test robot
2021-03-29 6:32 ` [PATCH V3 0/5] Add driver support for Data Capture and Compare Engine(DCC) for SM8150 Souradeep Chowdhury
[not found] ` <cover.1616997837.git.schowdhu@codeaurora.org>
2021-03-29 6:32 ` [PATCH V3 1/5] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2021-03-29 7:57 ` schowdhu
2021-03-29 6:32 ` [PATCH V3 2/5] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2021-03-29 6:32 ` [PATCH V3 3/5] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver Souradeep Chowdhury
2021-03-29 6:32 ` [PATCH V3 4/5] MAINTAINERS: Add the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
2021-03-29 6:32 ` [PATCH V3 5/5] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
2021-03-29 7:49 ` [Resend PATCH V3 0/5] Add driver support for Data Capture and Compare Engine(DCC) for SM8150 Souradeep Chowdhury
[not found] ` <cover.1617001131.git.schowdhu@codeaurora.org>
2021-03-29 7:49 ` [Resend PATCH V3 1/5] dt-bindings: Added the yaml bindings for DCC Souradeep Chowdhury
2021-03-29 7:49 ` [Resend PATCH V3 2/5] soc: qcom: dcc: Add driver support for Data Capture and Compare unit(DCC) Souradeep Chowdhury
2021-03-29 7:49 ` [Resend PATCH V3 3/5] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver Souradeep Chowdhury
2021-03-29 7:49 ` [Resend PATCH V3 4/5] MAINTAINERS:Add the entry for DCC(Data Capture and Compare) driver support Souradeep Chowdhury
2021-03-29 7:49 ` [Resend PATCH V3 5/5] arm64: dts: qcom: sm8150: Add Data Capture and Compare(DCC) support node Souradeep Chowdhury
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e389c1a842e66db58f2d9371b23c4f3@codeaurora.org \
--to=schowdhu@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).