From: Frank Rowand <frowand.list@gmail.com>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
devicetree@vger.kernel.org,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
linux-renesas-soc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
Rob Herring <robh+dt@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues
Date: Wed, 24 Jan 2018 22:47:55 -0800 [thread overview]
Message-ID: <11cf8fac-d2fe-ecdb-546f-de3c3b42a637@gmail.com> (raw)
In-Reply-To: <20180122114948.mm5mg6zqw3hmjj4o@katana>
On 01/22/18 03:49, Wolfram Sang wrote:
> Hi Frank,
>
>> Please go back and read the thread for version 1. Simply resubmitting a
>> forward port is ignoring that whole conversation.
>>
>> There is a lot of good info in that thread. I certainly learned stuff in it.
>
> Yes, I did that and learned stuff, too. My summary of the discussion was:
>
> - you mentioned some drawbacks you saw (like the mixture of trace output
> and printk output)> - most of them look like addressed to me? (e.g. Steven showed a way to redirect
> printk to trace
> - you posted your version (which was, however, marked as "not user friendly"
> even by yourself)
Not exactly a fair quoting. There were two things I said:
"Here is a patch that I have used. It is not as user friendly in terms
of human readable stack traces (though a very small user space program
should be able to fix that)."
So easy to fix using existing userspace programs to convert kernel
addresses to symbols.
"FIXME: Currently using pr_err() so I don't need to set loglevel on boot.
So obviously not a user friendly tool!!!
The process is:
- apply patch
- configure, build, boot kernel
- analyze data
- remove patch"
So not friendly because it uses pr_err() instead of pr_debug(). In
a reply I said if I submitted my patches I would change it to use
pr_debug() instead. So not an issue.
And not user friendly because it requires patching the kernel.
Again a NOP if I submitted my patch, because the patch would
already be in the kernel.
But whatever, let's ignore that - a poor quoting is not a reason to
reject this version of the patch.
> - The discussion stalled over having two approaches
Then you should have stated such when you resubmitted.
> So, I thought reposting would be a good way of finding out if your
> concerns were addressed in the discussion or not. If I overlooked
Then you should have stated that there were concerns raised in the
discussion and asked me if my concerns were addressed.
> something, I am sorry for that. Still, my intention is to continue the
> discussion, not to ignore it. Because as it stands, we don't have such a
> debugging mechanism in place currently, and with people working with DT
> overlays, I'd think it would be nice to have.
>
> Kind regards,
>
> Wolfram
>
Rob suggested:
>
> @@ -25,8 +28,10 @@
> */
> struct device_node *of_node_get(struct device_node *node)
> {
> - if (node)
> + if (node) {
> kobject_get(&node->kobj);
> + trace_of_node_get(refcount_read(&node->kobj.kref.refcount), node->full_name);
Seems like there should be a kobj wrapper to read the refcount.
As far as I noticed, that was never addressed. I don't know the answer, but
the question was asked. And if there is no such function, then there is at
least kref_read(), which would improve the code a little bit.
I'll reply to the patch 0/1 and patch 1/1 emails with review comments.
-Frank
next prev parent reply other threads:[~2018-01-25 6:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-21 14:31 [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues Wolfram Sang
2018-01-21 14:31 ` [RFC PATCH v2 1/1] of: introduce event tracepoints for dynamic device_node lifecyle Wolfram Sang
2018-01-21 22:01 ` Steven Rostedt
2018-01-25 6:48 ` Frank Rowand
2018-01-25 6:58 ` Frank Rowand
[not found] ` <4cc627c4-1aaf-b8d5-5a26-eea7e596743f-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-25 8:01 ` Geert Uytterhoeven
2018-01-25 22:40 ` Tyrel Datwyler
[not found] ` <25f83d0d-bc67-f1b5-cadb-838987fd846d-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2018-01-25 23:31 ` Frank Rowand
2018-01-25 8:32 ` Frank Rowand
2018-01-22 8:43 ` [RFC PATCH v2 0/1] of: easier debugging for node life cycle issues Frank Rowand
2018-01-22 11:49 ` Wolfram Sang
2018-01-23 12:11 ` Michael Ellerman
2018-01-23 19:53 ` Frank Rowand
2018-01-25 6:47 ` Frank Rowand [this message]
[not found] ` <11cf8fac-d2fe-ecdb-546f-de3c3b42a637-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-25 23:12 ` Wolfram Sang
2018-01-26 0:42 ` Frank Rowand
2018-01-25 6:48 ` Frank Rowand
[not found] ` <20180121143117.19805-1-wsa+renesas-jBu1N2QxHDJrcw3mvpCnnVaTQe2KTcn/@public.gmane.org>
2018-01-25 6:55 ` Frank Rowand
2018-01-25 11:03 ` Steven Rostedt
2018-01-25 21:49 ` Frank Rowand
[not found] ` <a30d4cd3-0068-8cca-cc2f-ca207d0d278b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-25 23:14 ` Wolfram Sang
2018-01-26 0:46 ` Frank Rowand
2018-02-01 17:10 ` Steven Rostedt
2018-01-25 23:53 ` Tyrel Datwyler
2018-01-26 1:08 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11cf8fac-d2fe-ecdb-546f-de3c3b42a637@gmail.com \
--to=frowand.list@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tyreld@linux.vnet.ibm.com \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).