devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] video: drm: Add match table for drm platform device
@ 2012-09-18 18:35 Leela Krishna Amudala
  2012-09-19  8:18 ` Paul Menzel
  0 siblings, 1 reply; 2+ messages in thread
From: Leela Krishna Amudala @ 2012-09-18 18:35 UTC (permalink / raw)
  To: dri-devel, devicetree-discuss
  Cc: linux-samsung-soc, kgene.kim, inki.dae, jg1.han

This patch adds match table for drm platform device.

Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
---
 drivers/gpu/drm/exynos/exynos_drm_drv.c |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
index d070719..18abdcc 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
@@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct platform_device *pdev)
 	return 0;
 }
 
+#ifdef CONFIG_OF
+static const struct of_device_id drm_device_dt_match[] = {
+	{ .compatible = "samsung,exynos-drm-device"},
+	{},
+};
+MODULE_DEVICE_TABLE(of, drm_device_dt_match);
+#endif
+
 static struct platform_driver exynos_drm_platform_driver = {
 	.probe		= exynos_drm_platform_probe,
 	.remove		= __devexit_p(exynos_drm_platform_remove),
 	.driver		= {
 		.owner	= THIS_MODULE,
 		.name	= "exynos-drm",
+		.of_match_table = of_match_ptr(drm_device_dt_match),
 	},
 };
 
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] video: drm: Add match table for drm platform device
  2012-09-18 18:35 [PATCH] video: drm: Add match table for drm platform device Leela Krishna Amudala
@ 2012-09-19  8:18 ` Paul Menzel
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Menzel @ 2012-09-19  8:18 UTC (permalink / raw)
  To: Leela Krishna Amudala
  Cc: dri-devel, devicetree-discuss, kgene.kim, jg1.han, linux-samsung-soc

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

Dear Leela,


thank you for your patch.


Am Mittwoch, den 19.09.2012, 00:05 +0530 schrieb Leela Krishna Amudala:
> This patch adds match table for drm platform device.

Please drop that line as it is the same as in the subject line.

It would be better,

1. if you explain for what this will be used,
2. if this can be tested somehow,
3. if this fixes a bug,
4. why CONFIG_OF is needed.

> Signed-off-by: Leela Krishna Amudala <l.krishna@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_drm_drv.c |    9 +++++++++
>  1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> index d070719..18abdcc 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
> @@ -294,12 +294,21 @@ static int exynos_drm_platform_remove(struct platform_device *pdev)
>  	return 0;
>  }
>  
> +#ifdef CONFIG_OF
> +static const struct of_device_id drm_device_dt_match[] = {
> +	{ .compatible = "samsung,exynos-drm-device"},
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, drm_device_dt_match);
> +#endif
> +
>  static struct platform_driver exynos_drm_platform_driver = {
>  	.probe		= exynos_drm_platform_probe,
>  	.remove		= __devexit_p(exynos_drm_platform_remove),
>  	.driver		= {
>  		.owner	= THIS_MODULE,
>  		.name	= "exynos-drm",
> +		.of_match_table = of_match_ptr(drm_device_dt_match),
>  	},
>  };


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-09-19  8:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-09-18 18:35 [PATCH] video: drm: Add match table for drm platform device Leela Krishna Amudala
2012-09-19  8:18 ` Paul Menzel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).