From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ian Campbell Subject: Re: dtbs_install recursing on subdirs-y and dtbs-subdir leading to race? Date: Wed, 16 Mar 2016 09:13:08 +0000 Message-ID: <1458119588.28250.61.camel@debian.org> References: <1458118474.28250.54.camel@debian.org> <20160316090449.GW19428@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160316090449.GW19428@n2100.arm.linux.org.uk> Sender: linux-kbuild-owner@vger.kernel.org To: Russell King - ARM Linux Cc: linux-kbuild@vger.kernel.org, Michal Marek , devicetree@vger.kernel.org, Catalin Marinas , Will Deacon , Robert Richter , Ben Hutchings , linux-arm-kernel@lists.infradead.org, debian-kernel List-Id: devicetree@vger.kernel.org On Wed, 2016-03-16 at 09:04 +0000, Russell King - ARM Linux wrote: > On Wed, Mar 16, 2016 at 08:54:34AM +0000, Ian Campbell wrote: > > Where it appears that multiple instance of __dtbs_install_prep have > > been running in parallel at least the apm and arm subdirectories of > > arch/arm64/boot/dts, with both of them then racing in the=A0 > >=A0=A0=A0=A0=A0$(Q)if [ -d $(INSTALL_DTBS_PATH) ]; then mv > $(INSTALL_DTBS_PATH) $(INSTALL_DTBS_PATH).old; fi > > rule since apparently $(INSTALL_DTBS_PATH) existed during the "-d" > > check but had gone by the time of the move. >=20 > I've already sent a patch several times to remove this line, I believ= e > it's finally queued for this merge window. Yes, as I said further down in my mail: I understand that the mv bit of the rule in question is likely to b= e removed quite soon[1] but I think the underlying race / extra recur= sion still exits and might have other implications. (where [1] was a link to your patch). I still think it is unexpected (or at least unintended) that this rune is run in all subdirectories. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kbuild"= in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html