devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding
@ 2016-06-12  2:53 Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
                   ` (5 more replies)
  0 siblings, 6 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:53 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: devicetree, linux-kernel, dri-devel

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v3: None
Changes in v2:
- Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel

 .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt

diff --git a/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
new file mode 100644
index 0000000..4214151
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
@@ -0,0 +1,7 @@
+LG 9.7" (2048x1536 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "lg,lp097qx1-spa1"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
@ 2016-06-12  2:56 ` Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:56 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: devicetree, linux-kernel, dri-devel

The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v3:
- Correct the size of panel_desc to active area 208mmx147mm (Emil, Stéphane)
- Sort the lg_lp097qx1_spa1 before lg_lp120up1 (Emil)

Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 3a7bdf1..2d40a21 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1017,6 +1017,28 @@ static const struct panel_desc lg_lb070wv8 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
 };
 
+static const struct drm_display_mode lg_lp097qx1_spa1_mode = {
+	.clock = 205210,
+	.hdisplay = 2048,
+	.hsync_start = 2048 + 150,
+	.hsync_end = 2048 + 150 + 5,
+	.htotal = 2048 + 150 + 5 + 5,
+	.vdisplay = 1536,
+	.vsync_start = 1536 + 3,
+	.vsync_end = 1536 + 3 + 1,
+	.vtotal = 1536 + 3 + 1 + 9,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc lg_lp097qx1_spa1 = {
+	.modes = &lg_lp097qx1_spa1_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 208,
+		.height = 147,
+	},
+};
+
 static const struct drm_display_mode lg_lp120up1_mode = {
 	.clock = 162300,
 	.hdisplay = 1920,
@@ -1457,6 +1479,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "lg,lb070wv8",
 		.data = &lg_lb070wv8,
 	}, {
+		.compatible = "lg,lp097qx1-spa1",
+		.data = &lg_lp097qx1_spa1,
+	}, {
 		.compatible = "lg,lp120up1",
 		.data = &lg_lp120up1,
 	}, {
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
@ 2016-06-12  2:56 ` Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:56 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: dri-devel, devicetree, linux-kernel, Yakir Yang

The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD
panel connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Acked-by: Rob Herring <robh@kernel.org>
---
Changes in v3: None
Changes in v2:
- Add Rob's acked for dt-bindings of Samsung LSN122DL01 panel

 .../devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt   | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt

diff --git a/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
new file mode 100644
index 0000000..dba298b
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/samsung,lsn122dl01-c01.txt
@@ -0,0 +1,7 @@
+Samsung 12.2" (2560x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "samsung,lsn122dl01-c01"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
  2016-06-12  2:56 ` [PATCH v3 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang
@ 2016-06-12  2:56 ` Yakir Yang
  2016-06-13 17:00   ` Doug Anderson
  2016-06-12  2:56 ` [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
                   ` (2 subsequent siblings)
  5 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:56 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: devicetree, linux-kernel, dri-devel

The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
---
Changes in v3:
- Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)

Changes in v2: None

 drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 2d40a21..17cc973 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
 	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
 };
 
+static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
+	.clock = 271560,
+	.hdisplay = 2560,
+	.hsync_start = 2560 + 48,
+	.hsync_end = 2560 + 48 + 32,
+	.htotal = 2560 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 2,
+	.vsync_end = 1600 + 2 + 5,
+	.vtotal = 1600 + 2 + 5 + 57,
+	.vrefresh = 60,
+};
+
+static const struct panel_desc samsung_lsn122dl01_c01 = {
+	.modes = &samsung_lsn122dl01_c01_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 262,
+		.height = 164,
+	},
+};
+
 static const struct drm_display_mode samsung_ltn101nt05_mode = {
 	.clock = 54030,
 	.hdisplay = 1024,
@@ -1506,6 +1528,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "qiaodian,qd43003c0-40",
 		.data = &qd43003c0_40,
 	}, {
+		.compatible = "samsung,lsn122dl01-c01",
+		.data = &samsung_lsn122dl01_c01,
+	}, {
 		.compatible = "samsung,ltn101nt05",
 		.data = &samsung_ltn101nt05,
 	}, {
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
                   ` (2 preceding siblings ...)
  2016-06-12  2:56 ` [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
@ 2016-06-12  2:56 ` Yakir Yang
  2016-06-14 22:06   ` Rob Herring
  2016-06-12  2:56 ` [PATCH v3 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang
  2016-07-07 21:55 ` [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Thierry Reding
  5 siblings, 1 reply; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:56 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: devicetree, linux-kernel, dri-devel

The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
connected using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v3:
- Drop the extra comma in compatible name (Rob)
- Add the reviewed flag from Doug

Changes in v2:
- Add dt-bindings of Sharp LQ123P1JX31 panel in v2

 .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

diff --git a/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
new file mode 100644
index 0000000..bcb0e8a
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt
@@ -0,0 +1,7 @@
+Sharp 12.3" (2400x1600 pixels) TFT LCD panel
+
+Required properties:
+- compatible: should be "sharp,lq123p1jx31"
+
+This binding is compatible with the simple-panel binding, which is specified
+in simple-panel.txt in this directory.
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* [PATCH v3 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
                   ` (3 preceding siblings ...)
  2016-06-12  2:56 ` [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
@ 2016-06-12  2:56 ` Yakir Yang
  2016-07-07 21:55 ` [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Thierry Reding
  5 siblings, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-06-12  2:56 UTC (permalink / raw)
  To: David Airlie, Thierry Reding, Rob Herring, Pawel Moll,
	Mark Rutland, Kumar Gala, Ian Campbell, dianders, emil.l.velikov
  Cc: devicetree, linux-kernel, dri-devel

The Sharp LQ123P1JX31 is an 12.3", 2400x1600 TFT-LCD panel connected
using eDP interfaces.

Signed-off-by: Yakir Yang <ykk@rock-chips.com>
Reviewed-by: Doug Anderson <dianders@chromium.org>
Tested-by: Doug Anderson <dianders@chromium.org>
---
Changes in v3:
- Correct the size of panel_desc to active area 259mmx173mm (Doug)
- Add the reviewed/tested flag from Doug

Changes in v2:
- Add detail timing of Sharp LQ123P1JX31 panel in v2

 drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index 17cc973..412746b 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -1314,6 +1314,29 @@ static const struct panel_desc samsung_ltn140at29_301 = {
 	},
 };
 
+static const struct drm_display_mode sharp_lq123p1jx31_mode = {
+	.clock = 252750,
+	.hdisplay = 2400,
+	.hsync_start = 2400 + 48,
+	.hsync_end = 2400 + 48 + 32,
+	.htotal = 2400 + 48 + 32 + 80,
+	.vdisplay = 1600,
+	.vsync_start = 1600 + 3,
+	.vsync_end = 1600 + 3 + 10,
+	.vtotal = 1600 + 3 + 10 + 33,
+	.vrefresh = 60,
+	.flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC,
+};
+
+static const struct panel_desc sharp_lq123p1jx31 = {
+	.modes = &sharp_lq123p1jx31_mode,
+	.num_modes = 1,
+	.size = {
+		.width = 259,
+		.height = 173,
+	},
+};
+
 static const struct drm_display_mode shelly_sca07010_bfn_lnn_mode = {
 	.clock = 33300,
 	.hdisplay = 800,
@@ -1537,6 +1560,9 @@ static const struct of_device_id platform_of_match[] = {
 		.compatible = "samsung,ltn140at29-301",
 		.data = &samsung_ltn140at29_301,
 	}, {
+		.compatible = "sharp,lq123p1jx31",
+		.data = &sharp_lq123p1jx31,
+	}, {
 		.compatible = "shelly,sca07010-bfn-lnn",
 		.data = &shelly_sca07010_bfn_lnn,
 	}, {
-- 
1.9.1


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
  2016-06-12  2:56 ` [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
@ 2016-06-13 17:00   ` Doug Anderson
  2016-06-14  8:57     ` Thierry Reding
  2016-07-08  1:51     ` Yakir Yang
  0 siblings, 2 replies; 13+ messages in thread
From: Doug Anderson @ 2016-06-13 17:00 UTC (permalink / raw)
  To: Yakir Yang
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, Emil Velikov,
	linux-kernel, Rob Herring, dri-devel, Kumar Gala

Yakir,

On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> connected using eDP interfaces.
>
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> ---
> Changes in v3:
> - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
>
> Changes in v2: None
>
>  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index 2d40a21..17cc973 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>  };
>
> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> +       .clock = 271560,
> +       .hdisplay = 2560,
> +       .hsync_start = 2560 + 48,
> +       .hsync_end = 2560 + 48 + 32,
> +       .htotal = 2560 + 48 + 32 + 80,
> +       .vdisplay = 1600,
> +       .vsync_start = 1600 + 2,
> +       .vsync_end = 1600 + 2 + 5,
> +       .vtotal = 1600 + 2 + 5 + 57,
> +       .vrefresh = 60,
> +};
> +
> +static const struct panel_desc samsung_lsn122dl01_c01 = {
> +       .modes = &samsung_lsn122dl01_c01_mode,
> +       .num_modes = 1,
> +       .size = {
> +               .width = 262,
> +               .height = 164,

Earlier you said that the active area of this panel was:

> Display area     262.656(H) X 164.16(V)         (12.2”diagonal)

In other panels I looked at the EDID tended to round numbers, not
truncate them.  For instance the Starry panel that I sent the patch
for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
says "263 x 164".

That would mean your width should be 263 mm, not 262 mm.

-Doug
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
  2016-06-13 17:00   ` Doug Anderson
@ 2016-06-14  8:57     ` Thierry Reding
  2016-07-08  1:51     ` Yakir Yang
  1 sibling, 0 replies; 13+ messages in thread
From: Thierry Reding @ 2016-06-14  8:57 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, Emil Velikov,
	linux-kernel, dri-devel, Rob Herring, Kumar Gala


[-- Attachment #1.1: Type: text/plain, Size: 2271 bytes --]

On Mon, Jun 13, 2016 at 10:00:45AM -0700, Doug Anderson wrote:
> Yakir,
> 
> On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
> > The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
> > connected using eDP interfaces.
> >
> > Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > ---
> > Changes in v3:
> > - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
> >
> > Changes in v2: None
> >
> >  drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> > index 2d40a21..17cc973 100644
> > --- a/drivers/gpu/drm/panel/panel-simple.c
> > +++ b/drivers/gpu/drm/panel/panel-simple.c
> > @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
> >         .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
> >  };
> >
> > +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
> > +       .clock = 271560,
> > +       .hdisplay = 2560,
> > +       .hsync_start = 2560 + 48,
> > +       .hsync_end = 2560 + 48 + 32,
> > +       .htotal = 2560 + 48 + 32 + 80,
> > +       .vdisplay = 1600,
> > +       .vsync_start = 1600 + 2,
> > +       .vsync_end = 1600 + 2 + 5,
> > +       .vtotal = 1600 + 2 + 5 + 57,
> > +       .vrefresh = 60,
> > +};
> > +
> > +static const struct panel_desc samsung_lsn122dl01_c01 = {
> > +       .modes = &samsung_lsn122dl01_c01_mode,
> > +       .num_modes = 1,
> > +       .size = {
> > +               .width = 262,
> > +               .height = 164,
> 
> Earlier you said that the active area of this panel was:
> 
> > Display area     262.656(H) X 164.16(V)         (12.2”diagonal)
> 
> In other panels I looked at the EDID tended to round numbers, not
> truncate them.  For instance the Starry panel that I sent the patch
> for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
> says "263 x 164".
> 
> That would mean your width should be 263 mm, not 262 mm.

Yes, rounding is what I've also applied to all panels that I added.
While it isn't documented I hope that other panels did round, rather
than truncate, as well.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding
  2016-06-12  2:56 ` [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
@ 2016-06-14 22:06   ` Rob Herring
  0 siblings, 0 replies; 13+ messages in thread
From: Rob Herring @ 2016-06-14 22:06 UTC (permalink / raw)
  To: Yakir Yang
  Cc: David Airlie, Thierry Reding, Pawel Moll, Mark Rutland,
	Kumar Gala, Ian Campbell, dianders, emil.l.velikov, dri-devel,
	devicetree, linux-kernel

On Sun, Jun 12, 2016 at 10:56:16AM +0800, Yakir Yang wrote:
> The Sharp LQ123P1JX31 is an 12.3" 2400x1600 TFT-LCD panel
> connected using eDP interfaces.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
> ---
> Changes in v3:
> - Drop the extra comma in compatible name (Rob)
> - Add the reviewed flag from Doug
> 
> Changes in v2:
> - Add dt-bindings of Sharp LQ123P1JX31 panel in v2
> 
>  .../devicetree/bindings/display/panel/sharp,lq123p1jx31.txt        | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/sharp,lq123p1jx31.txt

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding
  2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
                   ` (4 preceding siblings ...)
  2016-06-12  2:56 ` [PATCH v3 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang
@ 2016-07-07 21:55 ` Thierry Reding
  2016-07-07 21:57   ` Thierry Reding
  5 siblings, 1 reply; 13+ messages in thread
From: Thierry Reding @ 2016-07-07 21:55 UTC (permalink / raw)
  To: Yakir Yang
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell,
	emil.l.velikov, dianders, dri-devel, linux-kernel, Rob Herring,
	Kumar Gala


[-- Attachment #1.1: Type: text/plain, Size: 666 bytes --]

On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote:
> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
> connected using eDP interfaces.
> 
> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Changes in v3: None
> Changes in v2:
> - Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel
> 
>  .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
>  1 file changed, 7 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt

Applied all six patches, though I modified 3/6 as Doug suggested.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding
  2016-07-07 21:55 ` [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Thierry Reding
@ 2016-07-07 21:57   ` Thierry Reding
       [not found]     ` <20160707215659.GD744-+E7KM1FDEuO2P7RxrfNFTMXXUOn6P5/W@public.gmane.org>
  0 siblings, 1 reply; 13+ messages in thread
From: Thierry Reding @ 2016-07-07 21:57 UTC (permalink / raw)
  To: Yakir Yang
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell,
	emil.l.velikov, dianders, dri-devel, linux-kernel, Rob Herring,
	Kumar Gala


[-- Attachment #1.1: Type: text/plain, Size: 795 bytes --]

On Thu, Jul 07, 2016 at 11:55:23PM +0200, Thierry Reding wrote:
> On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote:
> > The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
> > connected using eDP interfaces.
> > 
> > Signed-off-by: Yakir Yang <ykk@rock-chips.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> > Changes in v3: None
> > Changes in v2:
> > - Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel
> > 
> >  .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
> 
> Applied all six patches, though I modified 3/6 as Doug suggested.

I mean patch 4/6, of course.

Thierry

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel
  2016-06-13 17:00   ` Doug Anderson
  2016-06-14  8:57     ` Thierry Reding
@ 2016-07-08  1:51     ` Yakir Yang
  1 sibling, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-07-08  1:51 UTC (permalink / raw)
  To: Doug Anderson
  Cc: Mark Rutland, devicetree, Pawel Moll, Ian Campbell, Emil Velikov,
	linux-kernel, Rob Herring, dri-devel, Kumar Gala

Doug,

On 06/14/2016 01:00 AM, Doug Anderson wrote:
> Yakir,
>
> On Sat, Jun 11, 2016 at 7:56 PM, Yakir Yang <ykk@rock-chips.com> wrote:
>> The Samsung LSN122DL01-C01 is an 12.2" 2560x1600 (WQXGA) TFT-LCD panel
>> connected using eDP interfaces.
>>
>> Signed-off-by: Yakir Yang <ykk@rock-chips.com>
>> ---
>> Changes in v3:
>> - Correct the size of panel_desc to active area 262mmx164mm (Emil, Stéphane)
>>
>> Changes in v2: None
>>
>>   drivers/gpu/drm/panel/panel-simple.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
>> index 2d40a21..17cc973 100644
>> --- a/drivers/gpu/drm/panel/panel-simple.c
>> +++ b/drivers/gpu/drm/panel/panel-simple.c
>> @@ -1246,6 +1246,28 @@ static const struct panel_desc qd43003c0_40 = {
>>          .bus_format = MEDIA_BUS_FMT_RGB888_1X24,
>>   };
>>
>> +static const struct drm_display_mode samsung_lsn122dl01_c01_mode = {
>> +       .clock = 271560,
>> +       .hdisplay = 2560,
>> +       .hsync_start = 2560 + 48,
>> +       .hsync_end = 2560 + 48 + 32,
>> +       .htotal = 2560 + 48 + 32 + 80,
>> +       .vdisplay = 1600,
>> +       .vsync_start = 1600 + 2,
>> +       .vsync_end = 1600 + 2 + 5,
>> +       .vtotal = 1600 + 2 + 5 + 57,
>> +       .vrefresh = 60,
>> +};
>> +
>> +static const struct panel_desc samsung_lsn122dl01_c01 = {
>> +       .modes = &samsung_lsn122dl01_c01_mode,
>> +       .num_modes = 1,
>> +       .size = {
>> +               .width = 262,
>> +               .height = 164,
> Earlier you said that the active area of this panel was:
>
>> Display area     262.656(H) X 164.16(V)         (12.2”diagonal)
> In other panels I looked at the EDID tended to round numbers, not
> truncate them.  For instance the Starry panel that I sent the patch
> for says in the manual "262.7712 (H) x 164.232 (V)" but then the EDID
> says "263 x 164".

Ah, got it, done.

Thanks,
- Yakir

> That would mean your width should be 263 mm, not 262 mm.
>
> -Doug
>
>
>


_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding
       [not found]     ` <20160707215659.GD744-+E7KM1FDEuO2P7RxrfNFTMXXUOn6P5/W@public.gmane.org>
@ 2016-07-19  1:51       ` Yakir Yang
  0 siblings, 0 replies; 13+ messages in thread
From: Yakir Yang @ 2016-07-19  1:51 UTC (permalink / raw)
  To: Thierry Reding
  Cc: David Airlie, Rob Herring, Pawel Moll, Mark Rutland, Kumar Gala,
	Ian Campbell, dianders-F7+t8E8rja9g9hUCZPvPmw,
	emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w,
	dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

Thierry,

On 07/08/2016 05:57 AM, Thierry Reding wrote:
> On Thu, Jul 07, 2016 at 11:55:23PM +0200, Thierry Reding wrote:
>> On Sun, Jun 12, 2016 at 10:53:30AM +0800, Yakir Yang wrote:
>>> The LG LP097QX1-SPA1 is an 9.7", 2048x1536 (QXGA) TFT-LCD panel
>>> connected using eDP interfaces.
>>>
>>> Signed-off-by: Yakir Yang <ykk-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>>> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> ---
>>> Changes in v3: None
>>> Changes in v2:
>>> - Add Rob's acked for dt-bindings of LG LP097QX1-SPA1 panel
>>>
>>>   .../devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt         | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>>   create mode 100644 Documentation/devicetree/bindings/display/panel/lg,lp097qx1-spa1.txt
>> Applied all six patches, though I modified 3/6 as Doug suggested.
> I mean patch 4/6, of course.

Wow, good news, thanks a lot :-D

- Yakir

> Thierry


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2016-07-19  1:51 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-06-12  2:53 [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Yakir Yang
2016-06-12  2:56 ` [PATCH v3 2/6] drm/panel: simple: Add support for LG LP097QX1-SPA1 2048x1536 panel Yakir Yang
2016-06-12  2:56 ` [PATCH v3 3/6] dt-bindings: add Samsung LSN122DL01-C01 panel binding Yakir Yang
2016-06-12  2:56 ` [PATCH v3 4/6] drm/panel: simple: Add support for Samsung LSN122DL01-C01 2560x1600 panel Yakir Yang
2016-06-13 17:00   ` Doug Anderson
2016-06-14  8:57     ` Thierry Reding
2016-07-08  1:51     ` Yakir Yang
2016-06-12  2:56 ` [PATCH v3 5/6] dt-bindings: add Sharp LQ123P1JX31 panel binding Yakir Yang
2016-06-14 22:06   ` Rob Herring
2016-06-12  2:56 ` [PATCH v3 6/6] drm/panel: simple: Add support for Sharp LQ123P1JX31 2400x1600 panel Yakir Yang
2016-07-07 21:55 ` [PATCH v3 1/6] dt-bindings: add LG LP097QX1-SPA1 panel binding Thierry Reding
2016-07-07 21:57   ` Thierry Reding
     [not found]     ` <20160707215659.GD744-+E7KM1FDEuO2P7RxrfNFTMXXUOn6P5/W@public.gmane.org>
2016-07-19  1:51       ` Yakir Yang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).