From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
To: "stefan@agner.ch" <stefan@agner.ch>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
Max Krummenacher <max.krummenacher@toradex.com>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"fabio.estevam@nxp.com" <fabio.estevam@nxp.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support
Date: Thu, 16 Jun 2016 10:44:18 +0000 [thread overview]
Message-ID: <1466073856.3884.11.camel@toradex.com> (raw)
In-Reply-To: <59f88a185c67034087f3eabf88da6c8c@agner.ch>
Sali Stefan
On Wed, 2016-06-15 at 22:37 -0700, Stefan Agner wrote:
> On 2016-06-11 19:31, Shawn Guo wrote:
> >
> > On Tue, Jun 07, 2016 at 07:37:09PM -0700, Stefan Agner wrote:
> > >
> > <snip>
> > >
> > > +/ {
> > > + model = "Toradex Colibri iMX7D on Colibri Evaluation
> > > Board V3";
> > > + compatible = "toradex,colibri_imx7d-eval",
> > > "toradex,colibri_imx7d", \
> > We always use hyphen than underscore in compatible string.
> We always used underscores, this goes back to the first Colibri
> specific
> device tree: tegra20-iris-512.dts.
>
> I would rather prefer to not change this for the sake of
> consistency...
> What do you think?
I have been there before when submitting a first Apalis TK1 version:
https://lkml.org/lkml/2016/5/16/288
Upon Rob Herring's suggestion I changed it now all to dashes:
https://lkml.org/lkml/2016/5/27/399
Even in our downstream U-Boot:
http://git.toradex.com/cgit/u-boot-toradex.git/commit/?h=2015.04-torade
x-next&id=4ae2e657f3350422ad81b1632de156bdd9517206
Of course for Colibri iMX7 one could argue that we already sold a
couple hundred pieces still using underscores. However I guess we could
still change to dashes now as those were all prototype, sample and/or
beta.
Cheers
Marcel
prev parent reply other threads:[~2016-06-16 10:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 2:37 [PATCH 0/3] ARM: dts: imx7d: add i.MX 7Solo and Colibri iMX7S/D dts Stefan Agner
2016-06-08 2:37 ` [PATCH 1/3] ARM: dts: imx7d: create i.MX 7Solo base device tree Stefan Agner
[not found] ` <20160608023709.32090-2-stefan-XLVq0VzYD2Y@public.gmane.org>
2016-06-12 1:35 ` Shawn Guo
2016-06-19 4:20 ` Stefan Agner
[not found] ` <9d870fb1be40772a50f08d467df048dc-XLVq0VzYD2Y@public.gmane.org>
2016-06-21 3:20 ` Shawn Guo
2016-06-08 2:37 ` [PATCH 2/3] ARM: dts: imx7d: move input header into " Stefan Agner
[not found] ` <20160608023709.32090-3-stefan-XLVq0VzYD2Y@public.gmane.org>
2016-06-08 7:29 ` Igor Grinberg
2016-06-08 2:37 ` [PATCH 3/3] ARM: dts: imx7: add Toradex Colibri iMX7S/iMX7D support Stefan Agner
2016-06-12 2:31 ` Shawn Guo
2016-06-16 5:37 ` Stefan Agner
2016-06-16 10:44 ` Marcel Ziswiler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466073856.3884.11.camel@toradex.com \
--to=marcel.ziswiler@toradex.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=max.krummenacher@toradex.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stefan@agner.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).