From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
To: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing in 32-bit mode
Date: Thu, 12 Oct 2017 11:19:55 +0800 [thread overview]
Message-ID: <1507778395.21840.15.camel@mtkswgap22> (raw)
In-Reply-To: <d34460e3-9233-3c31-578d-cf2fe91a4316-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
On Tue, 2017-10-10 at 11:38 +0200, Matthias Brugger wrote:
>
> On 08/15/2017 11:09 AM, sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org wrote:
> > From: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> >
> > Some regulators such as MediaTek MT6380 also has to be written in
> > 32-bit mode. So the patch adds pwrap_write32, rename old pwrap_write
> > into pwrap_write16 and one additional function pointer is introduced
> > for increasing flexibility allowing the determination which mode is
> > used by the pwrap slave detection through device tree.
> >
> > Signed-off-by: Chenglin Xu <chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Chen Zhong <chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > Signed-off-by: Sean Wang <sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > drivers/soc/mediatek/mtk-pmic-wrap.c | 63 +++++++++++++++++++++++++++---------
> > 1 file changed, 47 insertions(+), 16 deletions(-)
> >
> > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c
> > index 7cd581b..9d1f4c6 100644
> > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c
> > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c
> > @@ -506,6 +506,7 @@ struct pwrap_slv_type {
> > * which type is used by the detection through device tree.
> > */
> > int (*pwrap_read)(struct pmic_wrapper *wrp, u32 adr, u32 *rdata);
> > + int (*pwrap_write)(struct pmic_wrapper *wrp, u32 adr, u32 wdata);
> > };
> >
> > struct pmic_wrapper {
> > @@ -600,22 +601,6 @@ static int pwrap_wait_for_state(struct pmic_wrapper *wrp,
> > } while (1);
> > }
> >
> > -static int pwrap_write(struct pmic_wrapper *wrp, u32 adr, u32 wdata)
> > -{
> > - int ret;
> > -
> > - ret = pwrap_wait_for_state(wrp, pwrap_is_fsm_idle);
> > - if (ret) {
> > - pwrap_leave_fsm_vldclr(wrp);
> > - return ret;
> > - }
> > -
> > - pwrap_writel(wrp, (1 << 31) | ((adr >> 1) << 16) | wdata,
> > - PWRAP_WACS2_CMD);
> > -
> > - return 0;
> > -}
> > -
> > static int pwrap_read16(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)
> > {
> > int ret;
> > @@ -672,6 +657,49 @@ static int pwrap_read(struct pmic_wrapper *wrp, u32 adr, u32 *rdata)
> > return wrp->slave->pwrap_read(wrp, adr, rdata);
> > }
> >
> > +static int pwrap_write16(struct pmic_wrapper *wrp, u32 adr, u32 wdata)
> > +{
> > + int ret;
> > +
> > + ret = pwrap_wait_for_state(wrp, pwrap_is_fsm_idle);
> > + if (ret) {
> > + pwrap_leave_fsm_vldclr(wrp);
> > + return ret;
> > + }
> > +
> > + pwrap_writel(wrp, (1 << 31) | ((adr >> 1) << 16) | wdata,
> > + PWRAP_WACS2_CMD);
> > +
> > + return 0;
> > +}
> > +
> > +static int pwrap_write32(struct pmic_wrapper *wrp, u32 adr, u32 wdata)
> > +{
> > + int ret, msb, rdata;
> > +
> > + for (msb = 0; msb < 2; msb++) {
> > + ret = pwrap_wait_for_state(wrp, pwrap_is_fsm_idle);
> > + if (ret) {
> > + pwrap_leave_fsm_vldclr(wrp);
> > + return ret;
> > + }
> > +
> > + pwrap_writel(wrp, (1 << 31) | (msb << 30) | (adr << 16) |
> > + ((wdata >> (msb * 16)) & 0xffff),
> > + PWRAP_WACS2_CMD);
> > +
> > + if (!msb)
> > + pwrap_read(wrp, adr, &rdata);
>
> Just so that I understand, you have to read back the half-written register
> before you can write the second part?
>
Yup, the pwrap_read operation is the requirement of hardware used for
the synchronization between two successive 16-bit pwrap_writel
operations composing one 32-bit bus writing. Otherwise, we'll find the
result fails for the lower 16-bit pwrap writing.
> Other then that it looks fine to me.
>
> Regards,
> Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-10-12 3:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-15 9:09 [PATCH v3 0/9] Add PMIC support to MediaTek MT7622 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 9:09 ` [PATCH v3 1/9] dt-bindings: arm: mediatek: add MT7622 string to the PMIC wrapper doc sean.wang
2017-08-15 9:09 ` [PATCH v3 4/9] soc: mediatek: pwrap: add pwrap_read32 for reading in 32-bit mode sean.wang
2017-08-15 9:09 ` [PATCH v3 5/9] soc: mediatek: pwrap: add pwrap_write32 for writing " sean.wang
[not found] ` <236a04acb383fc655549bc345a16a2d015e5727d.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 9:38 ` Matthias Brugger
[not found] ` <d34460e3-9233-3c31-578d-cf2fe91a4316-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 3:19 ` Sean Wang [this message]
[not found] ` <cover.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-08-15 9:09 ` [PATCH v3 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 11:50 ` Mark Brown
[not found] ` <20170815115038.65wos2ega2akxet4-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2017-08-15 15:06 ` Sean Wang
2017-08-15 15:10 ` Mark Brown
2017-08-15 15:10 ` Applied "regulator: Add document for MediaTek MT6380 regulator" to the regulator tree Mark Brown
2017-08-15 9:09 ` [PATCH v3 3/9] regulator: mt6380: Add support for MT6380 sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-08-15 15:11 ` Applied "regulator: mt6380: Add support for MT6380" to the regulator tree Mark Brown
2017-08-15 9:09 ` [PATCH v3 6/9] soc: mediatek: pwrap: update pwrap_init without slave programming sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <23b1e9fa5d4d8932b36e08d2a6713d4f33c055d9.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 9:53 ` Matthias Brugger
2017-08-15 9:09 ` [PATCH v3 7/9] soc: mediatek: pwrap: add MediaTek MT6380 as one slave of pwrap sean.wang-NuS5LvNUpcJWk0Htik3J/w
[not found] ` <398d87c6ae2b414016fc0c0a9c6bada3ce746118.1502779753.git.sean.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-10 10:02 ` Matthias Brugger
[not found] ` <0491f3fc-0404-c775-70f3-8bc86b3cf6c8-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-12 3:44 ` Sean Wang
2017-08-15 9:09 ` [PATCH v3 8/9] soc: mediatek: pwrap: add support for MT7622 SoC sean.wang-NuS5LvNUpcJWk0Htik3J/w
2017-10-10 9:57 ` Matthias Brugger
2017-08-15 9:09 ` [PATCH v3 9/9] soc: mediatek: pwrap: fixup warnings from coding style sean.wang
2017-10-10 10:03 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1507778395.21840.15.camel@mtkswgap22 \
--to=sean.wang-nus5lvnupcjwk0htik3j/w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=chen.zhong-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=chenglin.xu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=henryc.chen-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).